Windows VS2010

[Kelly O'Hair]

Looks fine to me.

-kto

On Oct 8, 2010, at 11:45 AM, Xueming Shen wrote:

> Kelly,
>
> Alan might be off-line now. Can you help review the change?
>
> The change is to define our own MIN2.
>
> http://cr.openjdk.java.net/~sherman/6990639/webrev/
>
> Verified via jprt hotspotwest just know. There was a failure on  
> windows-x64,
> but it does not appear to be related. Alan said it  might be 2D  
> (lcms) related.
>
> -Sherman
>
>
> On 10/08/2010 11:41 AM, Xueming Shen wrote:
>> CR 6990639 Created, P3 java/classes_util Fix for #6975829 breaks  
>> solaris build.
>>
>> A fix is on the way.
>>
>> Sherman
>>
>> On 10/08/2010 11:33 AM, Kelly O'Hair wrote:
>>>
>>> Anyone seen this failure before...  The very latest jdk7/tl/jdk  
>>> repo....
>>>
>>> I'm testing Windows XP & VS2010 builds:
>>>
>>> Created ../../../build/windows-i586/tmp/sun/java.util.zip/zip/ 
>>> obj_gO/zip.lcf
>>> C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll -out:../../../build/ 
>>> windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll \
>>>  -map:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ 
>>> zip.map \
>>>  -nologo /opt:REF /incremental:no /manifest /debug /LIBPATH:C:/ 
>>> DXSDK/Lib  @../../../build/windows-i586/tmp/sun/java.util.zip/zip/ 
>>> obj_gO/zip.lcf \
>>>  -export:ZIP_Open -export:ZIP_Close -export:ZIP_FindEntry - 
>>> export:ZIP_ReadEntry -export:ZIP_GetNextEntry ../../../build/ 
>>> windows-i586/lib/java.lib ../../../build/windows-i586/lib/ 
>>> jvm.lib  ../../../build/windows-i586/lib/java.lib advapi32.lib
>>>   Creating library ../../../build/windows-i586/tmp/sun/ 
>>> java.util.zip/zip/obj_gO/zip.lib and object ../../../build/windows- 
>>> i586/tmp/sun/java.util.zip/zip/obj_gO/zip.exp
>>> Inflater.obj : error LNK2019: unresolved external symbol _MIN  
>>> referenced in function _Java_java_util_zip_Inflater_inflateBytes at 28
>>> ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ 
>>> zip.dll : fatal error LNK1120: 1 unresolved externals
>>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: *** [../../../ 
>>> build/windows-i586/bin/zip.dll] Error 1120
>>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: Leaving  
>>> directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java/zip'
>>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: *** [all]  
>>> Error 1
>>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: Leaving  
>>> directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java'
>>> gnumake.exe[1]: *** [all] Error 1
>>> gnumake.exe[1]: Leaving directory `C:/temp/jprt/P2/B/ 
>>> 180435.jprtadm/source/make'
>>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [fastdebug]  
>>> Error 2
>>>
>>> -kto
>>>
>>
>