Code Review Request for 6994413: JDK_GetVersionInfo0 only expects a two digit build number

David Holmes David.Holmes at oracle.com
Sat Oct 30 02:28:04 UTC 2010


Hi Mandy,

Mandy Chung said the following on 10/30/10 07:38:
> I have a fix for:
>    6994413 JDK_GetVersionInfo0 only expects a two digit build number
> 
> Webrev at:
>    http://cr.openjdk.java.net/~mchung/6994413/webrev.00/

If the build "number" consists of just 'b' then you'll end up doing atoi 
on an empty string - will that have the right effect?

Otherwise change looks ok, but I didn't review the test case (which 
doesn't seem directly related to this fixc anyway).

David

> Can you please review it?
> 
> Thanks
> Mandy
> 
> On 10/24/10 5:41 PM, David Holmes wrote:
>> FYI I just filed:
>>
>> 6994413 JDK_GetVersionInfo0 only expects a two digit build number
>>
>> Since b100 we've lost the build number from the version string made 
>> available to the VM. The above is filed under java->java->build but 
>> that may not be the right place.
>>
>> Cheers,
>> David Holmes
> 



More information about the core-libs-dev mailing list