Please review: 7029048: LD_LIBRARY_PATH launcher changes

[Kumar Srinivasan]

Mandy,

>
> This looks okay to me and the change in java_md.c is mostly bringing 
> back what you purged.
>    
> http://hg.openjdk.java.net/jdk7/jdk7/jdk/diff/de45eac5670e/src/solaris/bin/java_md.c
>
> I briefly compared this fix with that changeset and a lot of testing 
> to verify this fix.  Minor comment:
>    java_md.c a typo in L128 "propogate" - should be "propagate"
oops will do.

>    test/tools/launcher/Test7029048.java: should it be marked with 
> "othervm" test in @run clause?

No. not really,  since the "driver/main" creates "test vectors" and 
compares them, ie.
it configures the inputs, reaps the output, and analyzes the results, 
therefore this
can remain in the samevm.

Thanks

Kumar

>
> Mandy
>
> On 04/04/11 16:36, Kumar Srinivasan wrote:
>> Hello core-libs friends,
>>
>> Background:
>> Earlier in the jdk7 development  setting of LD_LIBRARY_PATH was purged
>> in the launcher, this is a good thing!, Joe has an excellent blog 
>> which explains
>> the rational etc. etc. here:
>> http://blogs.sun.com/darcy/entry/purging_ld_library_path
>>
>> More background:
>> Unfortunately!, the library versioning  that Kelly proposed earlier 
>> on build-dev,
>> <attached here for reference >  is infeasible  for jdk7, though this 
>> is the correct
>> approach.
>>
>> Thus the  approach contained here, allows us to provide a 
>> transitional path to the
>> version scheme in the future. This is also the reason, the c-code is 
>> encapsulated
>> within a conditional and the test has been separated, such that these 
>> can be jettisoned
>> when required.
>>
>> This explains the current proposed fix:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7029048
>>
>> The old changeset for reference:
>> The old changeset:   
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/de45eac5670e
>>
>> and finally here is the proposed webrev:
>> http://cr.openjdk.java.net/~ksrini/7029048/webrev.0/
>>
>> Thanks
>> Kumar
>