Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

Lance Andersen - Oracle lance.andersen at oracle.com
Mon Apr 11 18:55:44 UTC 2011


On Apr 11, 2011, at 2:48 PM, Alan Bateman wrote:

> Lance Andersen - Oracle wrote:
>> :
>>> 
>>> PS: javac was updated recently to emit warnings for unreachable catch clauses and one place that generates this warning is src/share/classes/com/sun/rowset/CachedRowSetImpl.java:947. It would be great to get that one fixed while you are fixing the other warnings.
>> 
>> If you are OK with do it as part of this change, happy to change.
> Absolutely, warnings needs to be eliminated. Looks to me that the try/catch can be completely removed from that method.

Yep, the  try/catch block can definitely go away....

Regards
Lance
> 
> -Alan.


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com




More information about the core-libs-dev mailing list