Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

Ulf Zibis Ulf.Zibis at gmx.de
Fri Apr 15 08:34:27 UTC 2011


Am 15.04.2011 01:44, schrieb David Holmes:
> Ulf,
>
> Ulf Zibis said the following on 04/15/11 04:02:
>> Oops, SystemRoot could be null theoretically. So forget my comment about NUL termination.
>>
>> But anyway, should we allow to have get("SystemRoot") != getEnv("SystemRoot")?
>>
>> Is it correct to defaultly set the "SystemRoot" variable on non-Windows OS?
>
> This ProcessEnvironment.java is a Windows specific file.
>

Much thanks David for clarification.
IMHO there should be a big hint in this file:

//////////////////////////////////////////////////////////////////////////////////
// This is the Windows implementation of this class! //
//////////////////////////////////////////////////////////////////////////////////

-Ulf




More information about the core-libs-dev mailing list