Review Request (1-line fix): 7032589 "FileHandler leaking file descriptor of the file lock"

[Rémi Forax]

On 04/15/2011 07:55 PM, Daniel D. Daugherty wrote:
> Thumbs up.
>
> Dan

Hi Mandy,
if fc.close() throws an IOException , it goes wrong.
I think you need to put fc.close() in its own a try/catch(IOException).

Rémi

>
>
> On 4/15/2011 11:01 AM, Mandy Chung wrote:
>>  Fix for 7032589: FileHandler leaking file descriptor of the file lock
>>
>> Webrev at:
>>    http://cr.openjdk.java.net/~mchung/jdk7/7032589/webrev.00/
>>
>> When a log file is currently being used, tryLock() will fail and it 
>> has to close the file channel of the lock file
>>
>> Thanks
>> Mandy