Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

Ulf Zibis Ulf.Zibis at gmx.de
Mon Apr 18 14:14:18 UTC 2011


Am 15.04.2011 15:43, schrieb Michael McMahon:
>
> I have incorporated much of Ulf's approach into this version.
>
> I agree with Alan about the spec. We could find other variables in the future that need
> to be set, but can have alternative values other than the default. I think this approach
> is the most flexible.
>
> http://cr.openjdk.java.net/~michaelm/7034570/webrev.4/
>

The comment is not correct:
  288     // Only for use by Runtime.exec(...String[]envp...)
  289     static Map<String,String> emptyEnvironment(int capacity) {

It should be:
  288     // Only for use by ProcessBuilder.environment(String[] envp)

-Ulf




More information about the core-libs-dev mailing list