Review (Updated) : 4884238 : Constants for Standard Charsets

David Schlosnagle schlosna at gmail.com
Mon Apr 18 23:13:10 UTC 2011


On Mon, Apr 18, 2011 at 6:24 PM, Mike Duigou <mike.duigou at oracle.com> wrote:
> The latest webrev : http://cr.openjdk.java.net/~mduigou/4884238/2/webrev/
>
> Any other remaining feeback?
>

Mike,

You'll need to update the private constructor and AssertionError for
StandardCharset as the existing private Charset() won't compile:

  35 public final class StandardCharset {
  36
  37     private Charsets() {
  38         throw new AssertionError("No java.nio.charset.Charsets
instances for you!");
  39     }

- Dave



More information about the core-libs-dev mailing list