advice & review requested for 6896297, race condition in rmid causing JCK failure

[Peter Jones]

Hi Stuart,

On Apr 19, 2011, at 6:35 PM, Stuart Marks wrote:
> Please review an updated webrev for this bug:
> 
> http://cr.openjdk.java.net/~smarks/reviews/6896297/webrev.1/
> 
> Using ConcurrentHashMap is much nicer in many ways, and it seems to resolve the JCK failures at least as well as the previous fix did.

These changes look good to me.

> This does nothing to remedy the issue of snapshot consistency, which seems to be covered by 4945726, which we'll postpone (again) to a future release.

> On 4/14/11 4:01 PM, Stuart Marks wrote:
>> 
>> The larger issue of snapshot consistency is indeed troubling. I'd agree that
>> the ConcurrentModificationException is a symptom of a larger problem and that
>> making it go away (either with a different locking strategy or using CHM) is
>> mostly merely suppressing the symptom without addressing the larger issue. The
>> immediate need, though, is to fix the JCK failure, so I suspect what I'll need
>> to do is to push a fix for the CME and handle the resolution of any larger
>> issue separately.

Understood, makes sense.

Cheers,

-- Peter