7073296: Review : Bug in Executable.equalParamTypes() results in incorrect comparison for differing number of params

joe.darcy at oracle.com joe.darcy at oracle.com
Tue Aug 2 22:27:40 UTC 2011


Hi Mike.

Thanks for developing the fix for this.  Generally looks good to go 
back; a few minor nits.  Personally, I would leave the "// Doesn't use 
Boolean.getBoolean to avoid class init." note in java.lang.Class unless 
you know the comment is not relevant any more.  Given the default 
semantics of jtreg, you could omit the @compile and @run lines in the test.

Cheers,

-Joe

On 8/2/2011 12:44 PM, Mike Duigou wrote:
> Hello All;
>
> A fairly simple bug to review which snuck through testing.
>
> http://cr.openjdk.java.net/~mduigou/7073296/0/webrev/
>
> The changes to Class are incidental but so trivial that opted to include them. I can remove if anyone feels strongly (or even weakly) that they should be excluded.
>
> Mike



More information about the core-libs-dev mailing list