7073296: Review : Bug in Executable.equalParamTypes() results in incorrect comparison for differing number of params

joe.darcy at oracle.com joe.darcy at oracle.com
Tue Aug 2 22:53:03 UTC 2011


On 8/2/2011 3:32 PM, Mike Duigou wrote:
> On Aug 2 2011, at 15:27 , joe.darcy at oracle.com wrote:
>
>   
>> Hi Mike.
>>
>> Thanks for developing the fix for this.  Generally looks good to go back; a few minor nits.  Personally, I would leave the "// Doesn't use Boolean.getBoolean to avoid class init." note in java.lang.Class unless you know the comment is not relevant any more.
>>     
>
> I actually added the note. I checked with java -verbose:class on the load order and Class is loaded quite a bit before Boolean. It's a note to future maintainers who, like I was, are tempted to convert to Boolean.getBoolean().
>   

Read the patch wrong; doh! 

-Joe





More information about the core-libs-dev mailing list