Request for review: #include ANSI headers for functions referred to in jli_util.h

Neil Richards neil.richards at ngmr.net
Wed Aug 3 14:32:09 UTC 2011


Hi,
I've noticed that jdk/src/share/bin/jli_util.h does not currently
include the ANSI headers for the functions that it #defines aliases for,
which is not good practice.

Please find below a suggested change which adds the necessary #include
statements to correct this.

Please consider this change for committal.

Thanks,
Neil

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU


# HG changeset patch
# User Neil Richards <neil.richards at ngmr.net>, <neil_richards at uk.ibm.com>
# Date 1311681383 -3600
# Branch ojdk-145
# Node ID 395dc4307fa501bf0d18afc87928247bd80c9d78
# Parent  07a12583d4ea8d9d9de865aa9ab7dea2ca6b043e
Summary: Include ANSI headers for functions referred to in jli_util.h
Contributed-by: <neil.richards at ngmr.net>

diff -r 07a12583d4ea -r 395dc4307fa5 src/share/bin/jli_util.h
--- a/src/share/bin/jli_util.h	Mon Jul 25 14:35:13 2011 -0700
+++ b/src/share/bin/jli_util.h	Tue Jul 26 12:56:23 2011 +0100
@@ -27,6 +27,8 @@
 #define _JLI_UTIL_H
 
 #include <stdlib.h>
+#include <string.h>
+#include <stdio.h>
 #include <jni.h>
 
 void *JLI_MemAlloc(size_t size);
@@ -58,6 +60,7 @@
 #define JLI_Snprintf                    _snprintf
 #else
 #include <unistd.h>
+#include <strings.h>
 #define JLI_StrCaseCmp(p1, p2)          strcasecmp((p1), (p2))
 #define JLI_StrNCaseCmp(p1, p2, p3)     strncasecmp((p1), (p2), (p3))
 #define JLI_Snprintf                    snprintf





More information about the core-libs-dev mailing list