JDK 8 code review request for 7075098: Remove unused fdlibm files
Alan Bateman
Alan.Bateman at oracle.com
Thu Aug 4 19:34:00 UTC 2011
Joe Darcy wrote:
> Hello.
>
> Please review these straightforward changes for
>
> 7075098: Remove unused fdlibm files
> http://cr.openjdk.java.net/~darcy/7075098.0/
>
> The JDK math libraries in java.lang.{Math, StrictMath} do not expose
> all the functionality implemented in the embedded copy of FDLIBM
> (freely distributable math library). Since we do not plan do expose
> the remaining functionality (erf, gamma, lgama, j0, j1, jn, acosh,
> asinh, etc.) and these functions are not needed by the Java core libs
> directly or by transitivity, this changeset removes the unneeded files
> from the build.
>
> On my Linux build, with this change the size of the compiled fdlibm
> library file went down from 234,372 to 165,750 and all the math
> library regression tests pass.
>
> Thanks,
>
> -Joe
This looks good to me. I assume you've checked that it builds on other
platforms too.
-Alan.
More information about the core-libs-dev
mailing list