Code review request: 7077672 jdk8_tl nightly fail in step-2 build on 8/10/11

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Aug 11 20:55:10 UTC 2011


Rémi, you wrote:

> On 08/11/2011 09:07 PM, Alexandre Boulgakov wrote:
> >/  Please review the attached patch to fix a build break.
> />/
> />/  The fix changes new Class<>[] to new Class<?>[] in two places.
> />/
> />/  Thanks,
> />/  Sasha
> /
> Hi Sasha,
> you can rewrite:
>
>     connectMethod = corbaStubClass.getMethod("connect",
>                   new Class<>[] {org.omg.CORBA.ORB.class});
>
> to
>
>     connectMethod = corbaStubClass.getMethod("connect",
>                   org.omg.CORBA.ORB.class);
>
> because getMethod is a varargs.
>
> Anyways, the changes are ok for me without that.
>
> Rémi

Thanks for the suggestion.  In this case we wanted a minimal fix to go 
back as safely and as quickly as possible.  But your suggestion leads to 
another, broader suggestion for a cleanup of places where the array 
declaration is no longer required.  Another one for the list!

-- Jon





More information about the core-libs-dev mailing list