JDK 8 code review request for 4850225: Integer.getInteger() : Bad reference to getProperty?

Joe Darcy joe.darcy at oracle.com
Mon Aug 15 19:51:57 UTC 2011


Hi Sasha.

In the JDK javadoc, I don't think we are that consistent on one or two 
spaces between sentences so the change below is fine.

Thanks for checking,

-Joe

Alexandre Boulgakov wrote:
> In Integer.java, lines 779-780, there are multiple spaces between the 
> sentences:
> 779 * <p>The first argument is treated as the name of a system
> 780 * property.  System properties are accessible through the {@link
>
> -Sasha
>
> On 8/15/2011 12:33 PM, Joe Darcy wrote:
>> Hi Sasha.
>>
>> What is an example of what you're referring to?  In the sdiff of the 
>> changes, the paragraph breaks are roughly the same.  (I did reformat 
>> some paragraphs for line breaks, etc.)
>>
>> -Joe
>>
>> Alexandre Boulgakov wrote:
>>> Hello Joe,
>>>
>>> It looks like you have added multiple spaces between some sentences. 
>>> Is this intentional?
>>>
>>> Cheers,
>>> Sasha
>>>
>>> On 8/15/2011 12:17 PM, Joe Darcy wrote:
>>>> Hello.
>>>>
>>>> More bug cleanup, please review this small change to correct a 
>>>> misstatement in the javadoc of Integer and Long about getProperty; 
>>>> along the way, some more uses of multi-catch are added:
>>>>
>>>>    4850225: Integer.getInteger() : Bad reference to getProperty?
>>>>    http://cr.openjdk.java.net/~darcy/4850225.0/
>>>>
>>>> Thanks,
>>>>
>>>> -Joe
>>




More information about the core-libs-dev mailing list