Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

[Sebastian Sickelmann]

Am 16.08.2011 13:35, schrieb Alan Bateman:
> Sebastian Sickelmann wrote:
>> Hi,
>>
>> some time ago, i wrote[5] with Joe and David about advancing some 
>> exception-types to the 4 standard ctors.
>>
>> The first Exception i have looked at was InternalError and now(after 
>> some struggeling with gnumake and hg) my patches for reviewing are 
>> ready.
>>
>> I uploaded them at [4]
>>
>> I split the changes into 3 parts.
>>
>> 1. Added 2 ctors to InternalError and VirtualMachineError****[1]
>> 2. Use the two ctors of InternalError****[2] (based on [1])
>> 3. Chain Rootcause into InternalError**[3] (based also on [1])
>>
>> I think part 1 and 2 are uncritical. Part 3 is more critical because 
>> it changes behavior (exception-chaining). But i don't think that part 
>> 3 is unimportable, because in case of an InternalError (use should 
>> not be able to recover) there shouldn't be a problem with a little 
>> longer exception-chain.
>>
>> Is there someone who what to sponsor this or parts of it?
> I don't have cycles but I can generate a webrev (essentially browsable 
> diffs) for you that would make this easy to review. Do you mind 
> re-basing your patches so that they can be applied to jdk8/tl/jdk? I 
> think Sasha got in before you and has already changesd several places 
> to use multi-catch that are in your patches too.
>
> -Alan.
It would be great to have a webrev for them.
I rebased my patches on dd218ad64d5c of 
http://hg.openjdk.java.net/jdk8/tl/jdk/

The patches are here:
https://bugs.openjdk.java.net/attachment.cgi?id=236 (diff view: 
https://bugs.openjdk.java.net/attachment.cgi?id=236&action=diff)
https://bugs.openjdk.java.net/attachment.cgi?id=237 (diff view: 
https://bugs.openjdk.java.net/attachment.cgi?id=237&action=diff)
https://bugs.openjdk.java.net/attachment.cgi?id=238 (diff view: 
https://bugs.openjdk.java.net/attachment.cgi?id=238&action=diff)

Is there a way to create webrev on my linux box (ubuntu)? Is there a 
good description for it?

I have another(RuntimeException) patch here:
https://bugs.openjdk.java.net/attachment.cgi?id=239 (diff view: 
https://bugs.openjdk.java.net/attachment.cgi?id=239&action=diff)
Maybe i can create a webrev on my own for this.

-- Sebastian