Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

Sebastian Sickelmann sebastian.sickelmann at gmx.de
Wed Aug 17 14:43:10 UTC 2011


Am 17.08.2011 13:45, schrieb Alan Bateman:
> joe.darcy at oracle.com wrote:
>>
>> I am willing to sponsor this work and I've filed bug 7080020 "Add 
>> conventional constructors to InternalError" for it.
>>
> Thanks Joe, and to help this along here's the webrev with Sebastian's 
> patches:
>   http://cr.openjdk.java.net/~alanb/7080020/webrev/
>
> I haven't really looked but one thing I did notice is that the 
> multi-catch usages need to be checked as Sasha cleaned up a few of 
> these recently.
>
> -Alan.
Thanks for the webrev.

I think it is very hard to start with the complete patch. Or is it 
better to review it all at once?

I have created a webrev for my patches 0 and 1 and uploaded it here:
http://oss-patches.24.eu/openjdk8/InternalError/part1/

After i have pulled from tl/jdk i got problems with building.
I got warnings so that i must build with JAVAC_WARNINGS_FATAL=false, is 
this ok for tl-repo?

-- Sebastian



More information about the core-libs-dev mailing list