Request for review 6237353: Remove sun.io package from j2se binary
Xueming Shen
xueming.shen at oracle.com
Wed Aug 17 22:23:23 UTC 2011
Those charsets at sun.awt.motif are using some of them.
-Sherman
On 8/17/2011 3:08 PM, Ulf Zibis wrote:
> Sherman,
>
> thanks.
> There are some more public sun.io-bridge-methods which could be saved
> or at least made package-private, e.g.:
> - EUC_TW.Encoder.toEUC()
> - EUC_TW.Decoder.toUnicode()
> - DoubleByte.Encoder.encodeChar()
> - DoubleByte.Decoder.decodeSingle()
> - DoubleByte.Decoder.decodeDouble()
> - DoubleByteEncoder.encodeSingle()
> - DoubleByteEncoder.encodeDouble()
> - etc.
>
> I think, all sun.nio.cs charsets have been made public for the sun.io
> access. Why don't make them package-private? Nobody from outside
> should access them directly.
>
>
> Am 17.08.2011 20:41, schrieb Xueming Shen:
>> Ulf,
>>
>> I tried to be conservative to not touch the source code, just in case
>> I might be forced
>> to put them back again:-)
> Then we could provide my small sun.io-wrapper, maybe as additional
> resource like JDK DST Timezone Update Tool. ;-)
>
> -Ulf
>
>
>> But since I have already removed the whole sun.io source
>> branch, it's reasonable to do the complete cleanup up as well. The
>> webrev has been
>> updated accordingly (to remove those comments and methods)
>>
>> http://cr.openjdk.java.net/~sherman/6237353/webrev
>> <http://cr.openjdk.java.net/%7Esherman/6237353/webrev/>
>>
>> Thanks!
>>
>> -Sherman
>>
More information about the core-libs-dev
mailing list