Request Review for small change to remove 2 warnings in rmic
Mandy Chung
mandy.chung at oracle.com
Wed Aug 17 22:52:25 UTC 2011
Thumbs up from me. Are you going to include this change with another
CR that you have a fix to be pushed?
Mandy
On 8/17/11 3:45 PM, Sebastian Sickelmann wrote:
> Hi while searching if i created warnings with an change i have seen
> that there are 2 warnings in rmic that are easy to remove.
>
> Please review this hg export (no webrev unfortunately, because my
> free-file-host-provider is out of service :-( )
>
> # HG changeset patch
> # User Sebastian
> # Date 1313620914 -7200
> # Node ID 1dd60cdcf67183afd12323258307f2d78bdd3979
> # Parent 07ad163881707c67a0365090ff2192878d266542
> Removed some compile-warnings in rmic
>
> diff -r 07ad16388170 -r 1dd60cdcf671
> src/share/classes/sun/rmi/rmic/Main.java
> --- a/src/share/classes/sun/rmi/rmic/Main.java Wed Aug 17 14:18:30
> 2011 -0700
> +++ b/src/share/classes/sun/rmi/rmic/Main.java Thu Aug 18 00:41:54
> 2011 +0200
> @@ -879,6 +879,6 @@
> args[1] = (arg1 != null ? arg1.toString() : "null");
> args[2] = (arg2 != null ? arg2.toString() : "null");
>
> - return java.text.MessageFormat.format(format, args);
> + return java.text.MessageFormat.format(format, (Object[]) args);
> }
> }
> diff -r 07ad16388170 -r 1dd60cdcf671
> src/share/classes/sun/rmi/rmic/newrmic/Resources.java
> --- a/src/share/classes/sun/rmi/rmic/newrmic/Resources.java Wed Aug
> 17 14:18:30 2011 -0700
> +++ b/src/share/classes/sun/rmi/rmic/newrmic/Resources.java Thu Aug
> 18 00:41:54 2011 +0200
> @@ -69,7 +69,7 @@
> format = "missing resource key: key = \"" + key + "\", " +
> "arguments = \"{0}\", \"{1}\", \"{2}\"";
> }
> - return MessageFormat.format(format, args);
> + return MessageFormat.format(format, (Object[]) args);
> }
>
> /**
More information about the core-libs-dev
mailing list