Request Review for small change to remove 2 warnings in rmic

[Sebastian Sickelmann]

Am 18.08.2011 06:46, schrieb Sebastian Sickelmann:
> Am 18.08.2011 00:52, schrieb Mandy Chung:
>> Thumbs up from me.   Are you going to include this change with 
>> another CR that you have a fix to be pushed?
>>
> I have some other improved that are reviewed by Joe actually. But 
> there are on a completly other topic and it
> should take some days to have all prepared for the push.
>
> Is the CR to small, or what is the reason for your question?
>
> I think i can fix 2 other warnings of the same kind and fix them 
> together.
> src/solaris/classes/sun/awt/X11/XIconWindow.java:95: warning: 
> non-varargs call of varargs method with inexact argument type for last 
> parameter;
> src/share/classes/sun/tools/serialver/SerialVer.java:462: warning: 
> non-varargs call of varargs method with inexact argument type for last 
> parameter;
>
> I send in a combined webrev in shortly.
>> Mandy
>>
>> On 8/17/11 3:45 PM, Sebastian Sickelmann wrote:
>>> Hi while searching if i created warnings with an change i have seen 
>>> that there are 2 warnings in rmic that are easy to remove.
>>>
>>> Please review this hg export (no webrev unfortunately, because my 
>>> free-file-host-provider is out of service :-( )
>>>
>>> # HG changeset patch
>>> # User Sebastian
>>> # Date 1313620914 -7200
>>> # Node ID 1dd60cdcf67183afd12323258307f2d78bdd3979
>>> # Parent  07ad163881707c67a0365090ff2192878d266542
>>> Removed some compile-warnings in rmic
>>>
>>> diff -r 07ad16388170 -r 1dd60cdcf671 
>>> src/share/classes/sun/rmi/rmic/Main.java
>>> --- a/src/share/classes/sun/rmi/rmic/Main.java    Wed Aug 17 
>>> 14:18:30 2011 -0700
>>> +++ b/src/share/classes/sun/rmi/rmic/Main.java    Thu Aug 18 
>>> 00:41:54 2011 +0200
>>> @@ -879,6 +879,6 @@
>>>          args[1] = (arg1 != null ? arg1.toString() : "null");
>>>          args[2] = (arg2 != null ? arg2.toString() : "null");
>>>
>>> -        return java.text.MessageFormat.format(format, args);
>>> +        return java.text.MessageFormat.format(format, (Object[]) 
>>> args);
>>>      }
>>>  }
>>> diff -r 07ad16388170 -r 1dd60cdcf671 
>>> src/share/classes/sun/rmi/rmic/newrmic/Resources.java
>>> --- a/src/share/classes/sun/rmi/rmic/newrmic/Resources.java    Wed 
>>> Aug 17 14:18:30 2011 -0700
>>> +++ b/src/share/classes/sun/rmi/rmic/newrmic/Resources.java    Thu 
>>> Aug 18 00:41:54 2011 +0200
>>> @@ -69,7 +69,7 @@
>>>              format = "missing resource key: key = \"" + key + "\", " +
>>>                  "arguments = \"{0}\", \"{1}\", \"{2}\"";
>>>          }
>>> -        return MessageFormat.format(format, args);
>>> +        return MessageFormat.format(format, (Object[]) args);
>>>      }
>>>
>>>      /**
>>
>
My filehoster is working again.
Here is the combined webrev:

http://oss-patches.24.eu/openjdk8/Varargs_Warning/

-- Sebastian