Request for Review: Chain more Exceptions (RuntimeException)

[Mike Duigou]

I will echo Joe's comments about putting the "|" at the end of the line rather than at the beginning of the next line.

Not a comment on your patch but some of the use of raw RuntimeException is rather weak. I saw a few cases where IllegalStateException or UnsupportedOperationException would be a better choice

src/share/classes/javax/swing/text/html/HTMLEditorKit.java:

- I don't think the "+ e" is necessary.

src/share/classes/java/awt/dnd/DragSource.java:

- I don;t think the "+ e.getMessage()" is necessary.

src/share/classes/java/beans/Encoder.java:

- Same for " + exp.toString()"

src/share/classes/sun/security/provider/certpath/URICertStore.java:
src/share/classes/sun/security/ssl/CipherBox.java:
src/share/classes/com/sun/org/apache/xml/internal/security/utils/SignerOutputStream.java:
(and perhaps elsewhere)

- You might want to use (e.getMessage(), e) variant rather than just the (Throwable) constructor if previously the message was initialized.

src/share/classes/javax/xml/crypto/NoSuchMechanismException.java:

- @since 1.8 seems incorrect.

Very good cleanup on the rest!

Great work!

Mike

On Aug 17 2011, at 22:01 , Sebastian Sickelmann wrote:

> Hi,
> 
> i have created a fix for fixing Exception-Chains in case of an rethrown RuntimeException.
> 
> I am not quite sure if this is inside the scope of what i discussed[0][1] with Joe. But it is
> fixed in the same manner as the patches there.
> 
> http://oss-patches.24.eu/openjdk8/RuntimeException/REBASED_ON_07ad16388170/
> 
> Someone who wants to review / sponsor this?
> 
> 
> -- Sebastian
> 
> [0] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-August/007304.html
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-August/007399.html
> 
>