hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError
Joe Darcy
joe.darcy at oracle.com
Wed Aug 24 15:11:03 UTC 2011
Hi Alan.
I did check for that point in my review :-)
The VirtualMachineError class is abstract so as long as all its
subclasses declare a serialVersionUID, like InternalError does, I think
we're fine.
Thanks,
-Joe
Alan Bateman wrote:
>
> Joe, Sebastian - just noticed this now but VirtualMachineError doesn't
> specify a serialVersionUID so these new constructors will change the
> default value.
>
> joe.darcy at oracle.com wrote:
>> Changeset: c43af666d130
>> Author: darcy
>> Date: 2011-08-22 12:16 -0700
>> URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c43af666d130
>>
>> 7080020: Add conventional constructors to InternalError and
>> VirtualMachineError
>> Reviewed-by: darcy
>> Contributed-by: nsebastian.sickelmann at gmx.de
>>
>> ! src/share/classes/com/sun/servicetag/SunConnection.java
>> ! src/share/classes/java/lang/InternalError.java
>> ! src/share/classes/java/lang/VirtualMachineError.java
>> ! src/share/classes/java/util/prefs/Preferences.java
>> ! src/share/classes/sun/font/FontManagerFactory.java
>> ! src/share/classes/sun/misc/URLClassPath.java
>> ! src/share/classes/sun/reflect/MethodAccessorGenerator.java
>> ! src/share/classes/sun/security/x509/X500Name.java
>> ! src/share/classes/sun/tools/jconsole/ProxyClient.java
>> ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java
>>
>
>
>
More information about the core-libs-dev
mailing list