Request for review: More cause-chaining for InternalError

Sebastian Sickelmann sebastian.sickelmann at gmx.de
Sun Aug 28 08:18:34 UTC 2011


Am 28.08.2011 06:22, schrieb Dr Andrew John Hughes:
> On 14:16 Tue 23 Aug     , Sebastian Sickelmann wrote:
>>
>> I have rebased my "additional chainings of InternalError" on your commit.
>>
>> The webrev is:
>> http://oss-patches.24.eu/openjdk8/InternalError/part2/REBASED_ON_c43af666d130/
>>
>> Reviews are welcome for this too.
>>
> This looks fine to me; mostly trivial stuff.
Yes. It's more a assiduity work*, then real complex.
The only non trival stuff maybe 
***src/share/classes/java/text/DecimalFormat.java* 
<http://dict.leo.org/ende?lp=ende&p=Ci4HO3kMAA&search=assiduity&trestr=0x8001> 
[0]
in combination with src/share/classes/java/text/Format.java [1]

Is there someone who whats to sponsor this by creating a CR and pushing 
it? Or are there more reviewers needed?

How is such cleanup-work handled? I can make more assiduity work on 
this, but is it worth it? Are there drawbacks, additional to my 
mailing-list spam, by such cleanups? Chaining more aggresivly maybe 
cause CG to do later cleanup and serialized Exceptions can be more 
expensive while serializing and transfering over wire(remote-calls etc.).

-- Sebastian

*
>> - Sebastian



More information about the core-libs-dev mailing list