Request for Review of 7116890 (Warning Cleanup java.io)
Alan Bateman
Alan.Bateman at oracle.com
Thu Dec 1 17:15:11 UTC 2011
On 01/12/2011 16:27, Sebastian Sickelmann wrote:
> :
> Thanks for the good feedback.
>
> I splitted my change to the trivial part and will start discussion of
> FilePermission change on core-libs-dev after the cleanup event.
> I created a new webrev with the suggested changes here[2]
>
> [2]
> http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/Warning_Cleanup_Java_io/CR7116890_0/index.html
>
> -- Sebastian
In ExpiringCache L67-68 it looks like you are missing the type
parameters. Also I assume we can change L119-120 to be for(String key:
keySet) { ... } (I realize this is not strictly a warnings change).
Otherwise I think it's okay.
-Alan.
More information about the core-libs-dev
mailing list