7116445: Miscellaneous warnings in the JDBC/RowSet classes

[Lance Andersen - Oracle]

Sadly,  once i start digging, i found more changes :-(

Here are the latest revisions with the additions/changes since the last review, http://cr.openjdk.java.net/~lancea/7116445/webrev.03:

The modified files since the last diff:  

src/share/classes/com/sun/rowset:

CachedRowSetImpl.java	
JdbcRowSetResourceBundle.java
FilteredRowSetImpl.java	
JoinRowSetImpl.java	
WebRowSetImpl.java

src/share/classes/com/sun/rowset:

CachedRowSetWriter.java
WebRowSetXmlWriter.java
XmlReaderContentHandler.java
SyncResolverImpl.java

src/javax/sql/rowset/spi:

RowSetMetaDataImpl.java	
RowSetProvider.java
SQLInputImpl.java ----
SQLOutputImpl.java

src/javax/sql/rowset/:

StatementEvent.java
BaseRowSet.java


src/javax/sql/rowset/spi:

SyncFactory.java



Best,
Lance





On Dec 1, 2011, at 4:28 PM, Stuart Marks wrote:

> On 12/1/11 1:21 PM, Lance Andersen - Oracle wrote:
>> I will make the couple changes above for the unboxing and generate 1 last
>> webrev and then push it once I get the final green light...
> 
> Leaving in the breaks and the arraycopy is probably the right thing to do.
> 
> I don't think you need to generate another webrev just for the unboxing changes. Or, if you do, don't wait for me to review it, just go ahead and push... I have enough other reviews to take care of today.
> 
> Thanks again.
> 
> s'marks


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com