7116957: javax.script.ScriptEngineManager should use java.util.ServiceLoader to lookup service providers

Chris Hegarty chris.hegarty at oracle.com
Fri Dec 2 11:30:42 UTC 2011


Alan,

Would you mind taking a quick look at the updated webrev?

Trivially, I fixed a few style issues in HttpServerProvider (a nit of 
mine) and updated the commented code in FtpClientProvider (in case it 
ever gets enabled ). Let's remove any possibility of sun.misc.Service 
every reappearing ;-)

http://cr.openjdk.java.net/~chegar/7116957/webrev.01/webrev/

-Chris.

On 01/12/2011 15:41, Alan Bateman wrote:
> On 01/12/2011 15:07, Chris Hegarty wrote:
>> This is a follow up to an issue that came up during discussion of
>> another fix. Essentially, ScriptEngineManager should use
>> j.u.ServiceLoader rather than sun.misc.Service.
>>
>> http://cr.openjdk.java.net/~chegar/7116957/webrev.00/webrev/
>>
>> -Chris.
>>
>> P.S. and fix up imports in HttpServerProvider
> Looks fine to me.



More information about the core-libs-dev mailing list