Request for Review: 7116914 (Miscellaneous warnings (sun.text))
Mike Duigou
mike.duigou at oracle.com
Fri Dec 2 20:25:26 UTC 2011
Looks good.
In NormalizerImpl.java:
- The parens are probably not needed around 'length=(srcIndex-prevSrc);'
UnicodeSet.java:
- I confirmed, just to be sure, that the added 'break;' statements have no effect.
On Dec 1 2011, at 23:51 , Yuka Kamiya wrote:
> Hello,
>
> Could someone please review this fix?
>
> http://cr.openjdk.java.net/~peytoia/7116914/webrev.00/
>
> Some warnings are still issued even after this fix, and that's intentional.
> I'd like to solve them in another way rather than using @SuppressWarnings("deprecation") in the future.
>
> The original number of warnings in this area was 70. Now 16.
>
> Thanks,
> --
> Yuka Kamiya
More information about the core-libs-dev
mailing list