Review Request for 7116997 (warning cleanup java.util.PropertyPermission)

[Brandon Passanisi]

Thanks for the review Stuart.  Here is a another webrev for review 
containing your suggested change:

    http://cr.openjdk.java.net/~dmocek/bpassanisi/7116997/webrev.01/
    <http://cr.openjdk.java.net/%7Edmocek/bpassanisi/7116997/webrev.01/>


On 12/1/2011 4:06 PM, Stuart Marks wrote:
>
> On 12/1/11 1:18 PM, Brandon Passanisi wrote:
>> I have a webrev pertaining to the warning cleanup changes for
>> java.util.PropertyPermission ready for review. Here's the info:
>>
>> Bug: 7116997
>> Webrev:
>> http://cr.openjdk.java.net/~dmocek/bpassanisi/7116997/webrev.00/
>> <http://cr.openjdk.java.net/%7Edmocek/bpassanisi/7116997/webrev.00/>
>
> Hi Brandon,
>
> Can you take out the @SuppressWarnings from the getMask() method, and 
> change the /*FALLTHROUGH*/ comment at line 309 to "break" instead? I 
> think this is equivalent code, and it will get rid of the warning 
> message without having to suppress warnings.
>
> thanks.
>
> s'marks

-- 
Oracle <http://www.oracle.com>
Brandon Passanisi | Principle Member of Technical Staff

Oracle Java Standards Conformance

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment