review of 7117249: java.util warnings patches from LJC/Mike Barker

[Alan Bateman]

On 03/12/2011 20:59, Stuart Marks wrote:
> [bcc to jdk8-dev; subsequent reviews/comments should go to core-libs-dev]
>
> Hi Mike, all,
>
> I've collected all the patches together, filed bug 7117249 to cover 
> them, and have started this new review thread on core-libs-dev for it. 
> I've also posted a webrev for the collected patches:
>
> http://cr.openjdk.java.net/~smarks/reviews/7117249/webrev.0/
>
> It looks like we have the following patches from your group so far:
>
>  - java/util/jar/JarFile.java
>  - java/util/jar/Manifest.java [patch4]
>  - java/util/logging/LogManager.java [patch2]
>  - java/util/prefs/Preferences.java
>  - java/util/prefs/XmlSupport.java
>  - java/util/zip/ZipEntry.java [patch2]
>
> Did I get everything? I think you've addressed all the review comments 
> that have come in so far. (Other reviewers, please recheck the webrev!)
Stuart - I don't know if you're looking for another reviewer but I did 
quick scan of the webrev. There are still a couple of raw type warnings 
in JarFile and several more in other classes in these packages so it's 
possible you don't have everything (I wasn't following that thread 
closely on jdk8-dev).

I'm not an expert on the logging API but I saw your comment asking about 
s/global/getGlobal()/ and that looks okay to me.

One odd thing is the comments added to the suppression of the 
deprecation warning in ZipEntry dosToJavaTime/javaToDosTime. That seems 
to be warning future maintainers not to change the implementation to use 
calendar whereas that seems like a comment for inside the methods. The 
comment on the @SuppressWarning could just method the Date methods being 
deprecated.

-Alan.