please review 7117612: warnings fixes in java.lang

[Alan Bateman]

On 05/12/2011 22:09, Omair Majid wrote:
>
> I have posted a new webrev:
> http://cr.openjdk.java.net/~omajid/webrevs/warnings-day-2011/03/
>
> This includes all the changes from the feedback so far, as well as 
> changes to ThreadLocal.
>
> I will not be posting a patch for ClassValue since (as you kindly 
> pointed out), others are making changes to it and removing some 
> warnings too [1]. I suppose I will revisit it later (if warning fixes 
> are still being accepted :D ).
I looked through the latest webrev. In 
EnumConstantNotPresentException.java then the 
@SuppressWarnings("rawtypes") should probably have a comment to explain 
why it is needed. In ThreadLocal.get then it's a pity that an additional 
local is needed to increase the size of the method. Otherwise the 
changes look okay to me.

-Alan.