Review request for 6927486: Deadlock in legacy Hashtable writeObject()

[Neil Richards]

On 5 January 2011 13:36, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> I don't see any issues with the changes to j.u.Hashtable. You might have
> seen Stuart Mark's changes go by recently where he changed some of the
> existing code (including java.util) to use diamond. You might want to use
> this in these changes to avoid needing to re-run the tools on this code.
> This would also fix a style issue where you've got a space between the type
> parameters in a few places.

Good idea - I've updated the changeset to use the diamond operation
where appropriate.

Based on a crude search, I currently see (in the 'tl/jdk' repository)
1242 instances where Generic parameters are declared without a space,
and 1911 instances where they are declared with a space.
(This is for parameters with "real" object types, rather than "<K,V>"
type parameters).
I guess this backs up Stuart's point, that there seems to be no
consistency on which form to use.

> In the tests you catch Exception (or IOException or ClassNotFoundException)
> and then re-throw a RuntimeException. You can probably remove this as jtreg
> will mark the test as failed if it completes with any exception.

Okay. I've updated the changeset to do this too, and attached this as
a webrev zip file (as per Dalibor's suggestion).

Please review this modified changeset, and let me know if anything
further is required for its acceptance.

>> The problem reported is similar to one found in java.util.Vector, for
>> which a fix is also currently under review
>>
>> (http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-December/005529.html).
>>
>
> You might want to give this one a nudge by re-sending with a GPL header on
> the test. As I recall it was just the test that needed to be reviewed.

I did post an update which added the appropriate headers here:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-December/005529.html

However, I've updated this again, based on the feedback given for this item:

http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-January/005612.html

Thanks for all your help with this,
Cheers,
Neil

--
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
A non-text attachment was scrubbed...
Name: webrev.6927486.1.zip
Type: application/zip
Size: 116102 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20110110/b701d71c/webrev.6927486.1.zip>