code review request for 7011095, revert diamond changes in method args

Joe Darcy joe.darcy at oracle.com
Tue Jan 11 03:27:31 UTC 2011


Hi Stuart.

Looks good; approved!

Thanks,

-Joe

Stuart Marks wrote:
> Hi all,
>
> This is a followup to the diamond conversion I did for 6880112, 
> reviewed here a few weeks ago [1].
>
> That conversion applied the diamond operator in variable initializers, 
> assignment statements, return statements, and in method arguments. For 
> stylistic reasons we've decided that using diamond in method args 
> isn't necessarily a good idea. The type inference for method args can 
> be quite subtle, and since the diamond operator is supposed to improve 
> brevity and clarity, using it in method args seems counterproductive.
>
> Given this, we've decided to pull out the usage of diamond from the 
> places that it was added by 6880112. Here's the webrev:
>
> http://cr.openjdk.java.net/~smarks/reviews/7011095/webrev.0/
>
> Thanks!
>
> s'marks
>
>
> [1] 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2010-December/005466.html 
>
>




More information about the core-libs-dev mailing list