From kelly.ohair at oracle.com Wed Jun 1 17:44:03 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 01 Jun 2011 17:44:03 +0000 Subject: hg: jdk7/tl/jaxws: 7049699: Problem with xml/jax-ws Message-ID: <20110601174403.EC7BA47AC8@hg.openjdk.java.net> Changeset: bcca8afc019f Author: ohair Date: 2011-06-01 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/bcca8afc019f 7049699: Problem with xml/jax-ws Reviewed-by: ramap ! jaxws.properties From jonathan.gibbons at oracle.com Wed Jun 1 18:27:46 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 01 Jun 2011 18:27:46 +0000 Subject: hg: jdk7/tl/langtools: 7042623: Regression: javac silently crash when attributing non-existent annotation Message-ID: <20110601182750.84FAF47AD1@hg.openjdk.java.net> Changeset: 6762754eb7c0 Author: jjg Date: 2011-06-01 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6762754eb7c0 7042623: Regression: javac silently crash when attributing non-existent annotation Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/T7042623.java + test/tools/javac/T7042623.out From daniel.daugherty at oracle.com Thu Jun 2 03:44:37 2011 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 02 Jun 2011 03:44:37 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110602034531.498AF47AED@hg.openjdk.java.net> Changeset: 0da0a4d22fba Author: dcubed Date: 2011-06-01 17:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0da0a4d22fba 7048308: 4/4 LoggingDeadlock3 test timeout is too small Summary: Change timeout for test from 15 seconds to 80 seconds. Reviewed-by: dholmes ! test/java/util/logging/LoggingDeadlock3.java Changeset: 4a221501079a Author: dcubed Date: 2011-06-01 17:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a221501079a 7045594: 4/4 fix for 6977677 introduced a ResourceBundle race Summary: Fix Logger.getLogger() ResourceBundle name race. Reviewed-by: dholmes, mchung ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/LoggerResourceBundleRace.java + test/java/util/logging/RacingThreadsTest.java From joe.darcy at oracle.com Thu Jun 2 06:56:48 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 02 Jun 2011 06:56:48 +0000 Subject: hg: jdk8/tl/langtools: 7025784: Add SourceVersion.RELEASE_8; ... Message-ID: <20110602065653.A193C47AF5@hg.openjdk.java.net> Changeset: defdd98cb7ce Author: darcy Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/defdd98cb7ce 7025784: Add SourceVersion.RELEASE_8 7025786: Add -source 8 and -target 8 to javac 7025789: Change javac source and target default to 8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/javax/lang/model/SourceVersion.java ! test/tools/javac/6330997/T6330997.java ! test/tools/javac/api/T6395981.java ! test/tools/javac/processing/warnings/TestSourceVersionWarnings.java ! test/tools/javac/quid/T6999438.java ! test/tools/javac/versions/check.sh From lance.andersen at oracle.com Thu Jun 2 16:03:03 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 02 Jun 2011 16:03:03 +0000 Subject: hg: jdk7/tl/jdk: 7049107: Cannot call initCause() on BatchUpdateException Message-ID: <20110602160345.151E547B0B@hg.openjdk.java.net> Changeset: a00f48c96345 Author: lancea Date: 2011-06-02 12:02 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345 7049107: Cannot call initCause() on BatchUpdateException Reviewed-by: darcy ! src/share/classes/java/sql/BatchUpdateException.java From xueming.shen at oracle.com Fri Jun 3 21:55:28 2011 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 03 Jun 2011 14:55:28 -0700 Subject: j.u.regex: Negated Character Classes Message-ID: <4DE95850.6040208@oracle.com> I'm sure everybody understands what "negated character classes" [^...] in j.u.regex means. You would never have doubt about [^c] does NOT match "c" [^0-9] does NOT match "8" [^a-z] does NOT match "b" [^a-bc-d] does NOT match 'c" But how about does [^[c]] match "c"? does [^[0-9]] match "8"? does [^[a-z]] match "b"? does [^a-b[c-d]] match "c"? I was wrong on all of them when was asked first time and it took me a while to figure out what is going on behind it. Oh, btw, the answer is "yes" for all 4, yes, the [^[c]] matches "c" [^[0-9]] matches "8" [^[a-z]] matches "b". [^a-b[c-d]] matches "c" (while [^a-bc-d] does NOT match "c") Another interesting sample is [^a-b[c-d]e-f] matches "c" but does NOT match "e" (so the "e-f" part after the nested character class [c-d] does back to "normal"). It appears the "negation" of the "outer" character class does not affect its nested character class, so [^X] is always opposite from [^[X]], "X" to be any character class. Same "strange" thing seems to be true for "intersection operation &&" as well, so both [a-d&&c-f] and [^a-d&&c-f] do NOT match "a". This does not sound correct, at least for me. The source code suggests that we are treating the nested/embedded [...] character class and the "intersection &&" specially, so [^[X] is interpreted as [^] union [X] [^X[Y]] is interpreted as [^X] union [Y] [^X[Y]Z] is interpreted as [^XZ] union [Y] [^X&&Y] is interpreted as [^X] && Y What I meant "treating...specially" is that we do NOT do the same thing for other "embedded character classes", so while [^[a-z]] does match "c", [^\p{Lower}] actually does NOT match "c", which I would expect. The j.u.regex.Pattern APIs do NOT help. All the samples given for "Character classes"[1] section are "simple" negation, no "nested" sample is given. And neither "^" nor "[^...]" appear in the operator precedence table. The behaviors in other regex engines, such as Perl and POSIX, don't help, as "nested" character class is not supported there. I did check with the original author who wrote this part of the code. It appears the current implementation is indeed what he intended to do back then, so this behavior is NOT an implementation bug but by design. Personally I don't feel this design is not correct. Ideally, I would assume the spec either specifies [^...] as a separate "group operator" to be the "complement" of [...], or "^" as the "negation operator" with the lowest precedence, such as (from lowest to highest) (1) Negation ^ (only at the beginning of the [...]) (2) Intersection && (3) Range - (4) nested class [] So [^X[Y]] would be the "complement" of [X[Y]] [^X[Y]Z] would be the "complement" of [X[Y]Z] [^X&&Y] would be the "complement" of [X&&Y] for example, if I dump the regex internal logic node tree for the sample regex [^a-b[c-d]e-f], the jdk7 and jdk8 results would look like /home/sherman/TL/regex$ /export/sherman/Workspace/jdk7/jdk/build/linux-i586/bin/java RegEx -flag "1000" "[^a-b[c-d]e-f]" "c" Pattern=<[^a-b[c-d]e-f]> Input = 1: (7) 2: (0) 3: (0) 4: (0) 5: (0) 6: (0) 7: (0) ------------------------------- match:true groupCount=0 /home/sherman/TL/regex$ /export/sherman/Workspace/jdk8/jdk/build/linux-i586/bin/java RegEx -flag "1000" "[^a-b[c-d]e-f]" "c" Pattern=<[^a-b[c-d]e-f]> Input = 1: (7) 2: (0) 3: (0) 4: (0) 5: (0) 6: (0) 7: (0) ------------------------------- match:false I know, most of people might not be interested, but if you have read this far, means you are interested:-) and might have some opinions. It is definitely an incompatible change, given this has been the behavior from the very beginning of Java regex and has been there for almost a decade, I would appreciate any comment/opinion, especially if you agree that the existing behavior is NOT "correct" and therefor we need to fix, OR you think the existing one is just fine (the fact I only heard one complain the past 5 -6 years:-) so far), OR even the existing behavior is not "ideal", but given the compatibility concern, we might just leave it alone. The fix/change itself is relatively easy, as showed at http://cr.openjdk.java.net/~sherman/pattern_cc/ Thanks -Sherman [1] http://download.java.net/jdk7/docs/api/java/util/regex/Pattern.html#cc From lana.steuck at oracle.com Sat Jun 4 04:50:26 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:50:26 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20110604045026.DD14A47B87@hg.openjdk.java.net> Changeset: 4373d87e6f37 Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/4373d87e6f37 Added tag jdk7-b144 for changeset 7203965666a4 ! .hgtags Changeset: 55e9ebf03218 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/55e9ebf03218 Merge From lana.steuck at oracle.com Sat Jun 4 04:50:31 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:50:31 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20110604045031.B05D047B88@hg.openjdk.java.net> Changeset: bee49f47043f Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bee49f47043f Added tag jdk7-b144 for changeset 39bf6dcaab23 ! .hgtags Changeset: 10ca7570f47f Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/10ca7570f47f Merge From lana.steuck at oracle.com Sat Jun 4 04:50:25 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:50:25 +0000 Subject: hg: jdk7/tl/corba: 3 new changesets Message-ID: <20110604045032.D2E3747B89@hg.openjdk.java.net> Changeset: 7033a5756ad5 Author: katleman Date: 2011-05-25 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/7033a5756ad5 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! src/share/classes/com/sun/corba/se/impl/transport/CorbaTransportManagerImpl.java Changeset: 74eb715474f2 Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/74eb715474f2 Added tag jdk7-b144 for changeset 7033a5756ad5 ! .hgtags Changeset: 77ec0541aa2a Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/77ec0541aa2a Merge From lana.steuck at oracle.com Sat Jun 4 04:50:36 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:50:36 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20110604045036.36B9C47B8A@hg.openjdk.java.net> Changeset: 6158298d2b94 Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/6158298d2b94 Added tag jdk7-b144 for changeset 6bd683f2d527 ! .hgtags Changeset: 42bfba80beb7 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/42bfba80beb7 Merge From lana.steuck at oracle.com Sat Jun 4 04:50:43 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:50:43 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20110604045052.325F747B8B@hg.openjdk.java.net> Changeset: 8eb952f43b11 Author: katleman Date: 2011-05-25 13:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8eb952f43b11 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! src/share/classes/com/sun/source/tree/UnionTypeTree.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! test/tools/javac/4241573/T4241573.java ! test/tools/javac/6508981/TestInferBinaryName.java ! test/tools/javac/TryWithResources/DuplicateResource.java ! test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/T6838467.java ! test/tools/javac/api/T6877206.java ! test/tools/javac/api/TestClientCodeWrapper.java ! test/tools/javac/api/TestJavacTask_Lock.java ! test/tools/javac/api/TestJavacTask_Multiple.java ! test/tools/javac/api/TestJavacTask_ParseAttrGen.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/tree/T6963934.java Changeset: 9f25c6a3ac23 Author: schien Date: 2011-05-26 20:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9f25c6a3ac23 Added tag jdk7-b144 for changeset 8eb952f43b11 ! .hgtags Changeset: c455e2ae5c93 Author: lana Date: 2011-06-02 13:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c455e2ae5c93 Merge From lana.steuck at oracle.com Sat Jun 4 04:50:38 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:50:38 +0000 Subject: hg: jdk7/tl/hotspot: 32 new changesets Message-ID: <20110604045141.EEF5447B8C@hg.openjdk.java.net> Changeset: 2aa9ddbb9e60 Author: jmasa Date: 2011-05-03 10:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2aa9ddbb9e60 7041789: 30% perf regression with c2/arm following 7017732 Summary: Implement a more accurate is_scavengable() Reviewed-by: stefank, jcoomes, ysr ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/oops/instanceRefKlass.cpp Changeset: 69293e516993 Author: johnc Date: 2011-05-17 00:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/69293e516993 7041440: G1: assert(obj->is_oop_or_null(true )) failed: Error # Summary: During an evacuation pause clear the region fields of any concurrent marking task whose local finger points into the collection set as the values in the region fields will become stale. Clearing these fields causes the concurrent mark task to claim a new region when marking restarts after the pause. Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: ea4859d7fee7 Author: brutisso Date: 2011-05-18 13:19 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ea4859d7fee7 Merge Changeset: 03b943e6c025 Author: dholmes Date: 2011-05-15 23:57 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/03b943e6c025 7035744: jprt no longer does open-only builds Summary: Added Open (OpenJDK) and Emb (Embedded) build flavours to JPRT. Added a few open builds and basic sanity tests to the normal JDK7 JPRT submission job. Reviewed-by: ohair, jcoomes, bobv, kvn ! make/jprt.gmk ! make/jprt.properties Changeset: 8bec9b249a6e Author: dholmes Date: 2011-05-17 09:29 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8bec9b249a6e Merge Changeset: 3f3325361b86 Author: kamg Date: 2011-05-18 10:12 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3f3325361b86 Merge Changeset: 38569792a45a Author: kvn Date: 2011-05-16 14:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/38569792a45a 7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488 Summary: Fix problems in new RCE code. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.hpp Changeset: f52ed367b66d Author: never Date: 2011-05-16 22:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f52ed367b66d 6996747: SIGSEGV in nmethod::cleanup_inline_caches / CompiledIC::verify Reviewed-by: kvn, iveresov ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 33ae33516634 Author: bdelsart Date: 2011-05-17 16:50 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/33ae33516634 7045515: ARM assembly code for JSR 292 ricochet frames Summary: ARM ricochet port and minor fixes in shared debug code Reviewed-by: jrose, vladidan ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 231c2b41ea4d Author: kvn Date: 2011-05-17 12:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/231c2b41ea4d 7045570: compiler/5091921/Test7005594.java failed because not enough space for object heap Summary: fixed tests. Reviewed-by: iveresov, never ! test/compiler/5091921/Test6890943.sh ! test/compiler/5091921/Test7005594.java + test/compiler/5091921/Test7005594.sh Changeset: 2848194272f4 Author: jrose Date: 2011-05-17 15:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2848194272f4 7044892: JSR 292: API entry points sometimes throw the wrong exceptions or doesn't throw the expected one Summary: Fix to 7042656: JSR292: invokeExact/Generic doesn't throw UnsupportedOperationException if invoked via Method.invoke Reviewed-by: never ! src/share/vm/prims/methodHandles.cpp Changeset: a80577f854f9 Author: never Date: 2011-05-17 19:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a80577f854f9 7045513: JSR 292 inlining causes crashes in methodHandleWalk.cpp Reviewed-by: jrose ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java + agent/src/share/classes/sun/jvm/hotspot/code/AdapterBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java + agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b79e8b4ecd76 Author: never Date: 2011-05-17 19:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b79e8b4ecd76 Merge ! src/share/vm/prims/methodHandles.cpp Changeset: 1be2f0c40a34 Author: never Date: 2011-05-18 11:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1be2f0c40a34 Merge Changeset: 62f39d40ebf1 Author: trims Date: 2011-05-20 05:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/62f39d40ebf1 7040781: Bump the HS21 build number to 14 Summary: Update the HS21 build number to 14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 278445be9145 Author: trims Date: 2011-05-24 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/278445be9145 Added tag hs21-b13 for changeset c149193c768b ! .hgtags Changeset: 01e01c25d24a Author: trims Date: 2011-05-24 14:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/01e01c25d24a Merge ! .hgtags Changeset: fe189d4a44e9 Author: katleman Date: 2011-05-25 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fe189d4a44e9 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! agent/src/share/classes/sun/jvm/hotspot/runtime/ServiceThread.java ! make/linux/README ! make/windows/projectfiles/kernel/Makefile ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/share/tools/hsdis/README ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/utilities/yieldingWorkgroup.cpp Changeset: d920485ae93b Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d920485ae93b Added tag jdk7-b144 for changeset fe189d4a44e9 ! .hgtags Changeset: 2b27ef5c2173 Author: kvn Date: 2011-05-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2b27ef5c2173 7046096: SEGV IN C2 WITH 6U25 Summary: Missing fail flag set in strings concatenation code. Reviewed-by: never ! src/share/vm/opto/stringopts.cpp Changeset: cfbca4d74a61 Author: jcoomes Date: 2011-05-20 22:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/cfbca4d74a61 Merge Changeset: 789d04408ca3 Author: kvn Date: 2011-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/789d04408ca3 7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently Summary: New limit for unrolled loop should be set only for zero trip guard and loop iteration test. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: b55f5bd7ec66 Author: kvn Date: 2011-05-21 13:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b55f5bd7ec66 7045506: assert(!can_reshape || !new_phi) failed: for igvn new phi should be hooked Summary: Replace the assert in PhiNode::Ideal with check to avoid transformation of new phi. Reviewed-by: never ! src/share/vm/opto/cfgnode.cpp Changeset: 7523488edce5 Author: kvn Date: 2011-05-24 12:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7523488edce5 7047300: VM crashes with assert(_base == InstPtr) failed: Not an object pointer Summary: The code incorrectly used is_instptr() instead of is_oopptr() to get const_oop. Reviewed-by: never ! src/share/vm/opto/output.cpp Changeset: ccf072cdba91 Author: iveresov Date: 2011-05-24 15:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ccf072cdba91 7046893: LP64 problem with double_quadword in c1_LIRAssembler_x86.cpp Summary: Fixed invalid casts in address computation Reviewed-by: kvn, never Contributed-by: thomas.salter at unisys.com ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 28a9fe9534ea Author: kvn Date: 2011-05-24 20:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/28a9fe9534ea 7048030: is_scavengable changes causing compiler to embed more constants Summary: ciObject::can_be_constant() and should_be_constant() should use is_perm() instead of !is_scavengable() Reviewed-by: never, jrose ! src/share/vm/ci/ciObject.cpp ! src/share/vm/ci/ciObject.hpp Changeset: 7db2b9499c36 Author: never Date: 2011-05-25 16:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7db2b9499c36 7046732: JSR 292 assert(result == cpce->f1()) failed: expected result for assembly code Reviewed-by: kvn, iveresov, jrose ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: 2d4b2b833d29 Author: coleenp Date: 2011-05-27 15:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2d4b2b833d29 7033141: assert(has_cp_cache(i)) failed: oob Summary: Unrewrite bytecodes for OOM error allocating the constant pool cache. Reviewed-by: dcubed, acorn, never ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 8cbcd406c42e Author: ysr Date: 2011-05-27 15:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8cbcd406c42e 7042740: CMS: assert(n> q) failed: Looping at: ... blockOffsetTable.cpp:557 Summary: Do a one-step look-ahead, when sweeping free or garbage blocks, to avoid overstepping sweep limit, which may become a non-block-boundary because of a heap expansion delta coalescing with a previously co-terminal free block. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/blockOffsetTable.cpp Changeset: b36598cf2c62 Author: jcoomes Date: 2011-05-27 23:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b36598cf2c62 Merge Changeset: 472fc37e14a9 Author: jcoomes Date: 2011-05-27 23:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/472fc37e14a9 7049385: Bump the HS21 build number to 15 Summary: Update the HS21 build number to 15 Reviewed-by: trims ! make/hotspot_version Changeset: 63d3fb179034 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/63d3fb179034 Merge From lana.steuck at oracle.com Sat Jun 4 04:51:02 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 04 Jun 2011 04:51:02 +0000 Subject: hg: jdk7/tl/jdk: 26 new changesets Message-ID: <20110604045527.2A4D347B8D@hg.openjdk.java.net> Changeset: 20bf5b0970e9 Author: jrose Date: 2011-05-17 19:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/20bf5b0970e9 7032850: MethodHandle.invokeGeneric throws unspecified RuntimeException if parameterized method is called Summary: Implement invocation corner cases, including correct type conversions and interface type enforcement. Reviewed-by: never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/InvokeGeneric.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/Wrapper.java ! test/java/lang/invoke/6991596/Test6991596.java ! test/java/lang/invoke/InvokeGenericTest.java Changeset: 9828d98bcf18 Author: jrose Date: 2011-05-17 19:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9828d98bcf18 7044892: JSR 292: API entry points sometimes throw the wrong exceptions or doesn't throw the expected one Summary: point-fixes for 7038847, 7038860, 7042656, 7042829, 7041853, and several other reports Reviewed-by: never, kvn ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/FilterGeneric.java ! src/share/classes/java/lang/invoke/FilterOneArgument.java ! src/share/classes/java/lang/invoke/FromGeneric.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java ! src/share/classes/java/lang/invoke/SpreadGeneric.java ! src/share/classes/java/lang/invoke/ToGeneric.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: be4b9e596352 Author: trims Date: 2011-05-20 05:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be4b9e596352 Merge Changeset: 127560d6f6e6 Author: trims Date: 2011-05-24 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/127560d6f6e6 Merge Changeset: 23bdcede4e39 Author: katleman Date: 2011-05-25 13:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/23bdcede4e39 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! src/linux/doc/man/ja/keytool.1 ! src/linux/doc/man/keytool.1 ! src/share/classes/java/io/SerialCallbackContext.java ! src/share/classes/sun/io/ByteToCharCp833.java ! src/share/classes/sun/io/CharToByteCp833.java ! src/share/classes/sun/misc/FpUtils.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/solaris/doc/sun/man/man1/ja/keytool.1 ! src/solaris/doc/sun/man/man1/keytool.1 ! test/com/sun/net/httpserver/Test10.java ! test/java/awt/List/ScrollOutside/ScrollOut.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_1.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_4.java ! test/java/awt/image/IncorrectSampleMaskTest.java ! test/java/lang/invoke/MethodTypeTest.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/util/EnumMap/DistinctEntrySetElements.java ! test/java/util/EnumMap/EntrySetIteratorRemoveInvalidatesEntry.java ! test/java/util/EnumMap/SimpleSerialization.java ! test/java/util/EnumSet/LargeEnumIteratorRemoveResilience.java ! test/java/util/EnumSet/SmallEnumIteratorRemoveResilience.java ! test/java/util/Hashtable/SerializationDeadlock.java ! test/java/util/Hashtable/SimpleSerialization.java ! test/java/util/IdentityHashMap/DistinctEntrySetElements.java ! test/java/util/IdentityHashMap/EntrySetIteratorRemoveInvalidatesEntry.java ! test/java/util/Vector/SerializationDeadlock.java ! test/java/util/Vector/SimpleSerialization.java ! test/java/util/concurrent/ConcurrentHashMap/DistinctEntrySetElements.java ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java ! test/sun/net/InetAddress/nameservice/chaining/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor ! test/tools/launcher/TestHelper.java ! test/tools/pack200/CommandLineTests.java ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/Utils.java Changeset: c344779fab58 Author: schien Date: 2011-05-26 20:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c344779fab58 Added tag jdk7-b144 for changeset 23bdcede4e39 ! .hgtags Changeset: f09930d526ba Author: jrose Date: 2011-05-26 17:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f09930d526ba 7032323: code changes for JSR 292 EG adjustments to API, through Public Review Summary: API code changes and javadoc changes following JSR 292 Public Review comments, through PFD Reviewed-by: never ! src/share/classes/java/lang/BootstrapMethodError.java ! src/share/classes/java/lang/ClassValue.java ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/ConstantCallSite.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SwitchPoint.java ! src/share/classes/java/lang/invoke/package-info.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/invoke/util/Wrapper.java ! test/java/lang/invoke/6998541/Test6998541.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/indify/Indify.java Changeset: 81f957f86ba5 Author: jcoomes Date: 2011-05-27 19:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81f957f86ba5 Merge Changeset: bc97b962330e Author: mfang Date: 2011-05-26 20:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bc97b962330e 7045184: GTK L&F doesn't have hotkeys in jdk7 b141, while b139 has. Reviewed-by: yhuang, ogino ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties Changeset: 6943c4d9caa3 Author: mfang Date: 2011-05-31 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6943c4d9caa3 Merge Changeset: 7c5bc5a807ee Author: dholmes Date: 2011-05-27 19:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c5bc5a807ee 7024120: Verify reduced JRE contents for java 7 Summary: stripped all symbols from libs and executables to reduce JRE size. Restored missing classes needed to pass JCK in headless mode Reviewed-by: bobv, ohair ! make/common/Defs-embedded.gmk ! make/common/Release-embedded.gmk Changeset: f4895b3fe1be Author: dholmes Date: 2011-05-31 17:28 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4895b3fe1be Merge Changeset: eab27338b3d9 Author: schien Date: 2011-06-01 11:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eab27338b3d9 Merge Changeset: 8d91855a1f4e Author: prr Date: 2011-05-27 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8d91855a1f4e 7046587: Outlines in OTF/CFF fonts are misclassified as quadratic curves Reviewed-by: igor ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/NullFontScaler.java Changeset: 0b0b92707cf5 Author: bae Date: 2011-05-30 12:05 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b0b92707cf5 7032904: XRender: Java2Demo : Infinite loop in Java_sun_java2d_loops_MaskBlit_MaskBlit on OEL 5.6 x64 Reviewed-by: prr ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 290daca0a693 Author: prr Date: 2011-05-30 22:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/290daca0a693 7049874: OpenJDK Build breakage fix: freetypescaler.c needs to match updated signature Reviewed-by: lana, igor ! src/share/native/sun/font/freetypeScaler.c Changeset: b351af09bfa3 Author: lana Date: 2011-06-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b351af09bfa3 Merge Changeset: d2081a1f417f Author: bagiras Date: 2011-05-27 11:45 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d2081a1f417f 7045174: Most of the tests in awt area fails with jdk 7b142 on windows with -Xcheck:jni Reviewed-by: art, denis ! src/windows/native/sun/windows/awt_Object.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 000a845b1e38 Author: denis Date: 2011-05-28 12:56 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/000a845b1e38 7046325: Broken links in java.awt.Toolkit's javadoc Reviewed-by: dav, yan ! src/share/classes/java/awt/Toolkit.java Changeset: eab94f59b6dc Author: dcherepanov Date: 2011-05-30 13:25 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eab94f59b6dc 7045354: Korean IME's Hanja candidate window is not displayed on IMFDemo Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Component.cpp Changeset: f05164caa490 Author: serb Date: 2011-05-30 17:16 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f05164caa490 7045193: interactive JCK tests java_awt/interactive/FileDialogTests fail Reviewed-by: dcherepanov, dav, art, denis ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java Changeset: b955226868af Author: lana Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b955226868af Merge Changeset: 1fbaf2b688a6 Author: rupashka Date: 2011-05-24 11:37 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1fbaf2b688a6 7045593: Possible Regression : JTextfield cursor placement behavior algorithm has changed. Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java + test/javax/swing/text/Utilities/bug7045593.java Changeset: 442237d3ec2c Author: rupashka Date: 2011-05-28 11:55 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/442237d3ec2c 7048204: NPE from NimbusLookAndFeel.addDefault Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/Test7048204.java Changeset: 386516fdf40b Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/386516fdf40b Merge Changeset: 39de8937c1d8 Author: lana Date: 2011-06-02 13:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/39de8937c1d8 Merge From alan.bateman at oracle.com Sat Jun 4 10:19:35 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 04 Jun 2011 10:19:35 +0000 Subject: hg: jdk7/tl/jdk: 7050358: (fs spec) Path.toUri doesn't allow custom providers to use opaque URIs Message-ID: <20110604101958.B7C1647BA3@hg.openjdk.java.net> Changeset: 53d759eb580c Author: alanb Date: 2011-06-04 11:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/53d759eb580c 7050358: (fs spec) Path.toUri doesn't allow custom providers to use opaque URIs Reviewed-by: sherman ! src/share/classes/java/nio/file/Path.java From sean.mullan at oracle.com Sat Jun 4 13:54:53 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Sat, 04 Jun 2011 13:54:53 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20110604135522.BDF2B47BAB@hg.openjdk.java.net> Changeset: 49aef5a5416e Author: mullan Date: 2011-06-04 06:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/49aef5a5416e 7050329: test/java/security/Policy/GetPermissions/JarURL.java fails on Windows Reviewed-by: alanb ! test/java/security/Policy/GetPermissions/JarURL.java + test/java/security/Policy/GetPermissions/JarURL.policy Changeset: 1f39ca0b9598 Author: mullan Date: 2011-06-04 06:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f39ca0b9598 Merge From weijun.wang at oracle.com Wed Jun 8 06:03:56 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 08 Jun 2011 06:03:56 +0000 Subject: hg: jdk8/tl/jdk: 7043737: klist does not detect non-existing keytab Message-ID: <20110608060420.4C85047CBE@hg.openjdk.java.net> Changeset: 9b678733fa51 Author: weijun Date: 2011-06-08 14:01 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b678733fa51 7043737: klist does not detect non-existing keytab Reviewed-by: valeriep ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java + test/sun/security/krb5/tools/ktmissing.sh From michael.x.mcmahon at oracle.com Wed Jun 8 09:58:35 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Wed, 08 Jun 2011 09:58:35 +0000 Subject: hg: jdk7/tl/jdk: 7050028: ISE "zip file closed" from JarURLConnection.getInputStream on JDK 7 when !useCaches Message-ID: <20110608095855.20FCB47CCB@hg.openjdk.java.net> Changeset: 6e961c328276 Author: michaelm Date: 2011-06-08 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e961c328276 7050028: ISE "zip file closed" from JarURLConnection.getInputStream on JDK 7 when !useCaches Reviewed-by: chegar, alanb ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B7050028.java From t.p.ellison at gmail.com Wed Jun 8 15:27:30 2011 From: t.p.ellison at gmail.com (Tim Ellison) Date: Wed, 08 Jun 2011 16:27:30 +0100 Subject: j.u.regex: Negated Character Classes In-Reply-To: <4DE95850.6040208@oracle.com> References: <4DE95850.6040208@oracle.com> Message-ID: <4DEF94E2.2050105@gmail.com> Hi Sherman, ok so I'll admit to reading through to the end of your note and finding it interesting ;-) Some comments in-lined. On 03/Jun/2011 22:55, Xueming Shen wrote: > I'm sure everybody understands what "negated character classes" [^...] > in j.u.regex means. > You would never have doubt about > > [^c] does NOT match "c" > [^0-9] does NOT match "8" > [^a-z] does NOT match "b" > [^a-bc-d] does NOT match 'c" > > But how about > > does [^[c]] match "c"? > does [^[0-9]] match "8"? > does [^[a-z]] match "b"? > does [^a-b[c-d]] match "c"? > > I was wrong on all of them when was asked first time and it took me > a while to figure out what is going on behind it. Oh, btw, the answer > is "yes" for all 4, yes, the > > [^[c]] matches "c" > [^[0-9]] matches "8" > [^[a-z]] matches "b". > [^a-b[c-d]] matches "c" (while [^a-bc-d] does NOT match "c") I would not have known the right answer to this quiz either; it seems that the use of nested character sets is sufficiently rare that we've not had to learn how these behave. > Another interesting sample is > > [^a-b[c-d]e-f] matches "c" but does NOT match "e" (so the "e-f" part after > the nested character class [c-d] does back to "normal"). > > It appears the "negation" of the "outer" character class does not > affect its nested character class, I think the easiest way to explain the situation is not to consider the negation separately, but that [^ is the syntax of a negated character set. Having a normal character set inside a negated character set then seems ok to me. > so [^X] is always opposite from > [^[X]], "X" to be any character class. > > Same "strange" thing seems to be true for "intersection operation &&" > as well, so both [a-d&&c-f] and [^a-d&&c-f] do NOT match "a". > > This does not sound correct, at least for me. This case is, I agree, a gotcha which is hard to justify through the syntax rather than the implementation. > The source code suggests that we are treating the nested/embedded > [...] character class and the "intersection &&" specially, so > > [^[X] is interpreted as [^] union [X] > [^X[Y]] is interpreted as [^X] union [Y] > [^X[Y]Z] is interpreted as [^XZ] union [Y] > [^X&&Y] is interpreted as [^X] && Y > > What I meant "treating...specially" is that we do NOT do the same > thing for other "embedded character classes", so while [^[a-z]] does > match "c", [^\p{Lower}] actually does NOT match "c", which I would > expect. > > The j.u.regex.Pattern APIs do NOT help. All the samples given for > "Character classes"[1] section are "simple" negation, no "nested" > sample is given. And neither "^" nor "[^...]" appear in the operator > precedence table. The behaviors in other regex engines, such as Perl > and POSIX, don't help, as "nested" character class is not supported > there. > > I did check with the original author who wrote this part of the code. > It appears the current implementation is indeed what he intended to > do back then, so this behavior is NOT an implementation bug but by > design. > > Personally I don't feel this design is not correct. More mind tricks ;-) ? You think the design *is* wrong? > Ideally, I would assume the spec either specifies [^...] as a > separate "group operator" to be the "complement" of [...], or "^" as > the "negation operator" with the lowest precedence, such as (from > lowest to highest) > > (1) Negation ^ (only at the beginning of the [...]) > (2) Intersection && > (3) Range - > (4) nested class [] or as I suggested above (5) negated class [^ ... ] and the understanding that nested classes do not 'inherit' the negation property of their parent. > > So > [^X[Y]] would be the "complement" of [X[Y]] > > [^X[Y]Z] would be the "complement" of [X[Y]Z] > > [^X&&Y] would be the "complement" of [X&&Y] > > for example, if I dump the regex internal logic node tree for the sample > regex > [^a-b[c-d]e-f], the jdk7 and jdk8 results would look like > > /home/sherman/TL/regex$ > /export/sherman/Workspace/jdk7/jdk/build/linux-i586/bin/java RegEx -flag > "1000" "[^a-b[c-d]e-f]" "c" > Pattern=<[^a-b[c-d]e-f]> > Input = > 1: (7) > 2: (0) > 3: (0) > 4: (0) > 5: (0) > 6: (0) > 7: (0) > ------------------------------- > match:true > groupCount=0 > > /home/sherman/TL/regex$ > /export/sherman/Workspace/jdk8/jdk/build/linux-i586/bin/java RegEx -flag > "1000" "[^a-b[c-d]e-f]" "c" > Pattern=<[^a-b[c-d]e-f]> > Input = > 1: (7) > 2: (0) > 3: (0) > 4: (0) > 5: (0) > 6: (0) > 7: (0) > ------------------------------- > match:false > > I know, most of people might not be interested, but if you have read > this far, means you are interested:-) and might have some opinions. > It is definitely an incompatible change, given this has been the > behavior from the very beginning of Java regex and has been there for > almost a decade, I would appreciate any comment/opinion, especially > if you agree that the existing behavior is NOT "correct" and therefor > we need to fix, OR you think the existing one is just fine (the fact > I only heard one complain the past 5 -6 years:-) so far), OR even the > existing behavior is not "ideal", but given the compatibility > concern, we might just leave it alone. Since it does not seem to be causing a great problem, I would be inclined to document it and leave it alone. Should the future include subtractive character classes then writing, e.g. [^a-z-[safe]] would seem more natural than [^a-z-[^safe]]. Regards, Tim > The fix/change itself is relatively easy, as showed at > > http://cr.openjdk.java.net/~sherman/pattern_cc/ > > > Thanks > -Sherman > > [1] http://download.java.net/jdk7/docs/api/java/util/regex/Pattern.html#cc From xueming.shen at oracle.com Wed Jun 8 18:47:45 2011 From: xueming.shen at oracle.com (Xueming Shen) Date: Wed, 08 Jun 2011 11:47:45 -0700 Subject: j.u.regex: Negated Character Classes In-Reply-To: <4DEF94E2.2050105@gmail.com> References: <4DE95850.6040208@oracle.com> <4DEF94E2.2050105@gmail.com> Message-ID: <4DEFC3D1.2060808@oracle.com> Hi Tim, Semantically I don't see too much difference between to consider [^ syntax as a "negated character set" or to separate the ^ out and treat it as an unary operator with the lowest precedence (only at the very beginning, of course). The issue here is whether or not to consider the nested class character (the character classes grouped by [...]) as a basic "element" of its enclosing class, equivalent to other elements, such as the literals", the predefined, the range and the union. While POSIX's bracket expression does not support nested/sub "bracket expression", it does define a set of so called "POSIX character classes" in form of [:...:] that can only be used inside the bracket expression, as a basic element, equivalent to other elements when nested/embedded in [...] or [^...]. So [a-z[:digit:] matches any of lowercase ascii or 0-9 digits and [^a-z[:digit"] matches any character that is NOT lowercase ascii AND 0-9 digits, in which the [:digit'] is an equivalence of 0-9, or [0-9] if nested bracket expression is supported. In Java, however the [0-9] (grouping), 0-9 (range) and \p{digit} are NOT treated as equivalent when inside [^..], but the same when inside [...]. My apology for the confusion. Yes, I meant to say "The design decision IS wrong":-) I agree that it appears not to be a "great" problem for most people, it might be OK just leave it alone (and document it somewhere), consider it has been the behavior for decade. But on the other side, it also makes the "compatibility" issue less severe:-) especially it's hard to "explain" the && case. -Sherman On 6/8/2011 8:27 AM, Tim Ellison wrote: > Hi Sherman, ok so I'll admit to reading through to the end of your note > and finding it interesting ;-) > > Some comments in-lined. > > On 03/Jun/2011 22:55, Xueming Shen wrote: >> I'm sure everybody understands what "negated character classes" [^...] >> in j.u.regex means. >> You would never have doubt about >> >> [^c] does NOT match "c" >> [^0-9] does NOT match "8" >> [^a-z] does NOT match "b" >> [^a-bc-d] does NOT match 'c" >> >> But how about >> >> does [^[c]] match "c"? >> does [^[0-9]] match "8"? >> does [^[a-z]] match "b"? >> does [^a-b[c-d]] match "c"? >> >> I was wrong on all of them when was asked first time and it took me >> a while to figure out what is going on behind it. Oh, btw, the answer >> is "yes" for all 4, yes, the >> >> [^[c]] matches "c" >> [^[0-9]] matches "8" >> [^[a-z]] matches "b". >> [^a-b[c-d]] matches "c" (while [^a-bc-d] does NOT match "c") > I would not have known the right answer to this quiz either; it seems > that the use of nested character sets is sufficiently rare that we've > not had to learn how these behave. > >> Another interesting sample is >> >> [^a-b[c-d]e-f] matches "c" but does NOT match "e" (so the "e-f" part after >> the nested character class [c-d] does back to "normal"). >> >> It appears the "negation" of the "outer" character class does not >> affect its nested character class, > I think the easiest way to explain the situation is not to consider the > negation separately, but that [^ is the syntax of a negated character > set. Having a normal character set inside a negated character set then > seems ok to me. > >> so [^X] is always opposite from >> [^[X]], "X" to be any character class. >> >> Same "strange" thing seems to be true for "intersection operation&&" >> as well, so both [a-d&&c-f] and [^a-d&&c-f] do NOT match "a". >> >> This does not sound correct, at least for me. > This case is, I agree, a gotcha which is hard to justify through the > syntax rather than the implementation. > >> The source code suggests that we are treating the nested/embedded >> [...] character class and the "intersection&&" specially, so >> >> [^[X] is interpreted as [^] union [X] >> [^X[Y]] is interpreted as [^X] union [Y] >> [^X[Y]Z] is interpreted as [^XZ] union [Y] >> [^X&&Y] is interpreted as [^X]&& Y >> >> What I meant "treating...specially" is that we do NOT do the same >> thing for other "embedded character classes", so while [^[a-z]] does >> match "c", [^\p{Lower}] actually does NOT match "c", which I would >> expect. >> >> The j.u.regex.Pattern APIs do NOT help. All the samples given for >> "Character classes"[1] section are "simple" negation, no "nested" >> sample is given. And neither "^" nor "[^...]" appear in the operator >> precedence table. The behaviors in other regex engines, such as Perl >> and POSIX, don't help, as "nested" character class is not supported >> there. >> >> I did check with the original author who wrote this part of the code. >> It appears the current implementation is indeed what he intended to >> do back then, so this behavior is NOT an implementation bug but by >> design. >> >> Personally I don't feel this design is not correct. > More mind tricks ;-) ? You think the design *is* wrong? > >> Ideally, I would assume the spec either specifies [^...] as a >> separate "group operator" to be the "complement" of [...], or "^" as >> the "negation operator" with the lowest precedence, such as (from >> lowest to highest) >> >> (1) Negation ^ (only at the beginning of the [...]) >> (2) Intersection&& >> (3) Range - >> (4) nested class [] > or as I suggested above > (5) negated class [^ ... ] > > and the understanding that nested classes do not 'inherit' the negation > property of their parent. > >> So >> [^X[Y]] would be the "complement" of [X[Y]] >> >> [^X[Y]Z] would be the "complement" of [X[Y]Z] >> >> [^X&&Y] would be the "complement" of [X&&Y] >> >> for example, if I dump the regex internal logic node tree for the sample >> regex >> [^a-b[c-d]e-f], the jdk7 and jdk8 results would look like >> >> /home/sherman/TL/regex$ >> /export/sherman/Workspace/jdk7/jdk/build/linux-i586/bin/java RegEx -flag >> "1000" "[^a-b[c-d]e-f]" "c" >> Pattern=<[^a-b[c-d]e-f]> >> Input = >> 1: (7) >> 2: (0) >> 3: (0) >> 4: (0) >> 5: (0) >> 6: (0) >> 7: (0) >> ------------------------------- >> match:true >> groupCount=0 >> >> /home/sherman/TL/regex$ >> /export/sherman/Workspace/jdk8/jdk/build/linux-i586/bin/java RegEx -flag >> "1000" "[^a-b[c-d]e-f]" "c" >> Pattern=<[^a-b[c-d]e-f]> >> Input = >> 1: (7) >> 2: (0) >> 3: (0) >> 4: (0) >> 5: (0) >> 6: (0) >> 7: (0) >> ------------------------------- >> match:false >> >> I know, most of people might not be interested, but if you have read >> this far, means you are interested:-) and might have some opinions. >> It is definitely an incompatible change, given this has been the >> behavior from the very beginning of Java regex and has been there for >> almost a decade, I would appreciate any comment/opinion, especially >> if you agree that the existing behavior is NOT "correct" and therefor >> we need to fix, OR you think the existing one is just fine (the fact >> I only heard one complain the past 5 -6 years:-) so far), OR even the >> existing behavior is not "ideal", but given the compatibility >> concern, we might just leave it alone. > Since it does not seem to be causing a great problem, I would be > inclined to document it and leave it alone. > > Should the future include subtractive character classes then writing, > e.g. [^a-z-[safe]] would seem more natural than [^a-z-[^safe]]. > > Regards, > Tim > >> The fix/change itself is relatively easy, as showed at >> >> http://cr.openjdk.java.net/~sherman/pattern_cc/ >> >> >> Thanks >> -Sherman >> >> [1] http://download.java.net/jdk7/docs/api/java/util/regex/Pattern.html#cc From sean.coffey at oracle.com Thu Jun 9 15:26:02 2011 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 09 Jun 2011 16:26:02 +0100 Subject: Code review request for 7049774 Message-ID: <4DF0E60A.6070006@oracle.com> 7049774 : UID construction appears to hang if time changed backwards I'm looking for code review of above reported issue. If system clock goes backwards on rmi server with active clients and 64k UID boundary is hit, the server will wait until system time progresses past the time at which UID class was instantiated. Fix is to not to use earlier times for such corner cases. bug ID should become public on bugs.sun.com over coming day. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7049774.0/ Regards, Sean. From chris.hegarty at oracle.com Thu Jun 9 16:05:52 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 09 Jun 2011 17:05:52 +0100 Subject: Code review request for 7049774 In-Reply-To: <4DF0E60A.6070006@oracle.com> References: <4DF0E60A.6070006@oracle.com> Message-ID: <4DF0EF60.5060504@oracle.com> I looks like this change may break the UID spec. "# time, a long equal to a time (as returned by System.currentTimeMillis()) at which the VM that this UID was generated in was alive, or zero for a well-known UID " 'time' may no longer be equal to currentTimeMillis. It looks like count is incremented for every UID created. I wonder if it may only be necessary to increment count if there is another UID created with the same time. This would allow a much larger number of UID's to be created before encountering the issue you are seeing? I'm guess that this change is actually targeted to jdk8, rather than the 'compare against' gate shown in the webrev. -Chris. On 06/ 9/11 04:26 PM, Se?n Coffey wrote: > 7049774 : UID construction appears to hang if time changed backwards > > I'm looking for code review of above reported issue. If system clock goes > backwards on rmi server with active clients and 64k UID boundary is hit, > the server will wait until system time progresses past the time at which > UID class > was instantiated. > > Fix is to not to use earlier times for such corner cases. > > bug ID should become public on bugs.sun.com over coming day. > > webrev : http://cr.openjdk.java.net/~coffeys/webrev.7049774.0/ > > Regards, > Sean. From sean.coffey at oracle.com Thu Jun 9 17:20:01 2011 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 09 Jun 2011 18:20:01 +0100 Subject: Code review request for 7049774 In-Reply-To: <4DF0EF60.5060504@oracle.com> References: <4DF0E60A.6070006@oracle.com> <4DF0EF60.5060504@oracle.com> Message-ID: <4DF100C1.1030302@oracle.com> On 09/06/2011 17:05, Chris Hegarty wrote: > I looks like this change may break the UID spec. > > "# time, a long equal to a time (as returned by > System.currentTimeMillis()) at which the VM that this UID was > generated in was alive, or zero for a well-known UID " > > 'time' may no longer be equal to currentTimeMillis. currentTimeMillis is only called after the 2^16 ids have be used/exhausted. time refers to time at when the VM was alive. We're still honouring this. The fix addresses a corner case where system clock may have gone backwards. At this stage the spec could become vague since it assumes "system clock is never set backward" This is making best case solution to such an issue. regards, Sean. > > It looks like count is incremented for every UID created. I wonder if > it may only be necessary to increment count if there is another UID > created with the same time. This would allow a much larger number of > UID's to be created before encountering the issue you are seeing? > > I'm guess that this change is actually targeted to jdk8, rather than > the 'compare against' gate shown in the webrev. > > -Chris. > > On 06/ 9/11 04:26 PM, Se?n Coffey wrote: >> 7049774 : UID construction appears to hang if time changed backwards >> >> I'm looking for code review of above reported issue. If system clock >> goes >> backwards on rmi server with active clients and 64k UID boundary is hit, >> the server will wait until system time progresses past the time at which >> UID class >> was instantiated. >> >> Fix is to not to use earlier times for such corner cases. >> >> bug ID should become public on bugs.sun.com over coming day. >> >> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7049774.0/ >> >> Regards, >> Sean. From David.Holmes at oracle.com Thu Jun 9 21:15:34 2011 From: David.Holmes at oracle.com (David Holmes) Date: Fri, 10 Jun 2011 07:15:34 +1000 Subject: Code review request for 7049774 In-Reply-To: <4DF0EF60.5060504@oracle.com> References: <4DF0E60A.6070006@oracle.com> <4DF0EF60.5060504@oracle.com> Message-ID: <4DF137F6.8070502@oracle.com> Hi Chris, Chris Hegarty said the following on 06/10/11 02:05: > I looks like this change may break the UID spec. > > "# time, a long equal to a time (as returned by > System.currentTimeMillis()) at which the VM that this UID was generated > in was alive, or zero for a well-known UID " > > 'time' may no longer be equal to currentTimeMillis. We should have added you to the conversation when a number of us discussed this. It doesn't actually say the the time field must be equal to the current value of currentTimeMillis, only that it must be a value of currentTimeMillis at which point the VM was alive. When time jumps backward we are in a bind because we want to preserve uniqueness even though the spec says uniqueness is not guaranteed in this case. By manually advancing the time we preserve uniqueness, don't "hang" waiting for the apparent time to advance, but play a little loose with the correlation of the time value. > It looks like count is incremented for every UID created. I wonder if it > may only be necessary to increment count if there is another UID created > with the same time. This would allow a much larger number of UID's to be > created before encountering the issue you are seeing? Right this was my reading of the spec too. We could/should be able to create 64K UIDs per millisecond. The problem is that if we check currentTimeMillis on every construction then performance will be abysmal. David > I'm guess that this change is actually targeted to jdk8, rather than the > 'compare against' gate shown in the webrev. > > -Chris. > > On 06/ 9/11 04:26 PM, Se?n Coffey wrote: >> 7049774 : UID construction appears to hang if time changed backwards >> >> I'm looking for code review of above reported issue. If system clock goes >> backwards on rmi server with active clients and 64k UID boundary is hit, >> the server will wait until system time progresses past the time at which >> UID class >> was instantiated. >> >> Fix is to not to use earlier times for such corner cases. >> >> bug ID should become public on bugs.sun.com over coming day. >> >> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7049774.0/ >> >> Regards, >> Sean. From jim.holmlund at sun.com Thu Jun 9 22:27:51 2011 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Thu, 09 Jun 2011 22:27:51 +0000 Subject: hg: jdk7/tl/langtools: 7052782: Two langtools regression tests fail due to fix for 7034977 which removed the invokeGeneric method Message-ID: <20110609222758.066F447DE6@hg.openjdk.java.net> Changeset: 347349c981f2 Author: jjh Date: 2011-06-09 09:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/347349c981f2 7052782: Two langtools regression tests fail due to fix for 7034977 which removed the invokeGeneric method Summary: Change the tests to call invoke instead of invokeGeneric Reviewed-by: jrose, mcimadamore ! test/tools/javac/meth/InvokeMH.java ! test/tools/javac/meth/XlintWarn.java From chris.hegarty at oracle.com Fri Jun 10 08:58:50 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Fri, 10 Jun 2011 09:58:50 +0100 Subject: Code review request for 7049774 In-Reply-To: <4DF137F6.8070502@oracle.com> References: <4DF0E60A.6070006@oracle.com> <4DF0EF60.5060504@oracle.com> <4DF137F6.8070502@oracle.com> Message-ID: <4DF1DCCA.7080701@oracle.com> On 06/ 9/11 10:15 PM, David Holmes wrote: > Hi Chris, > > Chris Hegarty said the following on 06/10/11 02:05: >> I looks like this change may break the UID spec. >> >> "# time, a long equal to a time (as returned by >> System.currentTimeMillis()) at which the VM that this UID was >> generated in was alive, or zero for a well-known UID " >> >> 'time' may no longer be equal to currentTimeMillis. > > We should have added you to the conversation when a number of us > discussed this. It doesn't actually say the the time field must be equal > to the current value of currentTimeMillis, only that it must be a value > of currentTimeMillis at which point the VM was alive. When time jumps > backward we are in a bind because we want to preserve uniqueness even > though the spec says uniqueness is not guaranteed in this case. By > manually advancing the time we preserve uniqueness, don't "hang" waiting > for the apparent time to advance, but play a little loose with the > correlation of the time value. > >> It looks like count is incremented for every UID created. I wonder if >> it may only be necessary to increment count if there is another UID >> created with the same time. This would allow a much larger number of >> UID's to be created before encountering the issue you are seeing? > > Right this was my reading of the spec too. We could/should be able to > create 64K UIDs per millisecond. The problem is that if we check > currentTimeMillis on every construction then performance will be abysmal. Ah yes I get this now. I don't have a specific problem with the proposed change, only that it doesn't look pretty ;-) Also, just to note that after this change time may now be a value that is not equal to a value returned by currentTimeMillis ( at any point in lifetime of the VM ). But I don't see a specific problem with this. I wonder if it is even worth invoking currentTimeMillis more than once. That is, lastTime is initialized with currentTimeMillis when the class is loaded, then simply increment lastTime when count reaches its maximum. I see no real benefit of trying to use the actual current time, given the new approach. But as I said, I don't have a specific problem with Sean's webrev if others are in agreement with it. -Chris. > > David > >> I'm guess that this change is actually targeted to jdk8, rather than >> the 'compare against' gate shown in the webrev. >> >> -Chris. >> >> On 06/ 9/11 04:26 PM, Se?n Coffey wrote: >>> 7049774 : UID construction appears to hang if time changed backwards >>> >>> I'm looking for code review of above reported issue. If system clock >>> goes >>> backwards on rmi server with active clients and 64k UID boundary is hit, >>> the server will wait until system time progresses past the time at which >>> UID class >>> was instantiated. >>> >>> Fix is to not to use earlier times for such corner cases. >>> >>> bug ID should become public on bugs.sun.com over coming day. >>> >>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7049774.0/ >>> >>> Regards, >>> Sean. From Alan.Bateman at oracle.com Fri Jun 10 13:56:43 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 10 Jun 2011 14:56:43 +0100 Subject: Code review request for 7049774 In-Reply-To: <4DF1DCCA.7080701@oracle.com> References: <4DF0E60A.6070006@oracle.com> <4DF0EF60.5060504@oracle.com> <4DF137F6.8070502@oracle.com> <4DF1DCCA.7080701@oracle.com> Message-ID: <4DF2229B.6030005@oracle.com> Chris Hegarty wrote: > : > > But as I said, I don't have a specific problem with Sean's webrev if > others are in agreement with it. This originally came up in the context of an older release of the proprietary JDK so there has been a bit of prior discussion. We asked Sean to bring it here as it applicable to the java.rmi.server.UID that is in OpenJDK too. Maybe for 8 or beyond then someone could reexamine UID and come up with a way to change the specification that doesn't cause compatibility issues. -Alan. From mike.duigou at oracle.com Fri Jun 10 15:54:18 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 10 Jun 2011 08:54:18 -0700 Subject: Code review request for 7049774 In-Reply-To: <4DF0E60A.6070006@oracle.com> References: <4DF0E60A.6070006@oracle.com> Message-ID: <064932DA-EB50-45EB-949C-E525F717FB80@oracle.com> This change looks good to me! Mike On Jun 9 2011, at 08:26 , Se?n Coffey wrote: > 7049774 : UID construction appears to hang if time changed backwards > > I'm looking for code review of above reported issue. If system clock goes > backwards on rmi server with active clients and 64k UID boundary is hit, > the server will wait until system time progresses past the time at which UID class > was instantiated. > > Fix is to not to use earlier times for such corner cases. > > bug ID should become public on bugs.sun.com over coming day. > > webrev : http://cr.openjdk.java.net/~coffeys/webrev.7049774.0/ > > Regards, > Sean. From dag.wanvik at oracle.com Fri Jun 10 16:16:39 2011 From: dag.wanvik at oracle.com (dag.wanvik at oracle.com) Date: Fri, 10 Jun 2011 16:16:39 +0000 Subject: hg: jdk7/tl/jdk: 7046557: Changes to the Java DB README files in JDK7 Message-ID: <20110610161651.7858847E9C@hg.openjdk.java.net> Changeset: b6ced5ad7a62 Author: dwanvik Date: 2011-06-10 17:44 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b6ced5ad7a62 7046557: Changes to the Java DB README files in JDK7 Summary: Update /README.html with correct mention of Java DB, add JDK specific README files to /db and /demo/db. Reviewed-by: ohair ! make/common/Release.gmk From zhouyx at linux.vnet.ibm.com Mon Jun 13 10:58:34 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Mon, 13 Jun 2011 18:58:34 +0800 Subject: Focus lost after minimize and restore a window on linux Message-ID: Hi all, I found a bug about focus lost on linux. The testcase is as follows: import java.awt.Color; import java.awt.Component; import java.awt.FlowLayout; import java.awt.Frame; import java.awt.event.WindowAdapter; import java.awt.event.WindowEvent; import javax.swing.JButton; public class FocusTest extends Frame { Component c; public FocusTest() { super("Single Frame --- AWT Frame"); super.setBackground(Color.gray); // set layout here. setLayout(new FlowLayout()); c = new JButton("JButton"); add(c); addWindowListener(new WindowAdapter() { public void windowClosing(WindowEvent event) { System.exit(0); } public void windowActivated(WindowEvent event){ /* // Timing block try { Thread.sleep(10); } catch (InterruptedException e) { // TODO Auto-generated catch block e.printStackTrace(); }*/ } }); setSize(850, 360); setVisible(true); } public static void main(String[] args) { new FocusTest(); } } Reproduce steps: 1. Run the testcase with java7 jre on Linux (ubuntu with unity or gnome and RHEL6 are tested.) 2. Click "JButton" so it get the focus. 3. Minimize the window. 4. Restore the window with mouse click on task icon or with alt+tab. Expected result: The focus is still on JButton. Observation: Focus is lost. Investigation: It seems a timing problem, if the "Timing block" is uncommented, the testcase works well. On my workstation, the minimal working sleep time is 5ms. If 3ms is used, the testcase fails too. I think the focus must be restored, it is very important for GUI applications. Can any body give some suggestion? -- Best Regards, Sean Chou From Alan.Bateman at oracle.com Mon Jun 13 16:03:23 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 13 Jun 2011 17:03:23 +0100 Subject: Is it finally time to remove the sun.io converters? Message-ID: <4DF634CB.7080906@oracle.com> The JDK hasn't used the legacy sun.io converters for many years. They were deprecated a long time ago and were originally due to be pulled out in jdk6. The jdk6 plans were scuppered by at least JDBC driver that insisted on calling into the sun.io.* classes directly. A second attempt in jdk7 also failed. Now that jdk8 is open for business then it seems a good time to try again. So if anyone knows of any code that it still using sun.io then now would be a good time to speak up. -Alan From joe.darcy at oracle.com Mon Jun 13 19:20:59 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 13 Jun 2011 19:20:59 +0000 Subject: hg: jdk8/tl/jdk: 7052122: Update JDK_MINOR_VERSION for JDK 8 Message-ID: <20110613192128.2A2EB47FDB@hg.openjdk.java.net> Changeset: 958eea7dd46e Author: darcy Date: 2011-06-13 12:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/958eea7dd46e 7052122: Update JDK_MINOR_VERSION for JDK 8 Reviewed-by: mr, katleman ! make/common/shared/Defs.gmk ! make/docs/Makefile From joe.darcy at oracle.com Mon Jun 13 19:21:36 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 13 Jun 2011 19:21:36 +0000 Subject: hg: jdk8/tl/langtools: 7052122: Update JDK_MINOR_VERSION for JDK 8 Message-ID: <20110613192141.A20EA47FDC@hg.openjdk.java.net> Changeset: 3b1fd4ac2e71 Author: darcy Date: 2011-06-13 12:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b1fd4ac2e71 7052122: Update JDK_MINOR_VERSION for JDK 8 Reviewed-by: mr, katleman + test/tools/javac/processing/model/TestSourceVersion.java From Ulf.Zibis at gmx.de Mon Jun 13 23:02:17 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 14 Jun 2011 01:02:17 +0200 Subject: Is it finally time to remove the sun.io converters? In-Reply-To: <4DF634CB.7080906@oracle.com> References: <4DF634CB.7080906@oracle.com> Message-ID: <4DF696F9.3080209@gmx.de> As replacement for the 323 classes in original sun.io you could use my wrapper classes: http://java.net/projects/java-nio-charset-enhanced/sources/svn/show/trunk/src/sun/io/ There remain only 8 classes. -Ulf Am 13.06.2011 18:03, schrieb Alan Bateman: > > The JDK hasn't used the legacy sun.io converters for many years. They were deprecated a long time > ago and were originally due to be pulled out in jdk6. The jdk6 plans were scuppered by at least > JDBC driver that insisted on calling into the sun.io.* classes directly. A second attempt in jdk7 > also failed. Now that jdk8 is open for business then it seems a good time to try again. So if > anyone knows of any code that it still using sun.io then now would be a good time to speak up. > > -Alan > > From Alan.Bateman at oracle.com Tue Jun 14 08:25:48 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 14 Jun 2011 09:25:48 +0100 Subject: Is it finally time to remove the sun.io converters? In-Reply-To: <4DF696F9.3080209@gmx.de> References: <4DF634CB.7080906@oracle.com> <4DF696F9.3080209@gmx.de> Message-ID: <4DF71B0C.2010602@oracle.com> Ulf Zibis wrote: > As replacement for the 323 classes in original sun.io you could use my > wrapper classes: > http://java.net/projects/java-nio-charset-enhanced/sources/svn/show/trunk/src/sun/io/ > > > There remain only 8 classes. I think this should be backup, as in a plan B. The JDK documentation has always warned developers not to use sun.* APIs. javac has even emitted warnings since the symbol file mechanism was added (jdk6?). In the case of sun.io then there's been a better solution (java.nio.charsets) since 1.4 and so folks have had nearly 9 years to move. They will have at least 10 or more years by the time that jdk8 ships. With modules coming in jdk8 then it seems a good opportunity to move on this. -Alan. From Ulf.Zibis at gmx.de Tue Jun 14 10:34:23 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 14 Jun 2011 12:34:23 +0200 Subject: Is it finally time to remove the sun.io converters? In-Reply-To: <4DF71B0C.2010602@oracle.com> References: <4DF634CB.7080906@oracle.com> <4DF696F9.3080209@gmx.de> <4DF71B0C.2010602@oracle.com> Message-ID: <4DF7392F.7010909@gmx.de> Am 14.06.2011 10:25, schrieb Alan Bateman: > Ulf Zibis wrote: >> As replacement for the 323 classes in original sun.io you could use my wrapper classes: >> http://java.net/projects/java-nio-charset-enhanced/sources/svn/show/trunk/src/sun/io/ >> >> There remain only 8 classes. > I think this should be backup, as in a plan B. The JDK documentation has always warned developers > not to use sun.* APIs. javac has even emitted warnings since the symbol file mechanism was added > (jdk6?). In the case of sun.io then there's been a better solution (java.nio.charsets) since 1.4 > and so folks have had nearly 9 years to move. They will have at least 10 or more years by the time > that jdk8 ships. With modules coming in jdk8 then it seems a good opportunity to move on this. > I mentioned this, because (1) in the meantime you could save ~300 classes, (2) must no more maintain sun.io if there are new encodings and (3) I did so much effort in those wrappers, so I would like to see them living. :-X But anyway, I would like to see sun.io package removed. Don't forget weather sun.io package is removed or replaced by my wrapper: Almost all *Charset classes in sun.nio package* could be made *package private*, so no one can access them externally. - Ulf From sean.coffey at oracle.com Tue Jun 14 17:02:19 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 14 Jun 2011 17:02:19 +0000 Subject: hg: jdk8/tl/jdk: 7049774: UID construction appears to hang if time changed backwards Message-ID: <20110614170229.3352B47012@hg.openjdk.java.net> Changeset: 08fdfdb19ad6 Author: coffeys Date: 2011-06-14 18:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/08fdfdb19ad6 7049774: UID construction appears to hang if time changed backwards Reviewed-by: alanb, dholmes, chegar, mduigou ! src/share/classes/java/rmi/server/UID.java From joe.darcy at oracle.com Tue Jun 14 19:31:57 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 14 Jun 2011 19:31:57 +0000 Subject: hg: jdk8/tl/jdk: 7054669: javadoc warnings from java.awt.Toolkit Message-ID: <20110614193222.3762D47019@hg.openjdk.java.net> Changeset: 4e7a9fa84dea Author: darcy Date: 2011-06-14 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4e7a9fa84dea 7054669: javadoc warnings from java.awt.Toolkit Reviewed-by: anthony ! src/share/classes/java/awt/Toolkit.java From joe.darcy at oracle.com Wed Jun 15 15:37:50 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Wed, 15 Jun 2011 15:37:50 +0000 Subject: hg: jdk8/tl/jdk: 7041252: Use j.u.Objects.equals in security classes Message-ID: <20110615153816.E9AF74704F@hg.openjdk.java.net> Changeset: 33e6291f3251 Author: darcy Date: 2011-06-15 08:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33e6291f3251 7041252: Use j.u.Objects.equals in security classes Reviewed-by: weijun ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/x509/DistributionPoint.java ! src/share/classes/sun/security/x509/DistributionPointName.java From joe.darcy at oracle.com Wed Jun 15 18:00:27 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 15 Jun 2011 11:00:27 -0700 Subject: Code review request for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null Message-ID: <4DF8F33B.3060007@oracle.com> Hello. Please review my JDK 8 fix for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null http://cr.openjdk.java.net/~darcy/7021922.0/ Thanks, -Joe From forax at univ-mlv.fr Wed Jun 15 18:13:18 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Wed, 15 Jun 2011 20:13:18 +0200 Subject: Code review request for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null In-Reply-To: <4DF8F33B.3060007@oracle.com> References: <4DF8F33B.3060007@oracle.com> Message-ID: <4DF8F63E.1070406@univ-mlv.fr> On 06/15/2011 08:00 PM, Joe Darcy wrote: > Hello. > > Please review my JDK 8 fix for > > 7021922: java.lang.annoation.IncompleteExceptions throws NPE when > type is null > http://cr.openjdk.java.net/~darcy/7021922.0/ > > Thanks, > > -Joe Looks good. R?mi From Alan.Bateman at oracle.com Wed Jun 15 18:17:55 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 15 Jun 2011 19:17:55 +0100 Subject: Code review request for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null In-Reply-To: <4DF8F33B.3060007@oracle.com> References: <4DF8F33B.3060007@oracle.com> Message-ID: <4DF8F753.6030504@oracle.com> Joe Darcy wrote: > Hello. > > Please review my JDK 8 fix for > > 7021922: java.lang.annoation.IncompleteExceptions throws NPE when > type is null > http://cr.openjdk.java.net/~darcy/7021922.0/ > > Thanks, > > -Joe Looks okay to me. -Alan From jason_mehrens at hotmail.com Wed Jun 15 18:35:03 2011 From: jason_mehrens at hotmail.com (Jason Mehrens) Date: Wed, 15 Jun 2011 13:35:03 -0500 Subject: Code review request for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null In-Reply-To: <4DF8F33B.3060007@oracle.com> References: <4DF8F33B.3060007@oracle.com> Message-ID: Typo in the javadocs. "is either.." should be "if either..". Jason > Date: Wed, 15 Jun 2011 11:00:27 -0700 > From: joe.darcy at oracle.com > To: core-libs-dev at openjdk.java.net > Subject: Code review request for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null > > Hello. > > Please review my JDK 8 fix for > > 7021922: java.lang.annoation.IncompleteExceptions throws NPE when > type is null > http://cr.openjdk.java.net/~darcy/7021922.0/ > > Thanks, > > -Joe From joe.darcy at oracle.com Wed Jun 15 18:37:01 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 15 Jun 2011 11:37:01 -0700 Subject: Code review request for 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null In-Reply-To: References: <4DF8F33B.3060007@oracle.com> Message-ID: <4DF8FBCD.9090404@oracle.com> I'll correct that typo before the push; thanks, -Joe Jason Mehrens wrote: > Typo in the javadocs. "is either.." should be "if either..". > > Jason > > > Date: Wed, 15 Jun 2011 11:00:27 -0700 > > From: joe.darcy at oracle.com > > To: core-libs-dev at openjdk.java.net > > Subject: Code review request for 7021922: > java.lang.annoation.IncompleteExceptions throws NPE when type is null > > > > Hello. > > > > Please review my JDK 8 fix for > > > > 7021922: java.lang.annoation.IncompleteExceptions throws NPE when > > type is null > > http://cr.openjdk.java.net/~darcy/7021922.0/ > > > > Thanks, > > > > -Joe From joe.darcy at oracle.com Thu Jun 16 00:35:38 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 15 Jun 2011 17:35:38 -0700 Subject: JDK 8 code review request for 6226715: (ann) java.lang.annotation.AnnotationTypeMismatchException could not be serialized Message-ID: <4DF94FDA.9030405@oracle.com> Hello. Please review my JDK 8 fix for 6226715: (ann) java.lang.annotation.AnnotationTypeMismatchException could not be serialized http://cr.openjdk.java.net/~darcy/6226715.0/ This fix includes the unusual step of marking a non-transient field transient in a serialiable class, but the class can't meaningfully be serialized today anyway so this change should have no adverse effect in practice. For good code hygiene, the new readObject method explicitly sets the now transient field in question. Thanks, -Joe From joe.darcy at oracle.com Thu Jun 16 00:51:11 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 15 Jun 2011 17:51:11 -0700 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError Message-ID: <4DF9537F.6010202@oracle.com> Hello. Please review this simple JDK 8 patch below to add a second constructor to the GenericSignatureFormatError class: Thanks, -Joe --- a/src/share/classes/java/lang/reflect/GenericSignatureFormatError.java +++ b/src/share/classes/java/lang/reflect/GenericSignatureFormatError.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2008, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -35,4 +35,23 @@ */ public class GenericSignatureFormatError extends ClassFormatError { private static final long serialVersionUID = 6709919147137911034L; + + /** + * Constructs a new {@code GenericSignatureFormatError}. + * + */ + public GenericSignatureFormatError() { + super(); + } + + + /** + * Constructs a new {@code GenericSignatureFormatError} with the + * specified message. + * + * @param message the detail message, may be {@code null} + */ + public GenericSignatureFormatError(String message) { + super(message); + } } From Lance.Andersen at oracle.com Thu Jun 16 00:54:05 2011 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Wed, 15 Jun 2011 20:54:05 -0400 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError In-Reply-To: <4DF9537F.6010202@oracle.com> References: <4DF9537F.6010202@oracle.com> Message-ID: <6A4DD776-4D8C-46DB-8ECF-C40D2FF972B0@oracle.com> works for me Joe -Lance On Jun 15, 2011, at 8:51 PM, Joe Darcy wrote: > GenericSignatureFormatError Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From forax at univ-mlv.fr Thu Jun 16 08:15:44 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 16 Jun 2011 10:15:44 +0200 Subject: JDK 8 code review request for 6226715: (ann) java.lang.annotation.AnnotationTypeMismatchException could not be serialized In-Reply-To: <4DF94FDA.9030405@oracle.com> References: <4DF94FDA.9030405@oracle.com> Message-ID: <4DF9BBB0.4040704@univ-mlv.fr> Le 16/06/2011 02:35, Joe Darcy a ?crit : > Hello. > > Please review my JDK 8 fix for > > 6226715: (ann) java.lang.annotation.AnnotationTypeMismatchException > could not be serialized > http://cr.openjdk.java.net/~darcy/6226715.0/ > > This fix includes the unusual step of marking a non-transient field > transient in a serialiable class, but the class can't meaningfully be > serialized today anyway so this change should have no adverse effect > in practice. > > For good code hygiene, the new readObject method explicitly sets the > now transient field in question. Not sure it's good to drop 'final' just for code hygiene. A code that relies on the fact that this exception is non-mutable can now fail. > > Thanks, > > -Joe cheers, R?mi From chris.hegarty at oracle.com Thu Jun 16 10:18:37 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 16 Jun 2011 11:18:37 +0100 Subject: Code Review 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence Message-ID: <4DF9D87D.1090104@oracle.com> Hi, ThreadLocalRandom uses its own seed, not the seed of the super class. ThreadLocalRandom() { super(); initialized = true; } This uselessly initializes the parent seed via the default constructor but leaves the real seed at zero. Webrev: http://cr.openjdk.java.net/~chegar/7051516/jdk8_webrev.00/webrev/ Note: This is a port of the fix from Doug's CVS to OpenJDK. A test has been added to Doug's CVS tck tests for ThreadLocalRandom, and I will file a CR against the JCK to have it pulled in to JCK8. -Chris. From joe.darcy at oracle.com Thu Jun 16 15:17:13 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 16 Jun 2011 08:17:13 -0700 Subject: JDK 8 code review request for 6226715: (ann) java.lang.annotation.AnnotationTypeMismatchException could not be serialized In-Reply-To: <4DF9BBB0.4040704@univ-mlv.fr> References: <4DF94FDA.9030405@oracle.com> <4DF9BBB0.4040704@univ-mlv.fr> Message-ID: <4DFA1E79.3010402@oracle.com> R?mi Forax wrote: > Le 16/06/2011 02:35, Joe Darcy a ?crit : >> Hello. >> >> Please review my JDK 8 fix for >> >> 6226715: (ann) >> java.lang.annotation.AnnotationTypeMismatchException could not be >> serialized >> http://cr.openjdk.java.net/~darcy/6226715.0/ >> >> This fix includes the unusual step of marking a non-transient field >> transient in a serialiable class, but the class can't meaningfully be >> serialized today anyway so this change should have no adverse effect >> in practice. >> >> For good code hygiene, the new readObject method explicitly sets the >> now transient field in question. > > Not sure it's good to drop 'final' just for code hygiene. > A code that relies on the fact that this exception is non-mutable can > now fail. There is no setter for the field other than through the constructor (and now readObject). I don't really want to dip into sun.misc.Unsafe to set a final transient field in the readObject method. -Joe From mike.duigou at oracle.com Thu Jun 16 16:21:44 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 16 Jun 2011 09:21:44 -0700 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError In-Reply-To: <4DF9537F.6010202@oracle.com> References: <4DF9537F.6010202@oracle.com> Message-ID: Perhaps the chained exception constructor would also be useful. I can imagine that whatever was parsing the signature might throw an exception with it's parse state that could then be captured (without needing to use initCause()) in the thrown GenericSignatureFormatError Mike On Jun 15 2011, at 17:51 , Joe Darcy wrote: > Hello. > > Please review this simple JDK 8 patch below to add a second constructor to the GenericSignatureFormatError class: > > Thanks, > > -Joe > > --- a/src/share/classes/java/lang/reflect/GenericSignatureFormatError.java > +++ b/src/share/classes/java/lang/reflect/GenericSignatureFormatError.java > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2003, 2008, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -35,4 +35,23 @@ > */ > public class GenericSignatureFormatError extends ClassFormatError { > private static final long serialVersionUID = 6709919147137911034L; > + > + /** > + * Constructs a new {@code GenericSignatureFormatError}. > + * > + */ > + public GenericSignatureFormatError() { > + super(); > + } > + > + > + /** > + * Constructs a new {@code GenericSignatureFormatError} with the > + * specified message. > + * > + * @param message the detail message, may be {@code null} > + */ > + public GenericSignatureFormatError(String message) { > + super(message); > + } > } From mike.duigou at oracle.com Thu Jun 16 16:32:49 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 16 Jun 2011 09:32:49 -0700 Subject: Code Review 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence In-Reply-To: <4DF9D87D.1090104@oracle.com> References: <4DF9D87D.1090104@oracle.com> Message-ID: <27D69877-8389-4936-8EDA-9EA6FBDCB983@oracle.com> Hi Chris; The getClass() seems unnecessary. Why not : public Random(long seed) { this.seed = new AtomicLong(); setSeed(seed); } or private final AtomicLong seed = new AtomicLong(); public Random(long seed) { setSeed(seed); } Both of these would seem to have the same effect without needing to do the explicit class check. Mike On Jun 16 2011, at 03:18 , Chris Hegarty wrote: > Hi, > > ThreadLocalRandom uses its own seed, not the seed of the super class. > > ThreadLocalRandom() { > super(); > initialized = true; > } > > This uselessly initializes the parent seed via the default constructor but leaves the real seed at zero. > > Webrev: > http://cr.openjdk.java.net/~chegar/7051516/jdk8_webrev.00/webrev/ > > Note: > This is a port of the fix from Doug's CVS to OpenJDK. A test has been added to Doug's CVS tck tests for ThreadLocalRandom, and I will file a CR against the JCK to have it pulled in to JCK8. > > -Chris. From joe.darcy at oracle.com Thu Jun 16 16:35:53 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 16 Jun 2011 09:35:53 -0700 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError In-Reply-To: References: <4DF9537F.6010202@oracle.com> Message-ID: <4DFA30E9.40408@oracle.com> On 6/16/2011 9:21 AM, Mike Duigou wrote: > Perhaps the chained exception constructor would also be useful. I can imagine that whatever was parsing the signature might throw an exception with it's parse state that could then be captured (without needing to use initCause()) in the thrown GenericSignatureFormatError > > Mike Hi Mike. At least as currently used in the JDK, the String constructor would suffice -- there are no causal exceptions in how the signature parser is coded. (If we were to add a third constructor taking a cause, we should also add a fourth constructor taking a cause and a message.) -Joe From chris.hegarty at oracle.com Thu Jun 16 16:37:13 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 16 Jun 2011 17:37:13 +0100 Subject: Code Review 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence In-Reply-To: <27D69877-8389-4936-8EDA-9EA6FBDCB983@oracle.com> References: <4DF9D87D.1090104@oracle.com> <27D69877-8389-4936-8EDA-9EA6FBDCB983@oracle.com> Message-ID: <4DFA3139.6080206@oracle.com> On 06/16/11 05:32 PM, Mike Duigou wrote: > Hi Chris; > > The getClass() seems unnecessary. Why not : > > public Random(long seed) { > this.seed = new AtomicLong(); > setSeed(seed); > } > > or > > private final AtomicLong seed = new AtomicLong(); > > public Random(long seed) { > setSeed(seed); > } > > Both of these would seem to have the same effect without needing to do the explicit class check. The change ( originally from Martin ) tries to save a couple of volatile writes in the common case. Yes, it's not a pretty as it could be. -Chris. > > Mike > > On Jun 16 2011, at 03:18 , Chris Hegarty wrote: > >> Hi, >> >> ThreadLocalRandom uses its own seed, not the seed of the super class. >> >> ThreadLocalRandom() { >> super(); >> initialized = true; >> } >> >> This uselessly initializes the parent seed via the default constructor but leaves the real seed at zero. >> >> Webrev: >> http://cr.openjdk.java.net/~chegar/7051516/jdk8_webrev.00/webrev/ >> >> Note: >> This is a port of the fix from Doug's CVS to OpenJDK. A test has been added to Doug's CVS tck tests for ThreadLocalRandom, and I will file a CR against the JCK to have it pulled in to JCK8. >> >> -Chris. > From mike.duigou at oracle.com Thu Jun 16 16:49:28 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 16 Jun 2011 09:49:28 -0700 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError In-Reply-To: <4DFA30E9.40408@oracle.com> References: <4DF9537F.6010202@oracle.com> <4DFA30E9.40408@oracle.com> Message-ID: <3C87EAAE-043A-4364-A099-A37D018B8F9C@oracle.com> I guess that's what I should have suggested--that all exceptions/errors with public constructors should support all four of the standard constructors declared by 1.4+ Throwable. It's been occasionally annoying to use an exception class that's missing one or more of the standard constructors. It has usually been an exception class outside the JDK but it seems like a reasonable practice to include all four. Mike On Jun 16 2011, at 09:35 , Joe Darcy wrote: > On 6/16/2011 9:21 AM, Mike Duigou wrote: >> Perhaps the chained exception constructor would also be useful. I can imagine that whatever was parsing the signature might throw an exception with it's parse state that could then be captured (without needing to use initCause()) in the thrown GenericSignatureFormatError >> >> Mike > > Hi Mike. > > At least as currently used in the JDK, the String constructor would suffice -- there are no causal exceptions in how the signature parser is coded. > > (If we were to add a third constructor taking a cause, we should also add a fourth constructor taking a cause and a message.) > > -Joe > From forax at univ-mlv.fr Thu Jun 16 18:18:00 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 16 Jun 2011 20:18:00 +0200 Subject: JDK 8 code review request for 6226715: (ann) java.lang.annotation.AnnotationTypeMismatchException could not be serialized In-Reply-To: <4DFA1E79.3010402@oracle.com> References: <4DF94FDA.9030405@oracle.com> <4DF9BBB0.4040704@univ-mlv.fr> <4DFA1E79.3010402@oracle.com> Message-ID: <4DFA48D8.3050303@univ-mlv.fr> On 06/16/2011 05:17 PM, Joe Darcy wrote: > R?mi Forax wrote: >> Le 16/06/2011 02:35, Joe Darcy a ?crit : >>> Hello. >>> >>> Please review my JDK 8 fix for >>> >>> 6226715: (ann) >>> java.lang.annotation.AnnotationTypeMismatchException could not be >>> serialized >>> http://cr.openjdk.java.net/~darcy/6226715.0/ >>> >>> This fix includes the unusual step of marking a non-transient field >>> transient in a serialiable class, but the class can't meaningfully >>> be serialized today anyway so this change should have no adverse >>> effect in practice. >>> >>> For good code hygiene, the new readObject method explicitly sets the >>> now transient field in question. >> >> Not sure it's good to drop 'final' just for code hygiene. >> A code that relies on the fact that this exception is non-mutable can >> now fail. > > There is no setter for the field other than through the constructor > (and now readObject). Because the field is not final a thread can see this field null even if the exception was created with a value. > > I don't really want to dip into sun.misc.Unsafe to set a final > transient field in the readObject method. why do you want to set the field to null knowing that null is the default value ? > > -Joe R?mi From forax at univ-mlv.fr Thu Jun 16 18:19:31 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Thu, 16 Jun 2011 20:19:31 +0200 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError In-Reply-To: <3C87EAAE-043A-4364-A099-A37D018B8F9C@oracle.com> References: <4DF9537F.6010202@oracle.com> <4DFA30E9.40408@oracle.com> <3C87EAAE-043A-4364-A099-A37D018B8F9C@oracle.com> Message-ID: <4DFA4933.7050605@univ-mlv.fr> On 06/16/2011 06:49 PM, Mike Duigou wrote: > I guess that's what I should have suggested--that all exceptions/errors with public constructors should support all four of the standard constructors declared by 1.4+ Throwable. It's been occasionally annoying to use an exception class that's missing one or more of the standard constructors. It has usually been an exception class outside the JDK but it seems like a reasonable practice to include all four. > > Mike You can still use initCause(). R?mi > > On Jun 16 2011, at 09:35 , Joe Darcy wrote: > >> On 6/16/2011 9:21 AM, Mike Duigou wrote: >>> Perhaps the chained exception constructor would also be useful. I can imagine that whatever was parsing the signature might throw an exception with it's parse state that could then be captured (without needing to use initCause()) in the thrown GenericSignatureFormatError >>> >>> Mike >> Hi Mike. >> >> At least as currently used in the JDK, the String constructor would suffice -- there are no causal exceptions in how the signature parser is coded. >> >> (If we were to add a third constructor taking a cause, we should also add a fourth constructor taking a cause and a message.) >> >> -Joe >> From joe.darcy at oracle.com Thu Jun 16 18:22:59 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 16 Jun 2011 11:22:59 -0700 Subject: JDK 8 code review request for 7055295: (reflect) add conventional constructor to GenericSignatureFormatError In-Reply-To: <3C87EAAE-043A-4364-A099-A37D018B8F9C@oracle.com> References: <4DF9537F.6010202@oracle.com> <4DFA30E9.40408@oracle.com> <3C87EAAE-043A-4364-A099-A37D018B8F9C@oracle.com> Message-ID: <4DFA4A03.4070302@oracle.com> As chance would have it, I recently wrote myself a note for "audit constructor choices in JDK exceptions" as a possible little project for JDK 8. I have also been annoyed by some missing exception constructors and I filled in one such omission in JDK 7, "6935997 Please add a nested throwable constructor to AssertionError." So if we were to systematically to through and look to add all four constructors to all exception types in the JDK, then I agree GenericSignatureFormatError should have them too, but in the absence of that effort, I think just adding the constructor taking a string message is sufficient for now. -Joe On 6/16/2011 9:49 AM, Mike Duigou wrote: > I guess that's what I should have suggested--that all exceptions/errors with public constructors should support all four of the standard constructors declared by 1.4+ Throwable. It's been occasionally annoying to use an exception class that's missing one or more of the standard constructors. It has usually been an exception class outside the JDK but it seems like a reasonable practice to include all four. > > Mike > > > On Jun 16 2011, at 09:35 , Joe Darcy wrote: > >> On 6/16/2011 9:21 AM, Mike Duigou wrote: >>> Perhaps the chained exception constructor would also be useful. I can imagine that whatever was parsing the signature might throw an exception with it's parse state that could then be captured (without needing to use initCause()) in the thrown GenericSignatureFormatError >>> >>> Mike >> Hi Mike. >> >> At least as currently used in the JDK, the String constructor would suffice -- there are no causal exceptions in how the signature parser is coded. >> >> (If we were to add a third constructor taking a cause, we should also add a fourth constructor taking a cause and a message.) >> >> -Joe >> From kumar.x.srinivasan at oracle.COM Thu Jun 16 23:01:20 2011 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Thu, 16 Jun 2011 16:01:20 -0700 Subject: minor launcher test fixes: 7043125 Message-ID: <4DFA8B40.1020609@oracle.COM> Description: http://cr.openjdk.java.net/~ksrini/7043125/cmt.txt Webrev: http://cr.openjdk.java.net/~ksrini/7043125/webrev.0/ Thanks Kumar From David.Holmes at oracle.com Fri Jun 17 01:40:20 2011 From: David.Holmes at oracle.com (David Holmes) Date: Fri, 17 Jun 2011 11:40:20 +1000 Subject: Code Review 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence In-Reply-To: <4DFA3139.6080206@oracle.com> References: <4DF9D87D.1090104@oracle.com> <27D69877-8389-4936-8EDA-9EA6FBDCB983@oracle.com> <4DFA3139.6080206@oracle.com> Message-ID: <4DFAB084.7060305@oracle.com> Chris Hegarty said the following on 06/17/11 02:37: > On 06/16/11 05:32 PM, Mike Duigou wrote: >> Hi Chris; >> >> The getClass() seems unnecessary. Why not : >> >> public Random(long seed) { >> this.seed = new AtomicLong(); >> setSeed(seed); >> } >> >> or >> >> private final AtomicLong seed = new AtomicLong(); >> >> public Random(long seed) { >> setSeed(seed); >> } >> >> Both of these would seem to have the same effect without needing to do >> the explicit class check. > > The change ( originally from Martin ) tries to save a couple of volatile > writes in the common case. Yes, it's not a pretty as it could be. But is the getClass + check + branch cheaper than those volatile writes? I know the history is somewhat convoluted here and the real problem was caused by trying to define a subclass (ThreadLocalRandom) of Random that stripped away Random's thread-safety mechanisms. You not only end up with redundant state (two seeds!) but it breaks type substitutability. :( But the milk has been spilt here and right now we just need to have TLR properly initialize its local seed. So its a thumbs up from me. David From joe.darcy at oracle.com Fri Jun 17 01:50:24 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 16 Jun 2011 18:50:24 -0700 Subject: minor launcher test fixes: 7043125 In-Reply-To: <4DFA8B40.1020609@oracle.COM> References: <4DFA8B40.1020609@oracle.COM> Message-ID: <4DFAB2E0.7070800@oracle.com> Looks fine; approved, -Joe On 6/16/2011 4:01 PM, Kumar Srinivasan wrote: > Description: > http://cr.openjdk.java.net/~ksrini/7043125/cmt.txt > > Webrev: > http://cr.openjdk.java.net/~ksrini/7043125/webrev.0/ > > Thanks > Kumar > From alan.bateman at oracle.com Fri Jun 17 15:58:49 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 17 Jun 2011 15:58:49 +0000 Subject: hg: jdk7/tl/jdk: 7055508: (aio) EXCEPTION_ACCESS_VIOLATION in AsynchronousSocketChannel.connect on Windows 7 Message-ID: <20110617155901.5FBA9470D2@hg.openjdk.java.net> Changeset: c46f97579fe6 Author: alanb Date: 2011-06-17 16:47 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c46f97579fe6 7055508: (aio) EXCEPTION_ACCESS_VIOLATION in AsynchronousSocketChannel.connect on Windows 7 Reviewed-by: chegar ! src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c From joe.darcy at oracle.com Fri Jun 17 17:35:18 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 17 Jun 2011 17:35:18 +0000 Subject: hg: jdk8/tl/jdk: 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null Message-ID: <20110617173544.D26B1470D6@hg.openjdk.java.net> Changeset: 85480980cd5e Author: darcy Date: 2011-06-17 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85480980cd5e 7021922: java.lang.annoation.IncompleteExceptions throws NPE when type is null Reviewed-by: alanb, forax ! src/share/classes/java/lang/annotation/IncompleteAnnotationException.java + test/java/lang/annotation/TestIncompleteAnnotationExceptionNPE.java From kumar.x.srinivasan at oracle.com Fri Jun 17 22:29:30 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 17 Jun 2011 22:29:30 +0000 Subject: hg: jdk8/tl/jdk: 7043125: TEST: tools/launcher/VersionCheck.java fails just against openjdk7 (b141 & b138-nightly) promoted Message-ID: <20110617222939.EF497470E3@hg.openjdk.java.net> Changeset: e373b4c95b4b Author: ksrini Date: 2011-06-17 15:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e373b4c95b4b 7043125: TEST: tools/launcher/VersionCheck.java fails just against openjdk7 (b141 & b138-nightly) promoted Reviewed-by: darcy ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/VersionCheck.java From joe.darcy at oracle.com Sat Jun 18 01:38:14 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 17 Jun 2011 18:38:14 -0700 Subject: Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" Message-ID: <4DFC0186.6060607@oracle.com> Hello. Please review this (somewhat tedious) change to make the behavior of the Number subtypes in the JDK more explicit: 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" http://cr.openjdk.java.net/~darcy/6253144.0/ David, how are changes to AtomicInteger and AtomicLong managed? Thanks, -Joe From David.Holmes at oracle.com Sat Jun 18 05:54:17 2011 From: David.Holmes at oracle.com (David Holmes) Date: Sat, 18 Jun 2011 15:54:17 +1000 Subject: Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" In-Reply-To: <4DFC0186.6060607@oracle.com> References: <4DFC0186.6060607@oracle.com> Message-ID: <4DFC3D89.4040804@oracle.com> Hi Joe, Joe Darcy said the following on 06/18/11 11:38: > Please review this (somewhat tedious) change to make the behavior of the > Number subtypes in the JDK more explicit: > > 6253144: Long narrowing conversion should describe the algorithm used > and implied "risks" > http://cr.openjdk.java.net/~darcy/6253144.0/ > > David, how are changes to AtomicInteger and AtomicLong managed? Normally they would go into Doug Lea's CVS for jsr166, we (Chris Hegarty) would pull them over and then push to OpenJDK. It can work the other way but the sync's can get messier. David > Thanks, > > -Joe From Alan.Bateman at oracle.com Sat Jun 18 19:39:20 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 18 Jun 2011 20:39:20 +0100 Subject: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out Message-ID: <4DFCFEE8.90500@oracle.com> I need a reviewer for a small fix to a test that I caught looping on my system. The test creates a server thread that emulates a non responding LDAP server. Unfortunately the thread goes into a loop reading from the connection once it is closed. I'll bet the original author only tested this on Solaris where it would have completed as intended due to now-disabled and legacy interruptible I/O support. While I was there I eliminated the hard coded port that would cause it to fail if that port were already in use. The test could be improved in other ways too but for now the webrev with the proposed changes is here: http://cr.openjdk.java.net/~alanb/7056489/webrev/ Thanks, Alan. From forax at univ-mlv.fr Sat Jun 18 21:32:12 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Sat, 18 Jun 2011 23:32:12 +0200 Subject: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out In-Reply-To: <4DFCFEE8.90500@oracle.com> References: <4DFCFEE8.90500@oracle.com> Message-ID: <4DFD195C.9060707@univ-mlv.fr> On 06/18/2011 09:39 PM, Alan Bateman wrote: > > I need a reviewer for a small fix to a test that I caught looping on > my system. The test creates a server thread that emulates a non > responding LDAP server. Unfortunately the thread goes into a loop > reading from the connection once it is closed. I'll bet the original > author only tested this on Solaris where it would have completed as > intended due to now-disabled and legacy interruptible I/O support. > While I was there I eliminated the hard coded port that would cause it > to fail if that port were already in use. The test could be improved > in other ways too but for now the webrev with the proposed changes is > here: > > http://cr.openjdk.java.net/~alanb/7056489/webrev/ > > Thanks, > Alan. Looks good. By the way, why javax.naming.Context was not retrofitted to implement AutoCloseable. cheers, R?mi From vincent.x.ryan at oracle.com Sat Jun 18 22:11:17 2011 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Sat, 18 Jun 2011 23:11:17 +0100 Subject: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out In-Reply-To: <4DFCFEE8.90500@oracle.com> References: <4DFCFEE8.90500@oracle.com> Message-ID: <4DFD2285.4000000@oracle.com> Your fix looks good. On 18/06/2011 20:39, Alan Bateman wrote: > > I need a reviewer for a small fix to a test that I caught looping on my > syst.em. The test creates a server thread that emulates a non responding > LDAP server. Unfortunately the thread goes into a loop reading from the > connection once it is closed. I'll bet the original author only tested > this on Solaris where it would have completed as intended due to > now-disabled and legacy interruptible I/O support. While I was there I > eliminated the hard coded port that would cause it to fail if that port > were already in use. The test could be improved in other ways too but > for now the webrev with the proposed changes is here: > > http://cr.openjdk.java.net/~alanb/7056489/webrev/ > > Thanks, > Alan. From Alan.Bateman at oracle.com Sun Jun 19 10:30:42 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sun, 19 Jun 2011 11:30:42 +0100 Subject: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out In-Reply-To: <4DFD195C.9060707@univ-mlv.fr> References: <4DFCFEE8.90500@oracle.com> <4DFD195C.9060707@univ-mlv.fr> Message-ID: <4DFDCFD2.7080301@oracle.com> R?mi Forax wrote: > > Looks good. > > By the way, why javax.naming.Context was not retrofitted > to implement AutoCloseable. Thanks R?mi, thanks Vinnie. I was wondering about Context too as it appears, on the surface anyway, that it could extend AutoCloseable. I believe Joe used an annotation processor to identify candidates but there may have been some reason why this one wasn't changed. -Alan. From alan.bateman at oracle.com Sun Jun 19 10:33:00 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 19 Jun 2011 10:33:00 +0000 Subject: hg: jdk8/tl/jdk: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java hangs or times out Message-ID: <20110619103331.744674713D@hg.openjdk.java.net> Changeset: b29888e74be3 Author: alanb Date: 2011-06-19 11:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b29888e74be3 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java hangs or times out Reviewed-by: forax, vinnie ! test/ProblemList.txt ! test/com/sun/jndi/ldap/ReadTimeoutTest.java From joe.darcy at oracle.com Mon Jun 20 03:17:30 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Sun, 19 Jun 2011 20:17:30 -0700 Subject: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out In-Reply-To: <4DFDCFD2.7080301@oracle.com> References: <4DFCFEE8.90500@oracle.com> <4DFD195C.9060707@univ-mlv.fr> <4DFDCFD2.7080301@oracle.com> Message-ID: <4DFEBBCA.6060005@oracle.com> Alan Bateman wrote: > R?mi Forax wrote: >> >> Looks good. >> >> By the way, why javax.naming.Context was not retrofitted >> to implement AutoCloseable. > Thanks R?mi, thanks Vinnie. > > I was wondering about Context too as it appears, on the surface > anyway, that it could extend AutoCloseable. I believe Joe used an > annotation processor to identify candidates but there may have been > some reason why this one wasn't changed. > > -Alan. Hello. I consulted my records on this type. It was found by the annotation processor. Alan suspected the use of the type didn't fit well with the try-with-resources idiom, but Vinnie was on vacation at the time and I seemed to have failed to follow-up with Vinnie afterward to confirm. Better late than never, Vinnie, do you think this type would benefit from being used in the try-with-resources statement? If so, we can retrofit it to implement AutoCloseable. Thanks, -Joe From weijun.wang at oracle.com Mon Jun 20 09:39:20 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 20 Jun 2011 09:39:20 +0000 Subject: hg: jdk8/tl/jdk: 7054428: test/java/security/SecureClassLoader/DefineClassByteBuffer.java error Message-ID: <20110620093950.06BB54716C@hg.openjdk.java.net> Changeset: 82706552f7a3 Author: weijun Date: 2011-06-20 17:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82706552f7a3 7054428: test/java/security/SecureClassLoader/DefineClassByteBuffer.java error Reviewed-by: alanb ! test/ProblemList.txt ! test/java/security/SecureClassLoader/DefineClassByteBuffer.java From Alan.Bateman at oracle.com Mon Jun 20 10:21:35 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 20 Jun 2011 11:21:35 +0100 Subject: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine Message-ID: <4DFF1F2F.7050007@oracle.com> I need a reviewer for a small update to a test that has timed out several times for me when running many tests concurrently. The problem is the specified timeout (10s) is too low unless scaled with the -timeoutFactor option. I don't see any any reason for this test to override the default timeout so the following patch removes it. -Alan diff --git a/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh b/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh --- a/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh +++ b/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh @@ -25,7 +25,7 @@ # @summary (cl) ClassLoader.loadClass locks all instances in chain # when delegating # -# @run shell/timeout=10 TestOneWayDelegate.sh +# @run shell TestOneWayDelegate.sh # if running by hand on windows, change TESTSRC and TESTCLASSES to "." if [ "${TESTSRC}" = "" ] ; then From chris.hegarty at oracle.com Mon Jun 20 10:28:54 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 20 Jun 2011 10:28:54 +0000 Subject: hg: jdk8/tl/jdk: 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence Message-ID: <20110620102904.A01764716E@hg.openjdk.java.net> Changeset: 411d02c13385 Author: dl Date: 2011-06-20 12:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/411d02c13385 7051516: ThreadLocalRandom seed is never initialized so all instances generate the same sequence Reviewed-by: chegar, dholmes, mduigou ! src/share/classes/java/util/Random.java From weijun.wang at oracle.com Mon Jun 20 11:19:02 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 20 Jun 2011 11:19:02 +0000 Subject: hg: jdk8/tl/jdk: 7054918: jdk_security1 test target cleanup Message-ID: <20110620111912.6F3BA47171@hg.openjdk.java.net> Changeset: a015dda3bdc6 Author: weijun Date: 2011-06-20 19:17 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a015dda3bdc6 7054918: jdk_security1 test target cleanup Reviewed-by: alanb, smarks, vinnie ! test/ProblemList.txt ! test/java/security/BasicPermission/PermClass.java ! test/java/security/BasicPermission/SerialVersion.java ! test/java/security/KeyFactory/Failover.java ! test/java/security/KeyPairGenerator/Failover.java ! test/java/security/Provider/ChangeProviders.java ! test/java/security/Provider/GetInstance.java ! test/java/security/Provider/RemoveProvider.java ! test/java/security/Provider/Turkish.java ! test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh ! test/java/security/Security/NoInstalledProviders.java ! test/java/security/Security/SynchronizedAccess.java ! test/java/security/Security/removing/RemoveProviders.java ! test/java/security/UnresolvedPermission/Equals.java ! test/java/security/spec/EllipticCurveMatch.java + test/java/security/testlibrary/ProvidersSnapshot.java From mandy.chung at oracle.com Mon Jun 20 12:11:39 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 20 Jun 2011 20:11:39 +0800 Subject: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine In-Reply-To: <4DFF1F2F.7050007@oracle.com> References: <4DFF1F2F.7050007@oracle.com> Message-ID: <4DFF38FB.5060704@oracle.com> Alan, The fix to remove the timeout value looks okay to me. While you're there, I wonder if the test passes on Windows with Cygwin and looks like this test might have a similar bug: 6981005: TEST BUG: java/lang/ClassLoader/TestCrossDelegate.sh timeout on windows that the cygwin path should be converted to windows path. The changeset for 6981005 is: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6586ab5b79f4 Mandy On 6/20/11 6:21 PM, Alan Bateman wrote: > > I need a reviewer for a small update to a test that has timed out > several times for me when running many tests concurrently. The problem > is the specified timeout (10s) is too low unless scaled with the > -timeoutFactor option. I don't see any any reason for this test to > override the default timeout so the following patch removes it. > > -Alan > > diff --git a/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh > b/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh > --- a/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh > +++ b/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh > @@ -25,7 +25,7 @@ > # @summary (cl) ClassLoader.loadClass locks all instances in chain > # when delegating > # > -# @run shell/timeout=10 TestOneWayDelegate.sh > +# @run shell TestOneWayDelegate.sh > > # if running by hand on windows, change TESTSRC and TESTCLASSES to "." > if [ "${TESTSRC}" = "" ] ; then > From chris.hegarty at oracle.com Mon Jun 20 12:54:33 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 20 Jun 2011 13:54:33 +0100 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently Message-ID: <4DFF4309.7070202@oracle.com> java/lang/Thread/ThreadStateTest.java can fail with when checkThreadState finds an unexpected state. Exception in thread "main" java.lang.RuntimeException: MyThread expected to have TERMINATED but got RUNNABLE at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) at ThreadStateTest.main(ThreadStateTest.java:96) There is a race between the thread being put in a specific state and the thread testing for that state. The test should retry the thread state check a number of times before failing. Also, some minor cleanup and update to use a more recent j.u.c reusable synchronization barrier. http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ -Chris. From Alan.Bateman at oracle.com Mon Jun 20 13:15:26 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 20 Jun 2011 14:15:26 +0100 Subject: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine In-Reply-To: <4DFF38FB.5060704@oracle.com> References: <4DFF1F2F.7050007@oracle.com> <4DFF38FB.5060704@oracle.com> Message-ID: <4DFF47EE.9050905@oracle.com> Mandy Chung wrote: > Alan, > > The fix to remove the timeout value looks okay to me. While you're > there, I wonder if the test passes on Windows with Cygwin and looks > like this test might have a similar bug: > 6981005: TEST BUG: java/lang/ClassLoader/TestCrossDelegate.sh > timeout on windows > > that the cygwin path should be converted to windows path. The > changeset for 6981005 is: > http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6586ab5b79f4 > > Mandy There is another bug asking that the ClassLoader tests be updated to work with cygwin: 7036526: TEST_BUG: add cygwin support to tests in test/closed/java/lang/ClassLoader I don't really have time at the moment to fix these tests and the only reason I picked on TestOneWayDelegate.sh is because I see it fail regularly when running tests concurrency in jtreg's new -agentvm mode. I don't think I've seen it fail on a system that is only running tests. So if it's okay with you, I'll fix the timeout on this test and move on. -Alan. From Alan.Bateman at oracle.com Mon Jun 20 19:31:31 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 20 Jun 2011 20:31:31 +0100 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4DFF4309.7070202@oracle.com> References: <4DFF4309.7070202@oracle.com> Message-ID: <4DFFA013.1090202@oracle.com> Chris Hegarty wrote: > java/lang/Thread/ThreadStateTest.java can fail with when > checkThreadState finds an unexpected state. > > Exception in thread "main" java.lang.RuntimeException: MyThread > expected to have TERMINATED but got RUNNABLE > at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) > at ThreadStateTest.main(ThreadStateTest.java:96) > > There is a race between the thread being put in a specific state and > the thread testing for that state. The test should retry the thread > state check a number of times before failing. Also, some minor cleanup > and update to use a more recent j.u.c reusable synchronization barrier. > > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ > > -Chris. The retry loop in checkThreadState make sense. Is the 100ms sleep a bit excessive? The thread will likely get to the expected state in a fraction of that time. One question on the TERMINATED state. Given that the check is now moved to after the join then could this be a simple getState check rather than using checkThreadState? The clean-up to use Phaser looks good to me. -Alan. From lana.steuck at oracle.com Mon Jun 20 21:56:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:56:21 +0000 Subject: hg: jdk7/tl: Added tag jdk7-b145 for changeset 55e9ebf03218 Message-ID: <20110620215622.1FE224718B@hg.openjdk.java.net> Changeset: 2d38c2a79c14 Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/2d38c2a79c14 Added tag jdk7-b145 for changeset 55e9ebf03218 ! .hgtags From lana.steuck at oracle.com Mon Jun 20 21:56:27 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:56:27 +0000 Subject: hg: jdk7/tl/corba: Added tag jdk7-b145 for changeset 77ec0541aa2a Message-ID: <20110620215628.B977D4718C@hg.openjdk.java.net> Changeset: 770227a4087e Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/770227a4087e Added tag jdk7-b145 for changeset 77ec0541aa2a ! .hgtags From lana.steuck at oracle.com Mon Jun 20 21:56:40 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:56:40 +0000 Subject: hg: jdk7/tl/jaxws: 11 new changesets Message-ID: <20110620215640.F3DDC4718D@hg.openjdk.java.net> Changeset: 6ec12c60ad13 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/6ec12c60ad13 Added tag jdk7-b145 for changeset 42bfba80beb7 ! .hgtags Changeset: 581dab3f0773 Author: asaha Date: 2011-04-21 16:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/581dab3f0773 Merge Changeset: 26610bb80151 Author: asaha Date: 2011-05-04 12:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/26610bb80151 Merge Changeset: c6ff860428c7 Author: asaha Date: 2011-05-05 22:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/c6ff860428c7 Merge Changeset: f4e1caef46d0 Author: asaha Date: 2011-05-24 11:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/f4e1caef46d0 Merge Changeset: 9896cee00786 Author: asaha Date: 2011-05-26 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/9896cee00786 Merge Changeset: d1febdcb0351 Author: asaha Date: 2011-05-26 21:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d1febdcb0351 Merge Changeset: 239c80c331da Author: asaha Date: 2011-06-06 10:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/239c80c331da Merge Changeset: 09412171ca4b Author: asaha Date: 2011-06-03 07:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/09412171ca4b Merge Changeset: 9d8fd0982fb8 Author: asaha Date: 2011-06-06 10:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/9d8fd0982fb8 Merge Changeset: 05469dd4c366 Author: lana Date: 2011-06-15 16:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/05469dd4c366 Merge From lana.steuck at oracle.com Mon Jun 20 21:56:45 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:56:45 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b145 for changeset 10ca7570f47f Message-ID: <20110620215645.0C0404718E@hg.openjdk.java.net> Changeset: bcd31fa1e3c6 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bcd31fa1e3c6 Added tag jdk7-b145 for changeset 10ca7570f47f ! .hgtags From lana.steuck at oracle.com Mon Jun 20 21:56:54 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:56:54 +0000 Subject: hg: jdk7/tl/langtools: 15 new changesets Message-ID: <20110620215727.4C4C94718F@hg.openjdk.java.net> Changeset: 9ff91d0e7154 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9ff91d0e7154 Added tag jdk7-b145 for changeset c455e2ae5c93 ! .hgtags Changeset: b8a2c9c87018 Author: lana Date: 2011-06-10 11:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b8a2c9c87018 Merge Changeset: 588d366d96df Author: asaha Date: 2011-04-21 16:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/588d366d96df Merge Changeset: 219b522d09e4 Author: asaha Date: 2011-05-04 12:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/219b522d09e4 Merge Changeset: 145d832616d3 Author: asaha Date: 2011-05-05 22:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/145d832616d3 Merge Changeset: 8b6e015ae7d0 Author: asaha Date: 2011-05-24 11:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8b6e015ae7d0 Merge - test/tools/javac/generics/diamond/7030150/Neg01.java - test/tools/javac/generics/diamond/7030150/Neg01.out - test/tools/javac/generics/diamond/7030150/Neg02.java - test/tools/javac/generics/diamond/7030150/Neg02.out - test/tools/javac/generics/diamond/7030150/Neg03.java - test/tools/javac/generics/diamond/7030150/Neg03.out - test/tools/javac/generics/diamond/7030150/Pos01.java - test/tools/javac/generics/diamond/7030150/Pos02.java Changeset: 35cc19ae29b5 Author: asaha Date: 2011-05-26 17:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/35cc19ae29b5 Merge Changeset: 8b65930602c3 Author: asaha Date: 2011-05-26 21:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8b65930602c3 Merge Changeset: 0adb806caf9d Author: asaha Date: 2011-06-06 10:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0adb806caf9d Merge Changeset: bb1fdcebde01 Author: asaha Date: 2011-06-03 07:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/bb1fdcebde01 Merge Changeset: 8ed03b0e3c9c Author: asaha Date: 2011-06-06 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/8ed03b0e3c9c Merge Changeset: f494ca4bca0d Author: lana Date: 2011-06-15 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f494ca4bca0d Merge Changeset: 7eba9df190ae Author: bpatel Date: 2011-06-17 20:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7eba9df190ae 7052425: Change the look and feel of the javadoc generate HTML pages using stylesheet Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/background.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/tab.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar_end.gif ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: c3a3440fe6e8 Author: bpatel Date: 2011-06-17 20:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c3a3440fe6e8 Merge Changeset: 9425dd4f53d5 Author: schien Date: 2011-06-18 09:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9425dd4f53d5 Merge From lana.steuck at oracle.com Mon Jun 20 21:57:16 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:57:16 +0000 Subject: hg: jdk7/tl/hotspot: 42 new changesets Message-ID: <20110620215834.D28B147190@hg.openjdk.java.net> Changeset: 9340a27154cb Author: kvn Date: 2011-05-25 21:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9340a27154cb 7048332: Cadd_cmpLTMask doesn't handle 64-bit tmp register properly Summary: Use ins_encode %{ %} form to encode cadd_cmpLTMask() instruction and remove unused code. Reviewed-by: never ! src/cpu/x86/vm/x86_64.ad + test/compiler/7048332/Test7048332.java Changeset: ea0da5474c23 Author: kvn Date: 2011-05-27 12:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ea0da5474c23 7047069: Array can dynamically change size when assigned to an object field Summary: Fix initialization of a newly-allocated array with arraycopy Reviewed-by: never ! src/share/vm/opto/library_call.cpp + test/compiler/7047069/Test7047069.java Changeset: 88559690c95a Author: never Date: 2011-05-26 14:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/88559690c95a 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly Reviewed-by: kvn, jrose ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: 442ef93966a9 Author: iveresov Date: 2011-05-26 13:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/442ef93966a9 7047491: C1: registers saved incorrectly when calling checkcast_arraycopy stub Summary: Save and restore the argument registers around the call to checkcast_arraycopy Reviewed-by: never, roland ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 3f7a95be91ef Author: iveresov Date: 2011-06-01 12:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3f7a95be91ef Merge Changeset: 7c907a50c1bb Author: iveresov Date: 2011-06-01 14:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7c907a50c1bb Merge Changeset: f88fb2fa90cf Author: kvn Date: 2011-05-31 10:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f88fb2fa90cf 6956668: misbehavior of XOR operator (^) with int Summary: optimize cmp_ne(xor(X,1),0) to cmp_eq(X,0) only for boolean values X. Reviewed-by: never ! src/share/vm/opto/subnode.cpp + test/compiler/6956668/Test6956668.java Changeset: ba550512d3b2 Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ba550512d3b2 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Delegate invokedynamic linkage errors to MethodHandleNatives.raiseException. Reviewed-by: never ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: c76d5f44a3fe Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c76d5f44a3fe 7049410: JSR 292 old method name MethodHandle.invokeGeneric should not be accepted by the JVM Summary: change the default setting of the flag AllowInvokeGeneric to false Reviewed-by: never ! src/share/vm/runtime/globals.hpp Changeset: deaa3ce90583 Author: coleenp Date: 2011-06-02 14:17 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/deaa3ce90583 7049928: VM crashes with "assert(_adapter != NULL) failed: must have" at methodOop.cpp:63 Summary: Removed extra change from another bug fix that caused this regression Reviewed-by: phh, dcubed, kvn, kamg, never ! src/share/vm/oops/methodOop.cpp Changeset: e5ae807761b8 Author: trims Date: 2011-06-03 17:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e5ae807761b8 Added tag hs21-b14 for changeset 62f39d40ebf1 ! .hgtags Changeset: 82a81d5c5700 Author: trims Date: 2011-06-03 20:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/82a81d5c5700 Merge Changeset: 48ceeec759b6 Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/48ceeec759b6 Added tag jdk7-b145 for changeset 82a81d5c5700 ! .hgtags Changeset: 12537a93a848 Author: asaha Date: 2011-04-08 21:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/12537a93a848 Merge Changeset: 540930dc854d Author: kamg Date: 2011-04-12 16:42 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/540930dc854d 7020373: JSR rewriting can overflow memory address size variables Summary: Abort if incoming classfile's parameters would cause overflows Reviewed-by: coleenp, dcubed, never ! src/share/vm/oops/generateOopMap.cpp + test/runtime/7020373/Test7020373.sh + test/runtime/7020373/testcase.jar Changeset: f0914807c671 Author: asaha Date: 2011-04-20 07:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f0914807c671 Merge Changeset: bad27cd3f646 Author: asaha Date: 2011-04-21 08:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bad27cd3f646 Merge Changeset: 5e00ed79c8bb Author: asaha Date: 2011-04-21 16:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5e00ed79c8bb Merge Changeset: c97b08c7d72a Author: asaha Date: 2011-04-21 22:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c97b08c7d72a Merge Changeset: 5def270bc147 Author: zgu Date: 2011-04-15 09:34 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5def270bc147 7016797: Hotspot: securely/restrictive load dlls and new API for loading system dlls Summary: Created Windows Dll wrapped to handle jdk6 and jdk7 platform requirements, also provided more restictive Dll search orders for Windows system Dlls. Reviewed-by: acorn, dcubed, ohair, alanb ! make/windows/makefiles/compile.make ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp Changeset: 089aee76df10 Author: asaha Date: 2011-05-04 16:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/089aee76df10 Merge ! src/os/windows/vm/os_windows.cpp Changeset: ba2db55ddf8b Author: asaha Date: 2011-05-05 22:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ba2db55ddf8b Merge - make/linux/makefiles/cscope.make - make/solaris/makefiles/cscope.make Changeset: 66c17ec20ee2 Author: asaha Date: 2011-05-06 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/66c17ec20ee2 Merge Changeset: 7c948af3e651 Author: asaha Date: 2011-05-24 11:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7c948af3e651 Merge ! src/os/windows/vm/os_windows.cpp Changeset: ec7055a259a6 Author: asaha Date: 2011-05-26 17:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ec7055a259a6 Merge Changeset: 8d5208b557b3 Author: asaha Date: 2011-05-26 21:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8d5208b557b3 Merge Changeset: 7bf54248da9f Author: asaha Date: 2011-06-06 10:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7bf54248da9f Merge Changeset: a983caeb2b3e Author: asaha Date: 2011-06-03 07:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a983caeb2b3e Merge Changeset: 0e9653efc6ea Author: asaha Date: 2011-06-06 10:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0e9653efc6ea Merge Changeset: a884a8b0ec6d Author: asaha Date: 2011-06-15 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a884a8b0ec6d 7055247: Ignore test of # 7020373 Reviewed-by: dcubed ! test/runtime/7020373/Test7020373.sh Changeset: 9d7c66d9a203 Author: lana Date: 2011-06-15 16:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9d7c66d9a203 Merge Changeset: f56542cb325a Author: never Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f56542cb325a 7050554: JSR 292 - need optimization for selectAlternative Reviewed-by: kvn, jrose ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: f7d55ea6ee56 Author: never Date: 2011-06-03 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f7d55ea6ee56 7045514: SPARC assembly code for JSR 292 ricochet frames Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp + src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/sparc/vm/registerMap_sparc.hpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 293f68bda347 Author: kvn Date: 2011-06-04 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/293f68bda347 7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity Summary: Mark all associated (same box and obj) lock and unlock nodes for elimination if some of them marked already. Reviewed-by: iveresov, never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp Changeset: 14d3cdeabc9f Author: trims Date: 2011-06-07 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/14d3cdeabc9f Added tag hs21-b15 for changeset 82a81d5c5700 ! .hgtags Changeset: 67c0f5f5deac Author: trims Date: 2011-06-07 16:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/67c0f5f5deac Merge Changeset: 07c2e7ffd1fc Author: jrose Date: 2011-06-08 17:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/07c2e7ffd1fc 7047697: MethodHandle.invokeExact call for wrong method causes VM failure if run with -Xcomp Reviewed-by: never, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/code/pcDesc.cpp Changeset: 15e7628f9e92 Author: trims Date: 2011-06-16 19:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/15e7628f9e92 Merge Changeset: fc043ce2136c Author: trims Date: 2011-06-16 19:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fc043ce2136c 7055788: Bump the HS21 build number to 16 Summary: Update the HS21 build number to 16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: a9b8b43b115f Author: never Date: 2011-06-14 14:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a9b8b43b115f 7052219: JSR 292: Crash in ~BufferBlob::MethodHandles adapters Reviewed-by: twisti, kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp Changeset: 3275a6560cf7 Author: twisti Date: 2011-06-14 12:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3275a6560cf7 7053520: JSR292: crash in invokedynamic with C1 using tiered and compressed oops Reviewed-by: iveresov, never ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: 38fa55e5e792 Author: never Date: 2011-06-16 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/38fa55e5e792 7055355: JSR 292: crash while throwing WrongMethodTypeException Reviewed-by: jrose, twisti, bdelsart ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp From lana.steuck at oracle.com Mon Jun 20 21:59:22 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 20 Jun 2011 21:59:22 +0000 Subject: hg: jdk7/tl/jdk: 52 new changesets Message-ID: <20110620220803.CCB6947192@hg.openjdk.java.net> Changeset: 8318d03e1766 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8318d03e1766 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Wrap invokedynamic linkage errors in BootstrapMethodError, as needed. Reviewed-by: never ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 0b8b6eace473 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b8b6eace473 7050328: (jsr-292) findConstructor throws ExceptionInInitializerError if run under SecurityManager Summary: Wrap system property and reflection accesses under doPrivileged. Ensure constant pool linkage bypasses the SM as specified. Reviewed-by: kvn, never ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java Changeset: 34481a4012c3 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/34481a4012c3 7049122: java/lang/invoke/RicochetTest.java with MAX_ARITY=255 in -Xcomp mode overflows code cache Summary: reduce the scope of the unit test (mark high water mark of testing with @ignore tags) Reviewed-by: never ! test/java/lang/invoke/RicochetTest.java Changeset: 802994506203 Author: jrose Date: 2011-06-03 11:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/802994506203 7051206: JSR 292 method name SwitchPoint.isValid is misleading to unwary users; should be hasBeenInvalidated Reviewed-by: kvn, never, ysr ! src/share/classes/java/lang/invoke/SwitchPoint.java ! test/java/lang/invoke/JavaDocExamplesTest.java Changeset: e8e6cdff5995 Author: trims Date: 2011-06-03 20:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8e6cdff5995 Merge Changeset: 8f19b165347b Author: bae Date: 2011-06-04 23:08 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8f19b165347b 7042594: 3 testis api/java_awt/Color/ICC_ProfileRGB/index.html fail against RI b138 OEL6x64. Reviewed-by: prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! test/sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java + test/sun/java2d/cmm/ProfileOp/SetDataTest.java Changeset: bbb4cef2208b Author: lana Date: 2011-06-04 17:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbb4cef2208b Merge Changeset: 03a828e368ca Author: rupashka Date: 2011-06-04 01:13 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03a828e368ca 6977587: GTK L&F: jnlp: java.io.IOException thrown when choosing more than 1 file in the dialog Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java Changeset: 6c9c55ae313b Author: lana Date: 2011-06-03 22:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c9c55ae313b Merge Changeset: e81d259442ed Author: lana Date: 2011-06-04 17:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e81d259442ed Merge Changeset: 1e04b38b3824 Author: lana Date: 2011-06-04 17:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1e04b38b3824 Merge Changeset: 7a341c412ea9 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7a341c412ea9 Added tag jdk7-b145 for changeset 1e04b38b3824 ! .hgtags Changeset: ae731399e525 Author: dav Date: 2011-06-07 22:58 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae731399e525 7048568: Crash in Java_sun_awt_Win32GraphicsEnvironment_isVistaOS Reviewed-by: dcherepanov, art, amenkov ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: f08fcae94813 Author: lana Date: 2011-06-10 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f08fcae94813 Merge Changeset: 646ab254ff80 Author: lana Date: 2011-06-10 11:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/646ab254ff80 Merge Changeset: aca0dc2b921c Author: weijun Date: 2011-02-09 11:50 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aca0dc2b921c 6618658: Deserialization allows creation of mutable SignedObject Reviewed-by: hawtin, mullan ! src/share/classes/java/security/SignedObject.java + test/java/security/SignedObject/Correctness.java Changeset: df445f522425 Author: bae Date: 2011-02-17 12:21 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df445f522425 7013519: [parfait] Integer overflows in 2D code Reviewed-by: prr, valeriep ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/font/layout/SunLayoutEngine.cpp Changeset: ccb2fcfb6d6b Author: chegar Date: 2011-02-18 13:31 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ccb2fcfb6d6b 7013969: NetworkInterface.toString can reveal bindings Reviewed-by: alanb, michaelm, hawtin ! src/share/classes/java/net/NetworkInterface.java Changeset: 026adaac71f1 Author: dcherepanov Date: 2011-02-25 15:54 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/026adaac71f1 7012520: Heap overflow vulnerability in FileDialog.show() Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_FileDialog.cpp Changeset: d489f00d6c65 Author: flar Date: 2011-03-02 05:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d489f00d6c65 7016495: Crash in Java 2D transforming an image with scale close to zero Reviewed-by: prr, bae ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/native/sun/java2d/loops/TransformHelper.c + test/java/awt/image/BufferedImage/TinyScale.java Changeset: fe27fe44ac51 Author: ksrini Date: 2011-03-03 14:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe27fe44ac51 7016985: (launcher) implement safe secure dll loading Reviewed-by: mchung ! src/windows/bin/java_md.c Changeset: 0efa64f13302 Author: chegar Date: 2011-04-05 14:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0efa64f13302 7033865: JDK: Add private API for secure/restrictive loading of system dlls Reviewed-by: alanb ! src/share/native/common/jdk_util.h + src/solaris/native/common/jdk_util_md.h ! src/windows/native/common/jdk_util_md.c + src/windows/native/common/jdk_util_md.h Changeset: 67992a58bfba Author: ksrini Date: 2011-04-05 16:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67992a58bfba 7032593: DLL_LOADING: Upgrade solution to 7016985 to reflect JDK7 solution Reviewed-by: mchung, asaha ! src/windows/bin/java_md.c Changeset: 7181441faf72 Author: dcherepanov Date: 2011-04-08 16:44 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7181441faf72 7003962: AWT: securely load DLLs and launch executables using fully qualified path Reviewed-by: art, bae, alanb ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/java2d/opengl/OGLFuncs_md.h ! src/windows/native/sun/windows/DllUtil.cpp ! src/windows/native/sun/windows/DllUtil.h ! src/windows/native/sun/windows/ShellFolder2.cpp ! src/windows/native/sun/windows/ThemeReader.cpp ! src/windows/native/sun/windows/awt_Mlib.cpp ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/stdhdrs.h Changeset: 05a3923f516f Author: dcherepanov Date: 2011-04-08 17:58 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05a3923f516f 7035077: Minor addition to the changes for 7003962 Reviewed-by: chegar ! src/windows/native/sun/windows/DllUtil.cpp Changeset: afcc1530e68b Author: asaha Date: 2011-04-08 10:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/afcc1530e68b Merge - make/java/dyn/Makefile - src/share/classes/java/dyn/CallSite.java - src/share/classes/java/dyn/ClassValue.java - src/share/classes/java/dyn/ConstantCallSite.java - src/share/classes/java/dyn/InvokeDynamic.java - src/share/classes/java/dyn/InvokeDynamicBootstrapError.java - src/share/classes/java/dyn/Linkage.java - src/share/classes/java/dyn/MethodHandle.java - src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/MethodType.java - src/share/classes/java/dyn/MethodTypeForm.java - src/share/classes/java/dyn/MutableCallSite.java - src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/VolatileCallSite.java - src/share/classes/java/dyn/WrongMethodTypeException.java - src/share/classes/java/dyn/package-info.java - src/share/classes/sun/dyn/Access.java - src/share/classes/sun/dyn/AdapterMethodHandle.java - src/share/classes/sun/dyn/BoundMethodHandle.java - src/share/classes/sun/dyn/CallSiteImpl.java - src/share/classes/sun/dyn/DirectMethodHandle.java - src/share/classes/sun/dyn/FilterGeneric.java - src/share/classes/sun/dyn/FilterOneArgument.java - src/share/classes/sun/dyn/FromGeneric.java - src/share/classes/sun/dyn/InvokeGeneric.java - src/share/classes/sun/dyn/Invokers.java - src/share/classes/sun/dyn/MemberName.java - src/share/classes/sun/dyn/MethodHandleImpl.java - src/share/classes/sun/dyn/MethodHandleNatives.java - src/share/classes/sun/dyn/MethodTypeImpl.java - src/share/classes/sun/dyn/SpreadGeneric.java - src/share/classes/sun/dyn/ToGeneric.java - src/share/classes/sun/dyn/WrapperInstance.java - src/share/classes/sun/dyn/anon/AnonymousClassLoader.java - src/share/classes/sun/dyn/anon/ConstantPoolParser.java - src/share/classes/sun/dyn/anon/ConstantPoolPatch.java - src/share/classes/sun/dyn/anon/ConstantPoolVisitor.java - src/share/classes/sun/dyn/anon/InvalidConstantPoolFormatException.java - src/share/classes/sun/dyn/empty/Empty.java - src/share/classes/sun/dyn/package-info.java - src/share/classes/sun/dyn/util/BytecodeDescriptor.java - src/share/classes/sun/dyn/util/BytecodeName.java - src/share/classes/sun/dyn/util/ValueConversions.java - src/share/classes/sun/dyn/util/VerifyAccess.java - src/share/classes/sun/dyn/util/VerifyType.java - src/share/classes/sun/dyn/util/Wrapper.java - src/share/classes/sun/dyn/util/package-info.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c - test/java/dyn/ClassValueTest.java - test/java/dyn/InvokeDynamicPrintArgs.java - test/java/dyn/InvokeGenericTest.java - test/java/dyn/JavaDocExamplesTest.java - test/java/dyn/MethodHandlesTest.java - test/java/dyn/MethodTypeTest.java - test/java/dyn/indify/Indify.java Changeset: 557bd9b5d92f Author: asaha Date: 2011-04-08 10:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/557bd9b5d92f Merge Changeset: e142148d8b54 Author: asaha Date: 2011-04-12 14:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e142148d8b54 Merge - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java Changeset: 76e0e562b617 Author: dcherepanov Date: 2011-04-15 17:06 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76e0e562b617 7036952: build warning after the changes for 7003962 Reviewed-by: art, bae ! src/windows/native/sun/java2d/opengl/OGLFuncs_md.h Changeset: f8eddc85cc02 Author: zgu Date: 2011-04-15 09:53 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8eddc85cc02 7003964: SERV: securely load DLLs and launch executables using fully qualified path Summary: Linked in Windows libraries that are available on jdk7 supported platforms, and used GetModuleHandle instead of LoadLibrary for already loaded Dlls. Reviewed-by: dcubed, alanb ! make/com/sun/tools/attach/Makefile ! src/windows/classes/sun/tools/attach/WindowsAttachProvider.java ! src/windows/native/sun/tools/attach/WindowsAttachProvider.c ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c ! src/windows/native/sun/tracing/dtrace/jvm_symbols_md.c ! src/windows/npt/npt_md.h Changeset: 0865aa0ad9b2 Author: zgu Date: 2011-04-19 10:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0865aa0ad9b2 Merge Changeset: 6f8a4d334fb2 Author: asaha Date: 2011-04-20 09:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6f8a4d334fb2 Merge ! make/com/sun/tools/attach/Makefile ! src/share/classes/java/net/NetworkInterface.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/windows/bin/java_md.c ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp Changeset: f3645b5d6e62 Author: asaha Date: 2011-04-20 21:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3645b5d6e62 Merge Changeset: b626f78c57e1 Author: asaha Date: 2011-04-21 08:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b626f78c57e1 Merge Changeset: cec45f3353be Author: asaha Date: 2011-04-21 08:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cec45f3353be Merge Changeset: 6133c9ee3a01 Author: asaha Date: 2011-04-21 08:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6133c9ee3a01 Merge Changeset: dd06e8d3da91 Author: asaha Date: 2011-04-21 15:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dd06e8d3da91 Merge Changeset: b2295905901a Author: asaha Date: 2011-04-21 16:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b2295905901a Merge - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java Changeset: 3fedf261fb4f Author: valeriep Date: 2011-04-26 15:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fedf261fb4f 7003952: SEC: securely load DLLs and launch executables using fully qualified path Summary: Enforce full path when specifying library locations. Reviewed-by: wetmore, ohair ! make/sun/security/pkcs11/Makefile ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/native/sun/security/pkcs11/j2secmod.c + test/sun/security/pkcs11/Provider/Absolute.cfg + test/sun/security/pkcs11/Provider/Absolute.java Changeset: 94ea3b8288f1 Author: alexp Date: 2011-05-04 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94ea3b8288f1 7020198: ImageIcon creates Component with null acc Reviewed-by: rupashka, hawtin ! src/share/classes/javax/swing/ImageIcon.java Changeset: e6fdfb249e31 Author: asaha Date: 2011-05-04 16:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6fdfb249e31 Merge - src/share/native/sun/font/layout/Features.h ! src/windows/native/sun/windows/awt_FileDialog.cpp - test/javax/swing/text/GlyphView/6539700/bug6539700.java Changeset: 49244980d692 Author: asaha Date: 2011-05-05 22:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/49244980d692 Merge - src/share/classes/sun/security/util/SignatureFileManifest.java Changeset: 647b031200f0 Author: asaha Date: 2011-05-06 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/647b031200f0 Merge Changeset: 92b5197e9ff5 Author: asaha Date: 2011-05-26 21:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92b5197e9ff5 Merge ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp Changeset: cca9ea306c6e Author: asaha Date: 2011-05-26 21:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cca9ea306c6e Merge Changeset: dab3e66ebda7 Author: lana Date: 2011-06-06 19:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dab3e66ebda7 Merge Changeset: 9f17be5136d1 Author: wetmore Date: 2011-06-09 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f17be5136d1 7052537: java/security/Security/NotInstalledProviders.java is causing -samevm tests to fail. Reviewed-by: valeriep, asaha, alanb ! test/java/security/Security/NoInstalledProviders.java Changeset: 4961be00d3b5 Author: lana Date: 2011-06-15 16:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4961be00d3b5 Merge Changeset: cf0632d2db2c Author: jrose Date: 2011-06-14 22:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cf0632d2db2c 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray Summary: Fix corner cases involving MethodHandles.permuteArguments with long or double argument lists. Reviewed-by: twisti, never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/SwitchPoint.java + test/java/lang/invoke/PermuteArgsTest.java Changeset: a65fa0f6717e Author: trims Date: 2011-06-17 16:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a65fa0f6717e Merge Changeset: c102e1221afa Author: lana Date: 2011-06-17 10:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c102e1221afa Merge Changeset: 539e576793a8 Author: lana Date: 2011-06-18 10:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/539e576793a8 Merge From joe.darcy at oracle.com Tue Jun 21 00:21:09 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 21 Jun 2011 00:21:09 +0000 Subject: hg: jdk8/tl/jdk: 7055295: (reflect) add conventional constructor to GenericSignatureFormatError Message-ID: <20110621002131.4BCCA471A5@hg.openjdk.java.net> Changeset: 3c8f939ced1c Author: darcy Date: 2011-06-20 17:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c8f939ced1c 7055295: (reflect) add conventional constructor to GenericSignatureFormatError Reviewed-by: lancea, mduigou ! src/share/classes/java/lang/reflect/GenericSignatureFormatError.java From mandy.chung at oracle.com Tue Jun 21 01:34:09 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 21 Jun 2011 09:34:09 +0800 Subject: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine In-Reply-To: <4DFF47EE.9050905@oracle.com> References: <4DFF1F2F.7050007@oracle.com> <4DFF38FB.5060704@oracle.com> <4DFF47EE.9050905@oracle.com> Message-ID: <4DFFF511.2090400@oracle.com> On 6/20/11 9:15 PM, Alan Bateman wrote: > There is another bug asking that the ClassLoader tests be updated to > work with cygwin: > > 7036526: TEST_BUG: add cygwin support to tests in > test/closed/java/lang/ClassLoader > > I don't really have time at the moment to fix these tests and the only > reason I picked on TestOneWayDelegate.sh is because I see it fail > regularly when running tests concurrency in jtreg's new -agentvm mode. > I don't think I've seen it fail on a system that is only running > tests. So if it's okay with you, I'll fix the timeout on this test and > move on. > I'm fine with your timeout fix and have 7036526 to fix the cygwin path issue. Mandy From David.Holmes at oracle.com Tue Jun 21 02:05:00 2011 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 21 Jun 2011 12:05:00 +1000 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4DFF4309.7070202@oracle.com> References: <4DFF4309.7070202@oracle.com> Message-ID: <4DFFFC4C.500@oracle.com> Hi Chris, Chris Hegarty said the following on 06/20/11 22:54: > java/lang/Thread/ThreadStateTest.java can fail with when > checkThreadState finds an unexpected state. > > Exception in thread "main" java.lang.RuntimeException: MyThread expected > to have TERMINATED but got RUNNABLE > at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) > at ThreadStateTest.main(ThreadStateTest.java:96) > > There is a race between the thread being put in a specific state and the > thread testing for that state. The test should retry the thread state > check a number of times before failing. Also, some minor cleanup and > update to use a more recent j.u.c reusable synchronization barrier. > > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ I'm not sure the extra check in checkThreadState that the thread must be RUNNABLE is valid. What if you are transitioning the thread from a blocked to non-blocked state, you may still see it blocked on the first call to getState. I also don't understand why you moved the terminated check to after the join() - if the thread is failing to terminate then the join(), which is untimed, will simply not return and the test will hang until timed-out by the harness. I also don't think the use of the Phaser is appropriate here as you are actually delaying the thread from making the state change. In the original code the target thread signals the main thread that it is about to go to state X and continues to advance to state X (modulo preemption etc). But with the Phaser the target thread indicates it is about to go to state X and then waits for the main thread - consequently it is more likely that when the main thread calls checkThreadState that the target has not yet reached the desired state and so the main thread will have to loop. This isn't incorrect it just seems to me that in the "wrong" configuration the test may not take a lot longer in relative terms. Maybe the additional clarity is worth it though ... Cheers, David From vincent.x.ryan at oracle.com Tue Jun 21 08:34:52 2011 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 21 Jun 2011 09:34:52 +0100 Subject: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out In-Reply-To: <4DFFCCE7.3070002@oracle.com> References: <4DFCFEE8.90500@oracle.com> <4DFD195C.9060707@univ-mlv.fr> <4DFDCFD2.7080301@oracle.com> <4DFF40D5.2030909@oracle.com> <4DFF4415.2030908@oracle.com> <4DFF5C15.7060707@oracle.com> <4DFF6261.1090705@oracle.com> <4DFFAAA6.5020204@oracle.com> <4DFFCCE7.3070002@oracle.com> Message-ID: <4E0057AC.9060304@oracle.com> Apologies for overlooking the core-libs audience. On 06/20/11 23:42, Joe Darcy wrote: > Vincent Ryan wrote: >> On 06/20/11 16:08, Alan Bateman wrote: >> >>> Vincent Ryan wrote: >>> >>>> : >>>> Thanks Alan. JNDI applications are encouraged to call close() rather >>>> than >>>> rely on GC to free resources. >>>> >>>> I guess we can support both behaviours: long-lived JNDI applications >>>> can >>>> continue to use try blocks and explicitly call close(), when finished. >>>> Short-lived JNDI applications can use try-with-resources blocks and >>>> benefit >>>> from the automatic resource management. >>>> >>>> It really is just a 1-line change: >>>> >>>> marino% diff old/javax/naming/Context.java >>>> new/javax/naming/Context.java >>>> 281c281 >>>> < public interface Context { >>>> --- >>>> > public interface Context extends AutoCloseable { >>>> marino% >>>> >>> That's all it should be. Even where try/finally it used today there is >>> still the possibility of close failing and supplanting a more >>> interesting exception. Overall it sounds like this is worth doing. >>> >>> -Alan. >>> >> >> Right. I've filed an RFE and targeted it to jdk8. >> http://monaco.us.oracle.com/detail.jsf?cr=7057061 >> >> FYI NamingEnumeration also supports a close() method to explicitly >> release >> resources, for example when discarding the remainder of a search result. >> Under normal circumstances, the final iteration of NamingEnumeration will >> cause its resources to be released automatically. So close() is only used >> when exiting an iteration prematurely. >> >> I don't think NamingEnumeration is a suitable candidate for >> try-with-resources >> because the common case is to complete the iteration and _not_ to call >> close(). >> > Hello. > > Vinnie, please reply about this rfe and your assessment of it to the > core-libs list. > > Thanks, > > -Joe > From mandy.chung at oracle.com Tue Jun 21 10:08:27 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 21 Jun 2011 18:08:27 +0800 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4DFF4309.7070202@oracle.com> References: <4DFF4309.7070202@oracle.com> Message-ID: <4E006D9B.6020409@oracle.com> Hi Chris, On 6/20/11 8:54 PM, Chris Hegarty wrote: > java/lang/Thread/ThreadStateTest.java can fail with when > checkThreadState finds an unexpected state. > > Exception in thread "main" java.lang.RuntimeException: MyThread > expected to have TERMINATED but got RUNNABLE > at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) > at ThreadStateTest.main(ThreadStateTest.java:96) > > There is a race between the thread being put in a specific state and > the thread testing for that state. The test should retry the thread > state check a number of times before failing. Also, some minor cleanup > and update to use a more recent j.u.c reusable synchronization barrier. > > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ L130-116: I agree with David that this test is not needed. Like the RuntimeException listed in ProblemList.txt shows that the target thread is in WAITING state but expected to be RUNNABLE. L98: Are you seeing some timing issue if you keep this checkThreadState before the join and thus you moved it after the join? As to David's comment about the use of Phaser that delays the thread from making the state change. The test was modified to use ThreadExecutionSynchronizer as a fix to: 5039275 ThreadBlockedCount jtreg test fails on Solaris sparc on service_sdk nightly ThreadExecutionSynchronizer.signal() actually awaits until the main thread calls waitForSignal. If I understand correctly, it's essentially doing the same thing as Phaser.arriveAndAwaitAdvance(). So Chris' change to use Phaser only follows the existing code. I thinkThreadExecutionSynchronizer was initially created to fix ThreadBlockCount testthat can make sure the thread enters the BLOCKED state an exact number of times and applied to other tests as it yields tighter timing window but might not be necessary. Anyway, like David said, it isn't incorrect. If you don't have time to eliminate the need of the main thread to loop, I'm fine with the change to use Phaser but worths tuning the sleep time in L117. Thanks Mandy From David.Holmes at oracle.com Tue Jun 21 10:49:22 2011 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 21 Jun 2011 20:49:22 +1000 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E006D9B.6020409@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E006D9B.6020409@oracle.com> Message-ID: <4E007732.9010501@oracle.com> Mandy Chung said the following on 06/21/11 20:08: > On 6/20/11 8:54 PM, Chris Hegarty wrote: >> java/lang/Thread/ThreadStateTest.java can fail with when >> checkThreadState finds an unexpected state. >> >> Exception in thread "main" java.lang.RuntimeException: MyThread >> expected to have TERMINATED but got RUNNABLE >> at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) >> at ThreadStateTest.main(ThreadStateTest.java:96) >> >> There is a race between the thread being put in a specific state and >> the thread testing for that state. The test should retry the thread >> state check a number of times before failing. Also, some minor cleanup >> and update to use a more recent j.u.c reusable synchronization barrier. >> >> http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ > > L130-116: I agree with David that this test is not needed. > Like the RuntimeException listed in ProblemList.txt shows > that the target thread is in WAITING state but expected to > be RUNNABLE. > > L98: Are you seeing some timing issue if you keep this checkThreadState > before the join and thus you moved it after the join? > > As to David's comment about the use of Phaser that delays the thread > from making the state change. The test was modified to use > ThreadExecutionSynchronizer as a fix to: > 5039275 ThreadBlockedCount jtreg test fails on Solaris sparc on > service_sdk nightly > > ThreadExecutionSynchronizer.signal() actually awaits until the > main thread calls waitForSignal. If I understand correctly, it's > essentially doing the same thing as Phaser.arriveAndAwaitAdvance(). > So Chris' change to use Phaser only follows the existing code. Thanks Mandy I missed that detail. David ----- > I thinkThreadExecutionSynchronizer was initially created to fix > ThreadBlockCount testthat can make sure the thread enters the BLOCKED > state an exact number of times and applied to other tests as it > yields tighter timing window but might not be necessary. > > Anyway, like David said, it isn't incorrect. If you don't have > time to eliminate the need of the main thread to loop, I'm fine > with the change to use Phaser but worths tuning the sleep time in L117. > > Thanks > Mandy > > > > > From chris.hegarty at oracle.com Tue Jun 21 11:12:39 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 21 Jun 2011 12:12:39 +0100 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4DFF4309.7070202@oracle.com> References: <4DFF4309.7070202@oracle.com> Message-ID: <4E007CA7.9000908@oracle.com> Thanks Alan, David, Mandy for you comments. > The retry loop in checkThreadState make sense. Is the 100ms sleep a > bit excessive? The thread will likely get to the expected state in a > fraction of that time. True, reduced to 10ms. > I'm not sure the extra check in checkThreadState that the thread must > be RUNNABLE is valid. What if you are transitioning the thread from a > blocked to non-blocked state, you may still see it blocked on the > first call to getState. > L130-116: I agree with David that this test is not needed. > Like the RuntimeException listed in ProblemList.txt shows > that the target thread is in WAITING state but expected to > be RUNNABLE. The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. These methods set the state and then wait for the phaser to advance. The phaser will not advance until MyThread triggers it, at which point the thread should either be RUNNABLE or the expected state, right? Or have I missed something? I added this extra check since we are now relaxing the check for the expected state. I just thought it would be more correct than allowing any state, but if you feel it too strict ( or still incorrect ) I can remove it. > I also don't understand why you moved the terminated check to after > the join() - if the thread is failing to terminate then the join(), > which is untimed, will simply not return and the test will hang > until timed-out by the harness. > L98: Are you seeing some timing issue if you keep this > checkThreadState > before the join and thus you moved it after the join? No timing issue. I did this for simplicity, given that the state should be TERMINATED when join returns. Either way MyThread.run must complete before the threads state will be set to TERMINATED. Invoking checkThreadState before that point just seems more likely encounter retries. I'm ok with either, just let me know if you want it reverted back to the original. > I also don't think the use of the Phaser is appropriate here as you > are actually delaying the thread from making the state change. In the > original code the target thread signals the main thread that it is > about to go to state X and continues to advance to state X (modulo > preemption etc). But with the Phaser the target thread indicates it > is about to go to state X and then waits for the main thread - > consequently it is more likely that when the main thread calls > checkThreadState that the target has not yet reached the desired > state and so the main thread will have > to loop. This isn't incorrect it just seems to me that in the "wrong" > configuration the test may not take a lot longer in relative terms. > Maybe the additional clarity is worth it though ... When MyThread invokes arriveAndAwaitAdvance, then it should be the final party to arrive and therefore "probably" shouldn't wait. But you raise a good point, myThread should really just invoke phaser.arrive() rather that arriveAndAwaitAdvance. Updated Webrev: http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ -Chris. On 06/20/11 01:54 PM, Chris Hegarty wrote: > java/lang/Thread/ThreadStateTest.java can fail with when > checkThreadState finds an unexpected state. > > Exception in thread "main" java.lang.RuntimeException: MyThread expected > to have TERMINATED but got RUNNABLE > at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) > at ThreadStateTest.main(ThreadStateTest.java:96) > > There is a race between the thread being put in a specific state and the > thread testing for that state. The test should retry the thread state > check a number of times before failing. Also, some minor cleanup and > update to use a more recent j.u.c reusable synchronization barrier. > > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ > > -Chris. From chris.hegarty at oracle.com Tue Jun 21 11:39:04 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 21 Jun 2011 12:39:04 +0100 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E007CA7.9000908@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> Message-ID: <4E0082D8.8040002@oracle.com> On 06/21/11 12:12 PM, Chris Hegarty wrote: > Thanks Alan, David, Mandy for you comments. > > > The retry loop in checkThreadState make sense. Is the 100ms sleep a > > bit excessive? The thread will likely get to the expected state in a > > fraction of that time. > > True, reduced to 10ms. Oh, I also increased the max retries to 500 since reducing the sleep time. This is just a precaution for busy systems. -Chris. > > I'm not sure the extra check in checkThreadState that the thread must > > be RUNNABLE is valid. What if you are transitioning the thread from a > > blocked to non-blocked state, you may still see it blocked on the > > first call to getState. > > > L130-116: I agree with David that this test is not needed. > > Like the RuntimeException listed in ProblemList.txt shows > > that the target thread is in WAITING state but expected to > > be RUNNABLE. > > The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. > These methods set the state and then wait for the phaser to advance. The > phaser will not advance until MyThread triggers it, at which point the > thread should either be RUNNABLE or the expected state, right? Or have I > missed something? > > I added this extra check since we are now relaxing the check for the > expected state. I just thought it would be more correct than allowing > any state, but if you feel it too strict ( or still incorrect ) I can > remove it. > > > I also don't understand why you moved the terminated check to after > > the join() - if the thread is failing to terminate then the join(), > > which is untimed, will simply not return and the test will hang > > until timed-out by the harness. > > > L98: Are you seeing some timing issue if you keep this > > checkThreadState > > before the join and thus you moved it after the join? > > No timing issue. I did this for simplicity, given that the state should > be TERMINATED when join returns. Either way MyThread.run must complete > before the threads state will be set to TERMINATED. Invoking > checkThreadState before that point just seems more likely encounter > retries. I'm ok with either, just let me know if you want it reverted > back to the original. > > > I also don't think the use of the Phaser is appropriate here as you > > are actually delaying the thread from making the state change. In the > > original code the target thread signals the main thread that it is > > about to go to state X and continues to advance to state X (modulo > > preemption etc). But with the Phaser the target thread indicates it > > is about to go to state X and then waits for the main thread - > > consequently it is more likely that when the main thread calls > > checkThreadState that the target has not yet reached the desired > > state and so the main thread will have > > to loop. This isn't incorrect it just seems to me that in the "wrong" > > configuration the test may not take a lot longer in relative terms. > > Maybe the additional clarity is worth it though ... > > When MyThread invokes arriveAndAwaitAdvance, then it should be the final > party to arrive and therefore "probably" shouldn't wait. But you raise a > good point, myThread should really just invoke phaser.arrive() rather > that arriveAndAwaitAdvance. > > Updated Webrev: > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ > > -Chris. > > > On 06/20/11 01:54 PM, Chris Hegarty wrote: >> java/lang/Thread/ThreadStateTest.java can fail with when >> checkThreadState finds an unexpected state. >> >> Exception in thread "main" java.lang.RuntimeException: MyThread expected >> to have TERMINATED but got RUNNABLE >> at ThreadStateTest.checkThreadState(ThreadStateTest.java:119) >> at ThreadStateTest.main(ThreadStateTest.java:96) >> >> There is a race between the thread being put in a specific state and the >> thread testing for that state. The test should retry the thread state >> check a number of times before failing. Also, some minor cleanup and >> update to use a more recent j.u.c reusable synchronization barrier. >> >> http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.00/webrev/ >> >> -Chris. From alan.bateman at oracle.com Tue Jun 21 15:12:39 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 21 Jun 2011 15:12:39 +0000 Subject: hg: jdk8/tl/jdk: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine Message-ID: <20110621151248.EE68C471CF@hg.openjdk.java.net> Changeset: 70f14c2db078 Author: alanb Date: 2011-06-21 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f14c2db078 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine Reviewed-by: mchung ! test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh From kumar.x.srinivasan at oracle.COM Tue Jun 21 18:23:44 2011 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Tue, 21 Jun 2011 11:23:44 -0700 Subject: Trivial: 1 char fix : java launcher help message fix. Message-ID: <4E00E1B0.4030709@oracle.COM> Hi, Please review ... http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt Thanks Kumar From joe.darcy at oracle.com Tue Jun 21 18:26:54 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 21 Jun 2011 11:26:54 -0700 Subject: Trivial: 1 char fix : java launcher help message fix. In-Reply-To: <4E00E1B0.4030709@oracle.COM> References: <4E00E1B0.4030709@oracle.COM> Message-ID: <4E00E26E.1090008@oracle.com> On 6/21/2011 11:23 AM, Kumar Srinivasan wrote: > Hi, > > Please review ... > > http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ > http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt > > Thanks > Kumar > Approved! -Joe From Alan.Bateman at oracle.com Tue Jun 21 18:29:33 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 21 Jun 2011 19:29:33 +0100 Subject: Trivial: 1 char fix : java launcher help message fix. In-Reply-To: <4E00E1B0.4030709@oracle.COM> References: <4E00E1B0.4030709@oracle.COM> Message-ID: <4E00E30D.2010302@oracle.com> Kumar Srinivasan wrote: > Hi, > > Please review ... > > http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ > http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt I think this is actually a 2 character fix :-) Looks good to me. -Alan From xueming.shen at oracle.com Tue Jun 21 19:32:14 2011 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 21 Jun 2011 12:32:14 -0700 Subject: Trivial: 1 char fix : java launcher help message fix. In-Reply-To: <4E00E1B0.4030709@oracle.COM> References: <4E00E1B0.4030709@oracle.COM> Message-ID: <4E00F1BE.9070000@oracle.com> OK, it's a nit-pick and it has nothing to do with this fix, and it probably has been there from day one. But just wonder if those "%n" should be replaced by "/n" in those properties file, otherwise my guess is that the result of java -help will not have the correct line-end on Windows platform. For example if the result is re-directed into a file, that file probably can not be displayed in notepad correctly... -Sherman On 06/21/2011 11:23 AM, Kumar Srinivasan wrote: > Hi, > > Please review ... > > http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ > http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt > > Thanks > Kumar > From xueming.shen at oracle.com Tue Jun 21 20:24:39 2011 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 21 Jun 2011 13:24:39 -0700 Subject: Trivial: 1 char fix : java launcher help message fix. In-Reply-To: <4E00F1BE.9070000@oracle.com> References: <4E00E1B0.4030709@oracle.COM> <4E00F1BE.9070000@oracle.com> Message-ID: <4E00FE07.3070305@oracle.com> On 06/21/2011 12:32 PM, Xueming Shen wrote: > OK, it's a nit-pick and it has nothing to do with this fix, and it > probably has been there from day > one. But just wonder if those "%n" should be replaced by "/n" in those > properties file, otherwise I meant to say "the /n should be replaced by %n". > my guess is that the result of java -help will not have the correct > line-end on Windows platform. > For example if the result is re-directed into a file, that file > probably can not be displayed in > notepad correctly... > > -Sherman > > On 06/21/2011 11:23 AM, Kumar Srinivasan wrote: >> Hi, >> >> Please review ... >> >> http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ >> http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt >> >> Thanks >> Kumar >> > From kumar.x.srinivasan at oracle.COM Tue Jun 21 22:17:22 2011 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Tue, 21 Jun 2011 15:17:22 -0700 Subject: Trivial: 1 char fix : java launcher help message fix. In-Reply-To: <4E00FE07.3070305@oracle.com> References: <4E00E1B0.4030709@oracle.COM> <4E00F1BE.9070000@oracle.com> <4E00FE07.3070305@oracle.com> Message-ID: <4E011872.7010201@oracle.COM> > On 06/21/2011 12:32 PM, Xueming Shen wrote: >> OK, it's a nit-pick and it has nothing to do with this fix, and it >> probably has been there from day >> one. But just wonder if those "%n" should be replaced by "/n" in >> those properties file, otherwise > > I meant to say "the /n should be replaced by %n". should be "\n" replaced by "%n", Ok, since I am here, I will fix this too, lookout for a new webrev. < I guess it will no longer be a trivial 2 char fix. :-( > Kumar > >> my guess is that the result of java -help will not have the correct >> line-end on Windows platform. >> For example if the result is re-directed into a file, that file >> probably can not be displayed in >> notepad correctly... >> >> -Sherman >> >> On 06/21/2011 11:23 AM, Kumar Srinivasan wrote: >>> Hi, >>> >>> Please review ... >>> >>> http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ >>> http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt >>> >>> Thanks >>> Kumar >>> >> > From mandy.chung at oracle.com Wed Jun 22 03:18:31 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 22 Jun 2011 11:18:31 +0800 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E007CA7.9000908@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> Message-ID: <4E015F07.6080602@oracle.com> On 6/21/11 7:12 PM, Chris Hegarty wrote: > [...] > > > I'm not sure the extra check in checkThreadState that the thread must > > be RUNNABLE is valid. What if you are transitioning the thread from a > > blocked to non-blocked state, you may still see it blocked on the > > first call to getState. > > > L130-116: I agree with David that this test is not needed. > > Like the RuntimeException listed in ProblemList.txt shows > > that the target thread is in WAITING state but expected to > > be RUNNABLE. > > The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. > These methods set the state and then wait for the phaser to advance. > The phaser will not advance until MyThread triggers it, at which point > the thread should either be RUNNABLE or the expected state, right? Or > have I missed something? > With the change from calling arriveAndAwaitAdvance to calling arrive, I think you're probably right that the thread should either be RUNNABLE or the expected state. If calling arriveAndAwaitAdvance, the thread delays and waits for the main thread to arrive. The main thread may see that the target thread is in a state waiting for phaser to advance (depending on the implementation). > I added this extra check since we are now relaxing the check for the > expected state. I just thought it would be more correct than allowing > any state, but if you feel it too strict ( or still incorrect ) I can > remove it. > With the change to call arrive, it seems fine to keep this check. I'd like to get David's opinion on this. > > I also don't understand why you moved the terminated check to after > > the join() - if the thread is failing to terminate then the join(), > > which is untimed, will simply not return and the test will hang > > until timed-out by the harness. > > > L98: Are you seeing some timing issue if you keep this > > checkThreadState > > before the join and thus you moved it after the join? > > No timing issue. I did this for simplicity, given that the state > should be TERMINATED when join returns. Either way MyThread.run must > complete before the threads state will be set to TERMINATED. Invoking > checkThreadState before that point just seems more likely encounter > retries. I'm ok with either, just let me know if you want it reverted > back to the original. > The thread could move to TERMINATED state once it completes execution and while the main thread is not yet notified. Since there is no timing issue and MyThread is calling arrive rather than arriveAndAwaitsAdvance, I would say keep the checkThreadState call before the join. > > I also don't think the use of the Phaser is appropriate here as you > > are actually delaying the thread from making the state change. In the > > original code the target thread signals the main thread that it is > > about to go to state X and continues to advance to state X (modulo > > preemption etc). But with the Phaser the target thread indicates it > > is about to go to state X and then waits for the main thread - > > consequently it is more likely that when the main thread calls > > checkThreadState that the target has not yet reached the desired > > state and so the main thread will have > > to loop. This isn't incorrect it just seems to me that in the "wrong" > > configuration the test may not take a lot longer in relative terms. > > Maybe the additional clarity is worth it though ... > > When MyThread invokes arriveAndAwaitAdvance, then it should be the > final party to arrive and therefore "probably" shouldn't wait. But you > raise a good point, myThread should really just invoke phaser.arrive() > rather that arriveAndAwaitAdvance. > > Updated Webrev: > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ Looks good. Thanks for fixing this timing issue. Mandy From David.Holmes at oracle.com Wed Jun 22 10:05:29 2011 From: David.Holmes at oracle.com (David Holmes) Date: Wed, 22 Jun 2011 20:05:29 +1000 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E015F07.6080602@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> <4E015F07.6080602@oracle.com> Message-ID: <4E01BE69.6030207@oracle.com> Mandy, I need to study the test in more detail to see exactly how the thread is supposed to change state and in what order. I'm not yet convinced that arrive() in place of arriveAndAwaitAdvance() doesn't introduce races. David Mandy Chung said the following on 06/22/11 13:18: > On 6/21/11 7:12 PM, Chris Hegarty wrote: >> [...] >> >> > I'm not sure the extra check in checkThreadState that the thread must >> > be RUNNABLE is valid. What if you are transitioning the thread from a >> > blocked to non-blocked state, you may still see it blocked on the >> > first call to getState. >> >> > L130-116: I agree with David that this test is not needed. >> > Like the RuntimeException listed in ProblemList.txt shows >> > that the target thread is in WAITING state but expected to >> > be RUNNABLE. >> >> The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. >> These methods set the state and then wait for the phaser to advance. >> The phaser will not advance until MyThread triggers it, at which point >> the thread should either be RUNNABLE or the expected state, right? Or >> have I missed something? >> > With the change from calling arriveAndAwaitAdvance to calling arrive, I > think you're probably right that the thread should either be RUNNABLE or > the expected state. If calling arriveAndAwaitAdvance, the thread delays > and waits for the main thread to arrive. The main thread may see that > the target thread is in a state waiting for phaser to advance (depending > on the implementation). > >> I added this extra check since we are now relaxing the check for the >> expected state. I just thought it would be more correct than allowing >> any state, but if you feel it too strict ( or still incorrect ) I can >> remove it. >> > > With the change to call arrive, it seems fine to keep this check. I'd > like to get David's opinion on this. > >> > I also don't understand why you moved the terminated check to after >> > the join() - if the thread is failing to terminate then the join(), >> > which is untimed, will simply not return and the test will hang >> > until timed-out by the harness. >> >> > L98: Are you seeing some timing issue if you keep this >> > checkThreadState >> > before the join and thus you moved it after the join? >> >> No timing issue. I did this for simplicity, given that the state >> should be TERMINATED when join returns. Either way MyThread.run must >> complete before the threads state will be set to TERMINATED. Invoking >> checkThreadState before that point just seems more likely encounter >> retries. I'm ok with either, just let me know if you want it reverted >> back to the original. >> > The thread could move to TERMINATED state once it completes execution > and while the main thread is not yet notified. Since there is no timing > issue and MyThread is calling arrive rather than arriveAndAwaitsAdvance, > I would say keep the checkThreadState call before the join. > >> > I also don't think the use of the Phaser is appropriate here as you >> > are actually delaying the thread from making the state change. In the >> > original code the target thread signals the main thread that it is >> > about to go to state X and continues to advance to state X (modulo >> > preemption etc). But with the Phaser the target thread indicates it >> > is about to go to state X and then waits for the main thread - >> > consequently it is more likely that when the main thread calls >> > checkThreadState that the target has not yet reached the desired >> > state and so the main thread will have >> > to loop. This isn't incorrect it just seems to me that in the "wrong" >> > configuration the test may not take a lot longer in relative terms. >> > Maybe the additional clarity is worth it though ... >> >> When MyThread invokes arriveAndAwaitAdvance, then it should be the >> final party to arrive and therefore "probably" shouldn't wait. But you >> raise a good point, myThread should really just invoke phaser.arrive() >> rather that arriveAndAwaitAdvance. >> >> Updated Webrev: >> http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ > Looks good. Thanks for fixing this timing issue. > Mandy From alan.bateman at oracle.com Wed Jun 22 14:14:39 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 22 Jun 2011 14:14:39 +0000 Subject: hg: jdk8/tl/jdk: 7056447: test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java fails in agentvm Message-ID: <20110622141507.DFCFC4721F@hg.openjdk.java.net> Changeset: 0bde4bed86e5 Author: alanb Date: 2011-06-22 15:13 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0bde4bed86e5 7056447: test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java fails in agentvm Reviewed-by: emcmanus ! test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java From joe.darcy at oracle.com Wed Jun 22 15:47:26 2011 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 22 Jun 2011 08:47:26 -0700 Subject: Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" In-Reply-To: <4DFC3D89.4040804@oracle.com> References: <4DFC0186.6060607@oracle.com> <4DFC3D89.4040804@oracle.com> Message-ID: <4E020E8E.8070903@oracle.com> David Holmes wrote: > Hi Joe, > > Joe Darcy said the following on 06/18/11 11:38: >> Please review this (somewhat tedious) change to make the behavior of >> the Number subtypes in the JDK more explicit: >> >> 6253144: Long narrowing conversion should describe the algorithm >> used and implied "risks" >> http://cr.openjdk.java.net/~darcy/6253144.0/ >> >> David, how are changes to AtomicInteger and AtomicLong managed? > > Normally they would go into Doug Lea's CVS for jsr166, we (Chris > Hegarty) would pull them over and then push to OpenJDK. It can work > the other way but the sync's can get messier. > Chris, Off-list, Mike approved this set of changes and I'd like to get them pushed once the matching ccc is approved. (The ccc request is needed since the long-standing behavior of the non-abstract methods on number is being specified.) How would you like to handle updates to the Atomic classes? Thanks, -Joe From chris.hegarty at oracle.com Wed Jun 22 15:52:35 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 22 Jun 2011 16:52:35 +0100 Subject: Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" In-Reply-To: <4E020E8E.8070903@oracle.com> References: <4DFC0186.6060607@oracle.com> <4DFC3D89.4040804@oracle.com> <4E020E8E.8070903@oracle.com> Message-ID: <4E020FC3.3030002@oracle.com> On 06/22/11 04:47 PM, Joe Darcy wrote: > David Holmes wrote: >> Hi Joe, >> >> Joe Darcy said the following on 06/18/11 11:38: >>> Please review this (somewhat tedious) change to make the behavior of >>> the Number subtypes in the JDK more explicit: >>> >>> 6253144: Long narrowing conversion should describe the algorithm used >>> and implied "risks" >>> http://cr.openjdk.java.net/~darcy/6253144.0/ >>> >>> David, how are changes to AtomicInteger and AtomicLong managed? >> >> Normally they would go into Doug Lea's CVS for jsr166, we (Chris >> Hegarty) would pull them over and then push to OpenJDK. It can work >> the other way but the sync's can get messier. >> > > Chris, > > Off-list, Mike approved this set of changes and I'd like to get them > pushed once the matching ccc is approved. (The ccc request is needed > since the long-standing behavior of the non-abstract methods on number > is being specified.) > > How would you like to handle updates to the Atomic classes? I think in this case it should be fine to make the changes in OpenJDK first. Then I can create a patch for the Atomic changes based on Dougs CVS. I'll double check this with Doug, but unless you hear otherwise let's assume we can do this. In fact, if Doug is watching he may be able to move faster than us! -Chris. > > Thanks, > > -Joe From jeff.dinkins at oracle.com Wed Jun 22 18:06:38 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:06:38 +0000 Subject: hg: jdk7/tl: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622180638.D316547228@hg.openjdk.java.net> Changeset: 8da980eedab6 Author: jeff Date: 2011-06-22 10:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/8da980eedab6 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Wed Jun 22 18:06:57 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:06:57 +0000 Subject: hg: jdk7/tl/corba: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622180659.42B9A47229@hg.openjdk.java.net> Changeset: bba0e37d7006 Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/bba0e37d7006 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Wed Jun 22 18:07:33 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:07:33 +0000 Subject: hg: jdk7/tl/hotspot: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622180742.DE82F4722A@hg.openjdk.java.net> Changeset: f6ba9007b2c6 Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f6ba9007b2c6 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Wed Jun 22 18:09:11 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:09:11 +0000 Subject: hg: jdk7/tl/jaxp: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622180911.91F714722B@hg.openjdk.java.net> Changeset: eed2486cb10b Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/eed2486cb10b 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Wed Jun 22 18:09:26 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:09:26 +0000 Subject: hg: jdk7/tl/jaxws: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622180926.B7A834722C@hg.openjdk.java.net> Changeset: 632e38191caa Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/632e38191caa 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Wed Jun 22 18:09:39 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:09:39 +0000 Subject: hg: jdk7/tl/jdk: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622181012.A0AEC4722D@hg.openjdk.java.net> Changeset: cfd7602f5c52 Author: jeff Date: 2011-06-22 10:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cfd7602f5c52 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From jeff.dinkins at oracle.com Wed Jun 22 18:11:24 2011 From: jeff.dinkins at oracle.com (jeff.dinkins at oracle.com) Date: Wed, 22 Jun 2011 18:11:24 +0000 Subject: hg: jdk7/tl/langtools: 7057046: Add embedded license to THIRD PARTY README Message-ID: <20110622181128.193864722E@hg.openjdk.java.net> Changeset: a72412b148d7 Author: jeff Date: 2011-06-22 10:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a72412b148d7 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README From joe.darcy at oracle.com Thu Jun 23 00:07:26 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 23 Jun 2011 00:07:26 +0000 Subject: hg: jdk8/tl/langtools: 6449184: Provide JavacProcessingEnvironment.getWriter Message-ID: <20110623000731.38FB24724B@hg.openjdk.java.net> Changeset: 4844a9fd3a62 Author: darcy Date: 2011-06-22 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4844a9fd3a62 6449184: Provide JavacProcessingEnvironment.getWriter Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/tools/javac/util/T6597678.java From weijun.wang at oracle.com Thu Jun 23 01:27:29 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 23 Jun 2011 01:27:29 +0000 Subject: hg: jdk8/tl/jdk: 7055362: jdk_security2 test target cleanup Message-ID: <20110623012748.1C45647250@hg.openjdk.java.net> Changeset: febb7f557135 Author: weijun Date: 2011-06-23 09:27 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/febb7f557135 7055362: jdk_security2 test target cleanup Reviewed-by: alanb ! test/Makefile ! test/ProblemList.txt ! test/com/sun/crypto/provider/Cipher/DES/Sealtest.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEP_KAT.java ! test/javax/crypto/EncryptedPrivateKeyInfo/GetKeySpecException.java ! test/javax/crypto/JceSecurity/SunJCE_BC_LoadOrdering.java From xuelei.fan at oracle.com Thu Jun 23 02:39:34 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 23 Jun 2011 02:39:34 +0000 Subject: hg: jdk8/tl/jdk: 6952814: sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java failing in PIT Message-ID: <20110623023944.952C147253@hg.openjdk.java.net> Changeset: 3b7193ab0d87 Author: xuelei Date: 2011-06-22 19:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b7193ab0d87 6952814: sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java failing in PIT Reviewed-by: alanb - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java From xuelei.fan at oracle.com Thu Jun 23 04:21:52 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 23 Jun 2011 04:21:52 +0000 Subject: hg: jdk8/tl/jdk: 7058271: Remove InterruptedIO.java record from ProblemList.txt Message-ID: <20110623042202.2746447258@hg.openjdk.java.net> Changeset: 57265bf4b36b Author: xuelei Date: 2011-06-22 21:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57265bf4b36b 7058271: Remove InterruptedIO.java record from ProblemList.txt Reviewed-by: weijun ! test/ProblemList.txt From David.Holmes at oracle.com Thu Jun 23 05:33:51 2011 From: David.Holmes at oracle.com (David Holmes) Date: Thu, 23 Jun 2011 15:33:51 +1000 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E01BE69.6030207@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> <4E015F07.6080602@oracle.com> <4E01BE69.6030207@oracle.com> Message-ID: <4E02D03F.3080807@oracle.com> Sorry for the delay on this ... I concur with Mandy that using arrive() the thread must always be RUNNABLE or the expected next state. Hence the new check is ok. With the new synchronization (and perhaps even the old) it seems to me that here: private void setState(int newState) { switch (state) { case BLOCKED: while (state == BLOCKED) { goSleep(20); } state = newState; break; the sleep loop is unnecessary as after setting the new state the main thread will call arriveAndAwaitAdvance. Also here: try { Thread.sleep(1000000); } catch (InterruptedException e) { // finish sleeping interrupted(); } the interrupted() call is redundant as the interrupt state is already cleared when the IE is thrown. Cheers, David David Holmes said the following on 06/22/11 20:05: > Mandy, > > I need to study the test in more detail to see exactly how the thread is > supposed to change state and in what order. I'm not yet convinced that > arrive() in place of arriveAndAwaitAdvance() doesn't introduce races. > > David > > Mandy Chung said the following on 06/22/11 13:18: >> On 6/21/11 7:12 PM, Chris Hegarty wrote: >>> [...] >>> >>> > I'm not sure the extra check in checkThreadState that the thread must >>> > be RUNNABLE is valid. What if you are transitioning the thread from a >>> > blocked to non-blocked state, you may still see it blocked on the >>> > first call to getState. >>> >>> > L130-116: I agree with David that this test is not needed. >>> > Like the RuntimeException listed in ProblemList.txt shows >>> > that the target thread is in WAITING state but expected to >>> > be RUNNABLE. >>> >>> The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. >>> These methods set the state and then wait for the phaser to advance. >>> The phaser will not advance until MyThread triggers it, at which >>> point the thread should either be RUNNABLE or the expected state, >>> right? Or have I missed something? >>> >> With the change from calling arriveAndAwaitAdvance to calling arrive, >> I think you're probably right that the thread should either be >> RUNNABLE or the expected state. If calling arriveAndAwaitAdvance, the >> thread delays and waits for the main thread to arrive. The main >> thread may see that the target thread is in a state waiting for phaser >> to advance (depending on the implementation). >> >>> I added this extra check since we are now relaxing the check for the >>> expected state. I just thought it would be more correct than allowing >>> any state, but if you feel it too strict ( or still incorrect ) I can >>> remove it. >>> >> >> With the change to call arrive, it seems fine to keep this check. I'd >> like to get David's opinion on this. >> >>> > I also don't understand why you moved the terminated check to after >>> > the join() - if the thread is failing to terminate then the join(), >>> > which is untimed, will simply not return and the test will hang >>> > until timed-out by the harness. >>> >>> > L98: Are you seeing some timing issue if you keep this >>> > checkThreadState >>> > before the join and thus you moved it after the join? >>> >>> No timing issue. I did this for simplicity, given that the state >>> should be TERMINATED when join returns. Either way MyThread.run must >>> complete before the threads state will be set to TERMINATED. Invoking >>> checkThreadState before that point just seems more likely encounter >>> retries. I'm ok with either, just let me know if you want it reverted >>> back to the original. >>> >> The thread could move to TERMINATED state once it completes execution >> and while the main thread is not yet notified. Since there is no >> timing issue and MyThread is calling arrive rather than >> arriveAndAwaitsAdvance, I would say keep the checkThreadState call >> before the join. >> >>> > I also don't think the use of the Phaser is appropriate here as you >>> > are actually delaying the thread from making the state change. In the >>> > original code the target thread signals the main thread that it is >>> > about to go to state X and continues to advance to state X (modulo >>> > preemption etc). But with the Phaser the target thread indicates it >>> > is about to go to state X and then waits for the main thread - >>> > consequently it is more likely that when the main thread calls >>> > checkThreadState that the target has not yet reached the desired >>> > state and so the main thread will have >>> > to loop. This isn't incorrect it just seems to me that in the "wrong" >>> > configuration the test may not take a lot longer in relative terms. >>> > Maybe the additional clarity is worth it though ... >>> >>> When MyThread invokes arriveAndAwaitAdvance, then it should be the >>> final party to arrive and therefore "probably" shouldn't wait. But >>> you raise a good point, myThread should really just invoke >>> phaser.arrive() rather that arriveAndAwaitAdvance. >>> >>> Updated Webrev: >>> http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ >> Looks good. Thanks for fixing this timing issue. >> Mandy From mandy.chung at oracle.com Thu Jun 23 07:57:27 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 23 Jun 2011 15:57:27 +0800 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E02D03F.3080807@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> <4E015F07.6080602@oracle.com> <4E01BE69.6030207@oracle.com> <4E02D03F.3080807@oracle.com> Message-ID: <4E02F1E7.3000205@oracle.com> David, Thanks for taking a closer look. Really appreciate your detailed review. On 6/23/11 1:33 PM, David Holmes wrote: > Sorry for the delay on this ... > > I concur with Mandy that using arrive() the thread must always be > RUNNABLE or the expected next state. Hence the new check is ok. > > With the new synchronization (and perhaps even the old) it seems to me > that here: > > private void setState(int newState) { > switch (state) { > case BLOCKED: > while (state == BLOCKED) { > goSleep(20); > } > state = newState; > break; > > the sleep loop is unnecessary as after setting the new state the main > thread will call arriveAndAwaitAdvance. > > Also here: > > try { > Thread.sleep(1000000); > } catch (InterruptedException e) { > // finish sleeping > interrupted(); > } > > the interrupted() call is redundant as the interrupt state is already > cleared when the IE is thrown. Good catch. The sleep loop and the interrupted() call are indeed not needed. Mandy From chris.hegarty at oracle.com Thu Jun 23 10:22:54 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 23 Jun 2011 11:22:54 +0100 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E02D03F.3080807@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> <4E015F07.6080602@oracle.com> <4E01BE69.6030207@oracle.com> <4E02D03F.3080807@oracle.com> Message-ID: <4E0313FE.3030205@oracle.com> On 06/23/11 06:33 AM, David Holmes wrote: > Sorry for the delay on this ... > > I concur with Mandy that using arrive() the thread must always be > RUNNABLE or the expected next state. Hence the new check is ok. Thanks David, > With the new synchronization (and perhaps even the old) it seems to me > that here: > > private void setState(int newState) { > switch (state) { > case BLOCKED: > while (state == BLOCKED) { > goSleep(20); > } > state = newState; > break; > > the sleep loop is unnecessary as after setting the new state the main > thread will call arriveAndAwaitAdvance. In its current form we can't remove this ( I only found out after removing it and testing ). The reason is that after the main thread releases globalLock, MyThread sets the state to RUNNABLE (to keep it busy before the next state is set). But goWaiting may be called on the main thread before MyThread sets the state to be RUNNABLE. So the WAITING state could be lost and MyThread go into an infinite loop. I think it may be best to just reduce the sleep from 20ms to 10ms. > Also here: > > try { > Thread.sleep(1000000); > } catch (InterruptedException e) { > // finish sleeping > interrupted(); > } > > the interrupted() call is redundant as the interrupt state is already > cleared when the IE is thrown. Thanks, I'll remove this redundant call. Updated Webrev: http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.02/webrev/ -Chris > > Cheers, > David > > > David Holmes said the following on 06/22/11 20:05: >> Mandy, >> >> I need to study the test in more detail to see exactly how the thread >> is supposed to change state and in what order. I'm not yet convinced >> that arrive() in place of arriveAndAwaitAdvance() doesn't introduce >> races. >> >> David >> >> Mandy Chung said the following on 06/22/11 13:18: >>> On 6/21/11 7:12 PM, Chris Hegarty wrote: >>>> [...] >>>> >>>> > I'm not sure the extra check in checkThreadState that the thread must >>>> > be RUNNABLE is valid. What if you are transitioning the thread from a >>>> > blocked to non-blocked state, you may still see it blocked on the >>>> > first call to getState. >>>> >>>> > L130-116: I agree with David that this test is not needed. >>>> > Like the RuntimeException listed in ProblemList.txt shows >>>> > that the target thread is in WAITING state but expected to >>>> > be RUNNABLE. >>>> >>>> The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. >>>> These methods set the state and then wait for the phaser to advance. >>>> The phaser will not advance until MyThread triggers it, at which >>>> point the thread should either be RUNNABLE or the expected state, >>>> right? Or have I missed something? >>>> >>> With the change from calling arriveAndAwaitAdvance to calling arrive, >>> I think you're probably right that the thread should either be >>> RUNNABLE or the expected state. If calling arriveAndAwaitAdvance, the >>> thread delays and waits for the main thread to arrive. The main >>> thread may see that the target thread is in a state waiting for >>> phaser to advance (depending on the implementation). >>> >>>> I added this extra check since we are now relaxing the check for the >>>> expected state. I just thought it would be more correct than >>>> allowing any state, but if you feel it too strict ( or still >>>> incorrect ) I can remove it. >>>> >>> >>> With the change to call arrive, it seems fine to keep this check. I'd >>> like to get David's opinion on this. >>> >>>> > I also don't understand why you moved the terminated check to after >>>> > the join() - if the thread is failing to terminate then the join(), >>>> > which is untimed, will simply not return and the test will hang >>>> > until timed-out by the harness. >>>> >>>> > L98: Are you seeing some timing issue if you keep this >>>> > checkThreadState >>>> > before the join and thus you moved it after the join? >>>> >>>> No timing issue. I did this for simplicity, given that the state >>>> should be TERMINATED when join returns. Either way MyThread.run must >>>> complete before the threads state will be set to TERMINATED. >>>> Invoking checkThreadState before that point just seems more likely >>>> encounter retries. I'm ok with either, just let me know if you want >>>> it reverted back to the original. >>>> >>> The thread could move to TERMINATED state once it completes execution >>> and while the main thread is not yet notified. Since there is no >>> timing issue and MyThread is calling arrive rather than >>> arriveAndAwaitsAdvance, I would say keep the checkThreadState call >>> before the join. >>> >>>> > I also don't think the use of the Phaser is appropriate here as you >>>> > are actually delaying the thread from making the state change. In the >>>> > original code the target thread signals the main thread that it is >>>> > about to go to state X and continues to advance to state X (modulo >>>> > preemption etc). But with the Phaser the target thread indicates it >>>> > is about to go to state X and then waits for the main thread - >>>> > consequently it is more likely that when the main thread calls >>>> > checkThreadState that the target has not yet reached the desired >>>> > state and so the main thread will have >>>> > to loop. This isn't incorrect it just seems to me that in the "wrong" >>>> > configuration the test may not take a lot longer in relative terms. >>>> > Maybe the additional clarity is worth it though ... >>>> >>>> When MyThread invokes arriveAndAwaitAdvance, then it should be the >>>> final party to arrive and therefore "probably" shouldn't wait. But >>>> you raise a good point, myThread should really just invoke >>>> phaser.arrive() rather that arriveAndAwaitAdvance. >>>> >>>> Updated Webrev: >>>> http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ >>> Looks good. Thanks for fixing this timing issue. >>> Mandy From David.Holmes at oracle.com Thu Jun 23 10:34:13 2011 From: David.Holmes at oracle.com (David Holmes) Date: Thu, 23 Jun 2011 20:34:13 +1000 Subject: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently In-Reply-To: <4E0313FE.3030205@oracle.com> References: <4DFF4309.7070202@oracle.com> <4E007CA7.9000908@oracle.com> <4E015F07.6080602@oracle.com> <4E01BE69.6030207@oracle.com> <4E02D03F.3080807@oracle.com> <4E0313FE.3030205@oracle.com> Message-ID: <4E0316A5.9070501@oracle.com> Chris Hegarty said the following on 06/23/11 20:22: > > On 06/23/11 06:33 AM, David Holmes wrote: > > Sorry for the delay on this ... > > > > I concur with Mandy that using arrive() the thread must always be > > RUNNABLE or the expected next state. Hence the new check is ok. > > Thanks David, > > > With the new synchronization (and perhaps even the old) it seems to me > > that here: > > > > private void setState(int newState) { > > switch (state) { > > case BLOCKED: > > while (state == BLOCKED) { > > goSleep(20); > > } > > state = newState; > > break; > > > > the sleep loop is unnecessary as after setting the new state the main > > thread will call arriveAndAwaitAdvance. > > In its current form we can't remove this ( I only found out after > removing it and testing ). The reason is that after the main thread > releases globalLock, MyThread sets the state to RUNNABLE (to keep it > busy before the next state is set). But goWaiting may be called on the > main thread before MyThread sets the state to be RUNNABLE. So the > WAITING state could be lost and MyThread go into an infinite loop. Ouch! That's a nasty race. :( David ----- > I think it may be best to just reduce the sleep from 20ms to 10ms. > > > Also here: > > > > try { > > Thread.sleep(1000000); > > } catch (InterruptedException e) { > > // finish sleeping > > interrupted(); > > } > > > > the interrupted() call is redundant as the interrupt state is already > > cleared when the IE is thrown. > > Thanks, I'll remove this redundant call. > > Updated Webrev: > http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.02/webrev/ > > -Chris > > > > > Cheers, > > David > > > > > > David Holmes said the following on 06/22/11 20:05: > >> Mandy, > >> > >> I need to study the test in more detail to see exactly how the thread > >> is supposed to change state and in what order. I'm not yet convinced > >> that arrive() in place of arriveAndAwaitAdvance() doesn't introduce > >> races. > >> > >> David > >> > >> Mandy Chung said the following on 06/22/11 13:18: > >>> On 6/21/11 7:12 PM, Chris Hegarty wrote: > >>>> [...] > >>>> > >>>> > I'm not sure the extra check in checkThreadState that the thread > must > >>>> > be RUNNABLE is valid. What if you are transitioning the thread > from a > >>>> > blocked to non-blocked state, you may still see it blocked on the > >>>> > first call to getState. > >>>> > >>>> > L130-116: I agree with David that this test is not needed. > >>>> > Like the RuntimeException listed in ProblemList.txt shows > >>>> > that the target thread is in WAITING state but expected to > >>>> > be RUNNABLE. > >>>> > >>>> The main thread executes goBlocked, goWaiting, goTimedWaiting, etc. > >>>> These methods set the state and then wait for the phaser to advance. > >>>> The phaser will not advance until MyThread triggers it, at which > >>>> point the thread should either be RUNNABLE or the expected state, > >>>> right? Or have I missed something? > >>>> > >>> With the change from calling arriveAndAwaitAdvance to calling arrive, > >>> I think you're probably right that the thread should either be > >>> RUNNABLE or the expected state. If calling arriveAndAwaitAdvance, the > >>> thread delays and waits for the main thread to arrive. The main > >>> thread may see that the target thread is in a state waiting for > >>> phaser to advance (depending on the implementation). > >>> > >>>> I added this extra check since we are now relaxing the check for the > >>>> expected state. I just thought it would be more correct than > >>>> allowing any state, but if you feel it too strict ( or still > >>>> incorrect ) I can remove it. > >>>> > >>> > >>> With the change to call arrive, it seems fine to keep this check. I'd > >>> like to get David's opinion on this. > >>> > >>>> > I also don't understand why you moved the terminated check to after > >>>> > the join() - if the thread is failing to terminate then the join(), > >>>> > which is untimed, will simply not return and the test will hang > >>>> > until timed-out by the harness. > >>>> > >>>> > L98: Are you seeing some timing issue if you keep this > >>>> > checkThreadState > >>>> > before the join and thus you moved it after the join? > >>>> > >>>> No timing issue. I did this for simplicity, given that the state > >>>> should be TERMINATED when join returns. Either way MyThread.run must > >>>> complete before the threads state will be set to TERMINATED. > >>>> Invoking checkThreadState before that point just seems more likely > >>>> encounter retries. I'm ok with either, just let me know if you want > >>>> it reverted back to the original. > >>>> > >>> The thread could move to TERMINATED state once it completes execution > >>> and while the main thread is not yet notified. Since there is no > >>> timing issue and MyThread is calling arrive rather than > >>> arriveAndAwaitsAdvance, I would say keep the checkThreadState call > >>> before the join. > >>> > >>>> > I also don't think the use of the Phaser is appropriate here as you > >>>> > are actually delaying the thread from making the state change. > In the > >>>> > original code the target thread signals the main thread that it is > >>>> > about to go to state X and continues to advance to state X (modulo > >>>> > preemption etc). But with the Phaser the target thread indicates it > >>>> > is about to go to state X and then waits for the main thread - > >>>> > consequently it is more likely that when the main thread calls > >>>> > checkThreadState that the target has not yet reached the desired > >>>> > state and so the main thread will have > >>>> > to loop. This isn't incorrect it just seems to me that in the > "wrong" > >>>> > configuration the test may not take a lot longer in relative terms. > >>>> > Maybe the additional clarity is worth it though ... > >>>> > >>>> When MyThread invokes arriveAndAwaitAdvance, then it should be the > >>>> final party to arrive and therefore "probably" shouldn't wait. But > >>>> you raise a good point, myThread should really just invoke > >>>> phaser.arrive() rather that arriveAndAwaitAdvance. > >>>> > >>>> Updated Webrev: > >>>> http://cr.openjdk.java.net/~chegar/7021010/jdk8.webrev.01/webrev/ > >>> Looks good. Thanks for fixing this timing issue. > >>> Mandy From chris.hegarty at oracle.com Thu Jun 23 11:00:58 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 23 Jun 2011 11:00:58 +0000 Subject: hg: jdk8/tl/jdk: 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp Message-ID: <20110623110118.EB03047267@hg.openjdk.java.net> Changeset: 6b2c14dfe9b9 Author: chegar Date: 2011-06-23 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b2c14dfe9b9 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp Reviewed-by: alanb ! test/Makefile ! test/ProblemList.txt From chris.hegarty at oracle.com Thu Jun 23 11:16:04 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 23 Jun 2011 11:16:04 +0000 Subject: hg: jdk8/tl/jdk: 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently Message-ID: <20110623111614.1B93447268@hg.openjdk.java.net> Changeset: ae7211979179 Author: chegar Date: 2011-06-23 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae7211979179 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, alanb, mchung ! test/ProblemList.txt ! test/java/lang/Thread/ThreadStateTest.java From xuelei.fan at oracle.com Thu Jun 23 11:25:02 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 23 Jun 2011 11:25:02 +0000 Subject: hg: jdk8/tl/jdk: 7057022: test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java has invalid jtreg tags Message-ID: <20110623112512.042954726A@hg.openjdk.java.net> Changeset: cd7adb545f71 Author: xuelei Date: 2011-06-23 04:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd7adb545f71 7057022: test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java has invalid jtreg tags Reviewed-by: weijun ! test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java From jonathan.gibbons at oracle.com Thu Jun 23 18:49:47 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 23 Jun 2011 18:49:47 +0000 Subject: hg: jdk8/tl/langtools: 7058174: Reduce langtools build warnings Message-ID: <20110623184949.E19194727D@hg.openjdk.java.net> Changeset: 18002d039806 Author: jjg Date: 2011-06-23 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/18002d039806 7058174: Reduce langtools build warnings Reviewed-by: jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/build.xml ! make/tools/CompileProperties/CompileProperties.java From joe.darcy at oracle.com Thu Jun 23 21:58:17 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 23 Jun 2011 21:58:17 +0000 Subject: hg: jdk8/tl/jdk: 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" Message-ID: <20110623215838.983EE4728C@hg.openjdk.java.net> Changeset: 151756a4037b Author: darcy Date: 2011-06-23 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/151756a4037b 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" Reviewed-by: mduigou, alanb ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Number.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java From joe.darcy at oracle.com Thu Jun 23 22:08:12 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 23 Jun 2011 15:08:12 -0700 Subject: Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied "risks" In-Reply-To: <4E020FC3.3030002@oracle.com> References: <4DFC0186.6060607@oracle.com> <4DFC3D89.4040804@oracle.com> <4E020E8E.8070903@oracle.com> <4E020FC3.3030002@oracle.com> Message-ID: <4E03B94C.20806@oracle.com> On 6/22/2011 8:52 AM, Chris Hegarty wrote: > > > On 06/22/11 04:47 PM, Joe Darcy wrote: >> David Holmes wrote: >>> Hi Joe, >>> >>> Joe Darcy said the following on 06/18/11 11:38: >>>> Please review this (somewhat tedious) change to make the behavior of >>>> the Number subtypes in the JDK more explicit: >>>> >>>> 6253144: Long narrowing conversion should describe the algorithm used >>>> and implied "risks" >>>> http://cr.openjdk.java.net/~darcy/6253144.0/ >>>> >>>> David, how are changes to AtomicInteger and AtomicLong managed? >>> >>> Normally they would go into Doug Lea's CVS for jsr166, we (Chris >>> Hegarty) would pull them over and then push to OpenJDK. It can work >>> the other way but the sync's can get messier. >>> >> >> Chris, >> >> Off-list, Mike approved this set of changes and I'd like to get them >> pushed once the matching ccc is approved. (The ccc request is needed >> since the long-standing behavior of the non-abstract methods on number >> is being specified.) >> >> How would you like to handle updates to the Atomic classes? > > I think in this case it should be fine to make the changes in OpenJDK > first. Then I can create a patch for the Atomic changes based on Dougs > CVS. > > I'll double check this with Doug, but unless you hear otherwise let's > assume we can do this. In fact, if Doug is watching he may be able to > move faster than us! > > -Chris. > Hello. FYI, fix pushed to JDK 8 tl: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/151756a4037b Thanks, -Joe From lana.steuck at oracle.com Fri Jun 24 00:31:49 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 24 Jun 2011 00:31:49 +0000 Subject: hg: jdk8/tl: 7 new changesets Message-ID: <20110624003150.2276D4729B@hg.openjdk.java.net> Changeset: 4373d87e6f37 Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4373d87e6f37 Added tag jdk7-b144 for changeset 7203965666a4 ! .hgtags Changeset: 93d2590fd849 Author: jeff Date: 2011-05-27 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/93d2590fd849 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 55e9ebf03218 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/55e9ebf03218 Merge Changeset: 2d38c2a79c14 Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2d38c2a79c14 Added tag jdk7-b145 for changeset 55e9ebf03218 ! .hgtags Changeset: 404bd0b9385f Author: schien Date: 2011-06-08 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/404bd0b9385f Merge Changeset: 3e0b96f8f6a0 Author: schien Date: 2011-06-20 16:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3e0b96f8f6a0 Added tag jdk7-b146 for changeset 2d38c2a79c14 ! .hgtags Changeset: 29e7e1474b5e Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/29e7e1474b5e Merge From lana.steuck at oracle.com Fri Jun 24 00:32:03 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 24 Jun 2011 00:32:03 +0000 Subject: hg: jdk8/tl/jaxws: 18 new changesets Message-ID: <20110624003204.198C44729C@hg.openjdk.java.net> Changeset: 6158298d2b94 Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6158298d2b94 Added tag jdk7-b144 for changeset 6bd683f2d527 ! .hgtags Changeset: c902e39c384e Author: jeff Date: 2011-05-27 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c902e39c384e 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: bcca8afc019f Author: ohair Date: 2011-06-01 10:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/bcca8afc019f 7049699: Problem with xml/jax-ws Reviewed-by: ramap ! jaxws.properties Changeset: 42bfba80beb7 Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/42bfba80beb7 Merge Changeset: 6ec12c60ad13 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6ec12c60ad13 Added tag jdk7-b145 for changeset 42bfba80beb7 ! .hgtags Changeset: 1b7851b9e113 Author: schien Date: 2011-06-08 10:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1b7851b9e113 Merge Changeset: 581dab3f0773 Author: asaha Date: 2011-04-21 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/581dab3f0773 Merge Changeset: 26610bb80151 Author: asaha Date: 2011-05-04 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/26610bb80151 Merge Changeset: c6ff860428c7 Author: asaha Date: 2011-05-05 22:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c6ff860428c7 Merge Changeset: f4e1caef46d0 Author: asaha Date: 2011-05-24 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f4e1caef46d0 Merge Changeset: 9896cee00786 Author: asaha Date: 2011-05-26 17:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9896cee00786 Merge Changeset: d1febdcb0351 Author: asaha Date: 2011-05-26 21:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d1febdcb0351 Merge Changeset: 239c80c331da Author: asaha Date: 2011-06-06 10:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/239c80c331da Merge Changeset: 09412171ca4b Author: asaha Date: 2011-06-03 07:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/09412171ca4b Merge Changeset: 9d8fd0982fb8 Author: asaha Date: 2011-06-06 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9d8fd0982fb8 Merge Changeset: 05469dd4c366 Author: lana Date: 2011-06-15 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/05469dd4c366 Merge Changeset: faa394edbfe3 Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/faa394edbfe3 Added tag jdk7-b146 for changeset 05469dd4c366 ! .hgtags Changeset: 9244c440c0df Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/9244c440c0df Merge From lana.steuck at oracle.com Fri Jun 24 00:32:07 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 24 Jun 2011 00:32:07 +0000 Subject: hg: jdk8/tl/jaxp: 9 new changesets Message-ID: <20110624003207.83B724729D@hg.openjdk.java.net> Changeset: bee49f47043f Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bee49f47043f Added tag jdk7-b144 for changeset 39bf6dcaab23 ! .hgtags Changeset: bdf77cbd9958 Author: ohair Date: 2011-05-19 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bdf77cbd9958 7044493: Incorrectly formated GPL headers in JDK7 JAXP source drop Reviewed-by: joehw ! jaxp.properties Changeset: 775dd77e4730 Author: lana Date: 2011-05-20 21:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/775dd77e4730 Merge Changeset: a70a042c8600 Author: jeff Date: 2011-05-27 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a70a042c8600 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 10ca7570f47f Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/10ca7570f47f Merge Changeset: bcd31fa1e3c6 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bcd31fa1e3c6 Added tag jdk7-b145 for changeset 10ca7570f47f ! .hgtags Changeset: bae5f389d17b Author: schien Date: 2011-06-08 10:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bae5f389d17b Merge Changeset: 9a4d09f33f01 Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9a4d09f33f01 Added tag jdk7-b146 for changeset bcd31fa1e3c6 ! .hgtags Changeset: 03692de33ca8 Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/03692de33ca8 Merge From lana.steuck at oracle.com Fri Jun 24 00:31:55 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 24 Jun 2011 00:31:55 +0000 Subject: hg: jdk8/tl/corba: 10 new changesets Message-ID: <20110624003212.371074729E@hg.openjdk.java.net> Changeset: 7033a5756ad5 Author: katleman Date: 2011-05-25 13:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7033a5756ad5 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! src/share/classes/com/sun/corba/se/impl/transport/CorbaTransportManagerImpl.java Changeset: 74eb715474f2 Author: schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/74eb715474f2 Added tag jdk7-b144 for changeset 7033a5756ad5 ! .hgtags Changeset: 93e77c49b3bb Author: miroslawzn Date: 2011-05-26 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/93e77c49b3bb 7046882: Regression : JDK 7b123 : Enum exchanged as parameters using CORBA call results in Exception Reviewed-by: raginip ! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java Changeset: 643f267ca234 Author: jeff Date: 2011-05-27 14:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/643f267ca234 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 7839048ec99e Author: jeff Date: 2011-05-27 15:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7839048ec99e Merge Changeset: 77ec0541aa2a Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/77ec0541aa2a Merge Changeset: 770227a4087e Author: schien Date: 2011-06-07 14:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/770227a4087e Added tag jdk7-b145 for changeset 77ec0541aa2a ! .hgtags Changeset: e85ff90212ad Author: schien Date: 2011-06-08 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/e85ff90212ad Merge Changeset: 36f0efbc66ef Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/36f0efbc66ef Added tag jdk7-b146 for changeset 770227a4087e ! .hgtags Changeset: abe4723b9b7f Author: schien Date: 2011-06-20 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/abe4723b9b7f Merge From lana.steuck at oracle.com Fri Jun 24 00:32:24 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 24 Jun 2011 00:32:24 +0000 Subject: hg: jdk8/tl/langtools: 27 new changesets Message-ID: <20110624003321.4549C4729F@hg.openjdk.java.net> Changeset: 8eb952f43b11 Author: katleman Date: 2011-05-25 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8eb952f43b11 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! src/share/classes/com/sun/source/tree/UnionTypeTree.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! test/tools/javac/4241573/T4241573.java ! test/tools/javac/6508981/TestInferBinaryName.java ! test/tools/javac/TryWithResources/DuplicateResource.java ! test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/T6838467.java ! test/tools/javac/api/T6877206.java ! test/tools/javac/api/TestClientCodeWrapper.java ! test/tools/javac/api/TestJavacTask_Lock.java ! test/tools/javac/api/TestJavacTask_Multiple.java ! test/tools/javac/api/TestJavacTask_ParseAttrGen.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java ! test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java ! test/tools/javac/tree/T6963934.java Changeset: 9f25c6a3ac23 Author: schien Date: 2011-05-26 20:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9f25c6a3ac23 Added tag jdk7-b144 for changeset 8eb952f43b11 ! .hgtags Changeset: 6bb526ccf5ff Author: mcimadamore Date: 2011-05-23 11:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6bb526ccf5ff 7046348: Regression: javac complains of missing classfile for a seemingly unrelated interface Summary: Types.implementation forces unnecessary symbol completion on superinterfaces of a given type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/scope/7046348/EagerInterfaceCompletionTest.java Changeset: 6211df69f7e0 Author: jeff Date: 2011-05-27 15:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6211df69f7e0 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 6762754eb7c0 Author: jjg Date: 2011-06-01 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6762754eb7c0 7042623: Regression: javac silently crash when attributing non-existent annotation Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/T7042623.java + test/tools/javac/T7042623.out Changeset: c455e2ae5c93 Author: lana Date: 2011-06-02 13:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c455e2ae5c93 Merge Changeset: 9ff91d0e7154 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9ff91d0e7154 Added tag jdk7-b145 for changeset c455e2ae5c93 ! .hgtags Changeset: f27b6f45a449 Author: schien Date: 2011-06-08 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f27b6f45a449 Merge Changeset: 347349c981f2 Author: jjh Date: 2011-06-09 09:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/347349c981f2 7052782: Two langtools regression tests fail due to fix for 7034977 which removed the invokeGeneric method Summary: Change the tests to call invoke instead of invokeGeneric Reviewed-by: jrose, mcimadamore ! test/tools/javac/meth/InvokeMH.java ! test/tools/javac/meth/XlintWarn.java Changeset: b8a2c9c87018 Author: lana Date: 2011-06-10 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b8a2c9c87018 Merge Changeset: 588d366d96df Author: asaha Date: 2011-04-21 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/588d366d96df Merge Changeset: 219b522d09e4 Author: asaha Date: 2011-05-04 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/219b522d09e4 Merge Changeset: 145d832616d3 Author: asaha Date: 2011-05-05 22:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/145d832616d3 Merge Changeset: 8b6e015ae7d0 Author: asaha Date: 2011-05-24 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b6e015ae7d0 Merge - test/tools/javac/generics/diamond/7030150/Neg01.java - test/tools/javac/generics/diamond/7030150/Neg01.out - test/tools/javac/generics/diamond/7030150/Neg02.java - test/tools/javac/generics/diamond/7030150/Neg02.out - test/tools/javac/generics/diamond/7030150/Neg03.java - test/tools/javac/generics/diamond/7030150/Neg03.out - test/tools/javac/generics/diamond/7030150/Pos01.java - test/tools/javac/generics/diamond/7030150/Pos02.java Changeset: 35cc19ae29b5 Author: asaha Date: 2011-05-26 17:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/35cc19ae29b5 Merge Changeset: 8b65930602c3 Author: asaha Date: 2011-05-26 21:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b65930602c3 Merge Changeset: 0adb806caf9d Author: asaha Date: 2011-06-06 10:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0adb806caf9d Merge Changeset: bb1fdcebde01 Author: asaha Date: 2011-06-03 07:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb1fdcebde01 Merge Changeset: 8ed03b0e3c9c Author: asaha Date: 2011-06-06 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8ed03b0e3c9c Merge Changeset: f494ca4bca0d Author: lana Date: 2011-06-15 16:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f494ca4bca0d Merge Changeset: 7eba9df190ae Author: bpatel Date: 2011-06-17 20:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7eba9df190ae 7052425: Change the look and feel of the javadoc generate HTML pages using stylesheet Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/background.gif - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/tab.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar.gif + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/titlebar_end.gif ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: c3a3440fe6e8 Author: bpatel Date: 2011-06-17 20:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c3a3440fe6e8 Merge Changeset: 9425dd4f53d5 Author: schien Date: 2011-06-18 09:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9425dd4f53d5 Merge Changeset: 436fb6aeda5a Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/436fb6aeda5a Added tag jdk7-b146 for changeset 9425dd4f53d5 ! .hgtags Changeset: 06b6bbbe2787 Author: schien Date: 2011-06-20 17:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/06b6bbbe2787 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: d59414955614 Author: lana Date: 2011-06-22 23:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d59414955614 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: 9eb36cac6b64 Author: lana Date: 2011-06-23 17:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9eb36cac6b64 Merge From lana.steuck at oracle.com Fri Jun 24 00:35:52 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 24 Jun 2011 00:35:52 +0000 Subject: hg: jdk8/tl/jdk: 93 new changesets Message-ID: <20110624005043.95DA0472A0@hg.openjdk.java.net> Changeset: 23bdcede4e39 Author: katleman Date: 2011-05-25 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23bdcede4e39 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! src/linux/doc/man/ja/keytool.1 ! src/linux/doc/man/keytool.1 ! src/share/classes/java/io/SerialCallbackContext.java ! src/share/classes/sun/io/ByteToCharCp833.java ! src/share/classes/sun/io/CharToByteCp833.java ! src/share/classes/sun/misc/FpUtils.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/solaris/doc/sun/man/man1/ja/keytool.1 ! src/solaris/doc/sun/man/man1/keytool.1 ! test/com/sun/net/httpserver/Test10.java ! test/java/awt/List/ScrollOutside/ScrollOut.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_1.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.java ! test/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_4.java ! test/java/awt/image/IncorrectSampleMaskTest.java ! test/java/lang/invoke/MethodTypeTest.java ! test/java/rmi/server/UnicastRemoteObject/exportObject/GcDuringExport.java ! test/java/util/EnumMap/DistinctEntrySetElements.java ! test/java/util/EnumMap/EntrySetIteratorRemoveInvalidatesEntry.java ! test/java/util/EnumMap/SimpleSerialization.java ! test/java/util/EnumSet/LargeEnumIteratorRemoveResilience.java ! test/java/util/EnumSet/SmallEnumIteratorRemoveResilience.java ! test/java/util/Hashtable/SerializationDeadlock.java ! test/java/util/Hashtable/SimpleSerialization.java ! test/java/util/IdentityHashMap/DistinctEntrySetElements.java ! test/java/util/IdentityHashMap/EntrySetIteratorRemoveInvalidatesEntry.java ! test/java/util/Vector/SerializationDeadlock.java ! test/java/util/Vector/SimpleSerialization.java ! test/java/util/concurrent/ConcurrentHashMap/DistinctEntrySetElements.java ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java ! test/sun/net/InetAddress/nameservice/chaining/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor ! test/tools/launcher/TestHelper.java ! test/tools/pack200/CommandLineTests.java ! test/tools/pack200/Pack200Test.java ! test/tools/pack200/Utils.java Changeset: c344779fab58 Author: schien Date: 2011-05-26 20:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c344779fab58 Added tag jdk7-b144 for changeset 23bdcede4e39 ! .hgtags Changeset: f09930d526ba Author: jrose Date: 2011-05-26 17:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f09930d526ba 7032323: code changes for JSR 292 EG adjustments to API, through Public Review Summary: API code changes and javadoc changes following JSR 292 Public Review comments, through PFD Reviewed-by: never ! src/share/classes/java/lang/BootstrapMethodError.java ! src/share/classes/java/lang/ClassValue.java ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/ConstantCallSite.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SwitchPoint.java ! src/share/classes/java/lang/invoke/package-info.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! src/share/classes/sun/invoke/util/VerifyAccess.java ! src/share/classes/sun/invoke/util/Wrapper.java ! test/java/lang/invoke/6998541/Test6998541.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/indify/Indify.java Changeset: 81f957f86ba5 Author: jcoomes Date: 2011-05-27 19:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81f957f86ba5 Merge Changeset: bc97b962330e Author: mfang Date: 2011-05-26 20:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc97b962330e 7045184: GTK L&F doesn't have hotkeys in jdk7 b141, while b139 has. Reviewed-by: yhuang, ogino ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties Changeset: 6943c4d9caa3 Author: mfang Date: 2011-05-31 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6943c4d9caa3 Merge Changeset: 7c5bc5a807ee Author: dholmes Date: 2011-05-27 19:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c5bc5a807ee 7024120: Verify reduced JRE contents for java 7 Summary: stripped all symbols from libs and executables to reduce JRE size. Restored missing classes needed to pass JCK in headless mode Reviewed-by: bobv, ohair ! make/common/Defs-embedded.gmk ! make/common/Release-embedded.gmk Changeset: f4895b3fe1be Author: dholmes Date: 2011-05-31 17:28 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4895b3fe1be Merge Changeset: eab27338b3d9 Author: schien Date: 2011-06-01 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab27338b3d9 Merge Changeset: 8d91855a1f4e Author: prr Date: 2011-05-27 13:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d91855a1f4e 7046587: Outlines in OTF/CFF fonts are misclassified as quadratic curves Reviewed-by: igor ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/NullFontScaler.java Changeset: 0b0b92707cf5 Author: bae Date: 2011-05-30 12:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b0b92707cf5 7032904: XRender: Java2Demo : Infinite loop in Java_sun_java2d_loops_MaskBlit_MaskBlit on OEL 5.6 x64 Reviewed-by: prr ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 290daca0a693 Author: prr Date: 2011-05-30 22:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/290daca0a693 7049874: OpenJDK Build breakage fix: freetypescaler.c needs to match updated signature Reviewed-by: lana, igor ! src/share/native/sun/font/freetypeScaler.c Changeset: b351af09bfa3 Author: lana Date: 2011-06-02 13:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b351af09bfa3 Merge Changeset: d2081a1f417f Author: bagiras Date: 2011-05-27 11:45 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d2081a1f417f 7045174: Most of the tests in awt area fails with jdk 7b142 on windows with -Xcheck:jni Reviewed-by: art, denis ! src/windows/native/sun/windows/awt_Object.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp Changeset: 000a845b1e38 Author: denis Date: 2011-05-28 12:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/000a845b1e38 7046325: Broken links in java.awt.Toolkit's javadoc Reviewed-by: dav, yan ! src/share/classes/java/awt/Toolkit.java Changeset: eab94f59b6dc Author: dcherepanov Date: 2011-05-30 13:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eab94f59b6dc 7045354: Korean IME's Hanja candidate window is not displayed on IMFDemo Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Component.cpp Changeset: f05164caa490 Author: serb Date: 2011-05-30 17:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f05164caa490 7045193: interactive JCK tests java_awt/interactive/FileDialogTests fail Reviewed-by: dcherepanov, dav, art, denis ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java Changeset: b955226868af Author: lana Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b955226868af Merge Changeset: 1fbaf2b688a6 Author: rupashka Date: 2011-05-24 11:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fbaf2b688a6 7045593: Possible Regression : JTextfield cursor placement behavior algorithm has changed. Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java + test/javax/swing/text/Utilities/bug7045593.java Changeset: 442237d3ec2c Author: rupashka Date: 2011-05-28 11:55 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/442237d3ec2c 7048204: NPE from NimbusLookAndFeel.addDefault Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/Test7048204.java Changeset: 386516fdf40b Author: lana Date: 2011-06-02 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/386516fdf40b Merge Changeset: 0a80650409e1 Author: mullan Date: 2011-05-24 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a80650409e1 7044443: Permissions resolved incorrectly for jar protocol (Patch from bugs.openjdk.java.net) Reviewed-by: alanb, chegar Contributed-by: dbhole at redhat.com ! src/share/classes/sun/security/provider/PolicyFile.java + test/java/security/Policy/GetPermissions/JarURL.java Changeset: ace2dfdecda1 Author: mullan Date: 2011-05-24 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ace2dfdecda1 Merge Changeset: 70942be348af Author: jeff Date: 2011-05-27 15:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70942be348af 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: b49a0af85821 Author: vinnie Date: 2011-05-30 16:37 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b49a0af85821 7049173: Replace the software license for ECC native code Reviewed-by: alanb ! src/share/native/sun/security/ec/impl/ec.c ! src/share/native/sun/security/ec/impl/ec.h ! src/share/native/sun/security/ec/impl/ec2.h ! src/share/native/sun/security/ec/impl/ec2_163.c ! src/share/native/sun/security/ec/impl/ec2_193.c ! src/share/native/sun/security/ec/impl/ec2_233.c ! src/share/native/sun/security/ec/impl/ec2_aff.c ! src/share/native/sun/security/ec/impl/ec2_mont.c ! src/share/native/sun/security/ec/impl/ec_naf.c ! src/share/native/sun/security/ec/impl/ecc_impl.h ! src/share/native/sun/security/ec/impl/ecdecode.c ! src/share/native/sun/security/ec/impl/ecl-curve.h ! src/share/native/sun/security/ec/impl/ecl-exp.h ! src/share/native/sun/security/ec/impl/ecl-priv.h ! src/share/native/sun/security/ec/impl/ecl.c ! src/share/native/sun/security/ec/impl/ecl.h ! src/share/native/sun/security/ec/impl/ecl_curve.c ! src/share/native/sun/security/ec/impl/ecl_gf.c ! src/share/native/sun/security/ec/impl/ecl_mult.c ! src/share/native/sun/security/ec/impl/ecp.h ! src/share/native/sun/security/ec/impl/ecp_192.c ! src/share/native/sun/security/ec/impl/ecp_224.c ! src/share/native/sun/security/ec/impl/ecp_256.c ! src/share/native/sun/security/ec/impl/ecp_384.c ! src/share/native/sun/security/ec/impl/ecp_521.c ! src/share/native/sun/security/ec/impl/ecp_aff.c ! src/share/native/sun/security/ec/impl/ecp_jac.c ! src/share/native/sun/security/ec/impl/ecp_jm.c ! src/share/native/sun/security/ec/impl/ecp_mont.c ! src/share/native/sun/security/ec/impl/logtab.h ! src/share/native/sun/security/ec/impl/mp_gf2m-priv.h ! src/share/native/sun/security/ec/impl/mp_gf2m.c ! src/share/native/sun/security/ec/impl/mp_gf2m.h ! src/share/native/sun/security/ec/impl/mpi-config.h ! src/share/native/sun/security/ec/impl/mpi-priv.h ! src/share/native/sun/security/ec/impl/mpi.c ! src/share/native/sun/security/ec/impl/mpi.h ! src/share/native/sun/security/ec/impl/mplogic.c ! src/share/native/sun/security/ec/impl/mplogic.h ! src/share/native/sun/security/ec/impl/mpmontg.c ! src/share/native/sun/security/ec/impl/mpprime.h ! src/share/native/sun/security/ec/impl/oid.c ! src/share/native/sun/security/ec/impl/secitem.c ! src/share/native/sun/security/ec/impl/secoidt.h Changeset: 4ed7c877a463 Author: michaelm Date: 2011-05-30 23:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ed7c877a463 7042550: Reintegrate 6569621 Reviewed-by: chegar, alanb ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketPermission.java + src/share/classes/sun/net/RegisteredDomain.java ! src/share/classes/sun/net/www/URLConnection.java ! src/share/classes/sun/net/www/http/HttpClient.java Changeset: c79a089ae13b Author: wetmore Date: 2011-05-31 12:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c79a089ae13b 7042097: JDK 7's Unlimited Cryptographic Policy bundle text files must be updated. Reviewed-by: valeriep ! make/javax/crypto/Makefile Changeset: a00f48c96345 Author: lancea Date: 2011-06-02 12:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a00f48c96345 7049107: Cannot call initCause() on BatchUpdateException Reviewed-by: darcy ! src/share/classes/java/sql/BatchUpdateException.java Changeset: 39de8937c1d8 Author: lana Date: 2011-06-02 13:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39de8937c1d8 Merge Changeset: 8318d03e1766 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8318d03e1766 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Wrap invokedynamic linkage errors in BootstrapMethodError, as needed. Reviewed-by: never ! src/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 0b8b6eace473 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b8b6eace473 7050328: (jsr-292) findConstructor throws ExceptionInInitializerError if run under SecurityManager Summary: Wrap system property and reflection accesses under doPrivileged. Ensure constant pool linkage bypasses the SM as specified. Reviewed-by: kvn, never ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java Changeset: 34481a4012c3 Author: jrose Date: 2011-06-01 23:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34481a4012c3 7049122: java/lang/invoke/RicochetTest.java with MAX_ARITY=255 in -Xcomp mode overflows code cache Summary: reduce the scope of the unit test (mark high water mark of testing with @ignore tags) Reviewed-by: never ! test/java/lang/invoke/RicochetTest.java Changeset: 802994506203 Author: jrose Date: 2011-06-03 11:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/802994506203 7051206: JSR 292 method name SwitchPoint.isValid is misleading to unwary users; should be hasBeenInvalidated Reviewed-by: kvn, never, ysr ! src/share/classes/java/lang/invoke/SwitchPoint.java ! test/java/lang/invoke/JavaDocExamplesTest.java Changeset: e8e6cdff5995 Author: trims Date: 2011-06-03 20:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8e6cdff5995 Merge Changeset: 8f19b165347b Author: bae Date: 2011-06-04 23:08 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f19b165347b 7042594: 3 testis api/java_awt/Color/ICC_ProfileRGB/index.html fail against RI b138 OEL6x64. Reviewed-by: prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! test/sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java + test/sun/java2d/cmm/ProfileOp/SetDataTest.java Changeset: bbb4cef2208b Author: lana Date: 2011-06-04 17:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbb4cef2208b Merge Changeset: 03a828e368ca Author: rupashka Date: 2011-06-04 01:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/03a828e368ca 6977587: GTK L&F: jnlp: java.io.IOException thrown when choosing more than 1 file in the dialog Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java Changeset: 6c9c55ae313b Author: lana Date: 2011-06-03 22:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c9c55ae313b Merge Changeset: e81d259442ed Author: lana Date: 2011-06-04 17:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e81d259442ed Merge Changeset: 53d759eb580c Author: alanb Date: 2011-06-04 11:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53d759eb580c 7050358: (fs spec) Path.toUri doesn't allow custom providers to use opaque URIs Reviewed-by: sherman ! src/share/classes/java/nio/file/Path.java Changeset: 49aef5a5416e Author: mullan Date: 2011-06-04 06:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49aef5a5416e 7050329: test/java/security/Policy/GetPermissions/JarURL.java fails on Windows Reviewed-by: alanb ! test/java/security/Policy/GetPermissions/JarURL.java + test/java/security/Policy/GetPermissions/JarURL.policy Changeset: 1f39ca0b9598 Author: mullan Date: 2011-06-04 06:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f39ca0b9598 Merge Changeset: 1e04b38b3824 Author: lana Date: 2011-06-04 17:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1e04b38b3824 Merge Changeset: 7a341c412ea9 Author: schien Date: 2011-06-07 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a341c412ea9 Added tag jdk7-b145 for changeset 1e04b38b3824 ! .hgtags Changeset: e7493c32e598 Author: schien Date: 2011-06-08 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7493c32e598 Merge Changeset: ae731399e525 Author: dav Date: 2011-06-07 22:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae731399e525 7048568: Crash in Java_sun_awt_Win32GraphicsEnvironment_isVistaOS Reviewed-by: dcherepanov, art, amenkov ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp Changeset: f08fcae94813 Author: lana Date: 2011-06-10 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f08fcae94813 Merge Changeset: 6e961c328276 Author: michaelm Date: 2011-06-08 10:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e961c328276 7050028: ISE "zip file closed" from JarURLConnection.getInputStream on JDK 7 when !useCaches Reviewed-by: chegar, alanb ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/B7050028.java Changeset: b6ced5ad7a62 Author: dwanvik Date: 2011-06-10 17:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6ced5ad7a62 7046557: Changes to the Java DB README files in JDK7 Summary: Update /README.html with correct mention of Java DB, add JDK specific README files to /db and /demo/db. Reviewed-by: ohair ! make/common/Release.gmk Changeset: 646ab254ff80 Author: lana Date: 2011-06-10 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/646ab254ff80 Merge Changeset: aca0dc2b921c Author: weijun Date: 2011-02-09 11:50 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aca0dc2b921c 6618658: Deserialization allows creation of mutable SignedObject Reviewed-by: hawtin, mullan ! src/share/classes/java/security/SignedObject.java + test/java/security/SignedObject/Correctness.java Changeset: df445f522425 Author: bae Date: 2011-02-17 12:21 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df445f522425 7013519: [parfait] Integer overflows in 2D code Reviewed-by: prr, valeriep ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/font/layout/SunLayoutEngine.cpp Changeset: ccb2fcfb6d6b Author: chegar Date: 2011-02-18 13:31 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ccb2fcfb6d6b 7013969: NetworkInterface.toString can reveal bindings Reviewed-by: alanb, michaelm, hawtin ! src/share/classes/java/net/NetworkInterface.java Changeset: 026adaac71f1 Author: dcherepanov Date: 2011-02-25 15:54 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/026adaac71f1 7012520: Heap overflow vulnerability in FileDialog.show() Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_FileDialog.cpp Changeset: d489f00d6c65 Author: flar Date: 2011-03-02 05:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d489f00d6c65 7016495: Crash in Java 2D transforming an image with scale close to zero Reviewed-by: prr, bae ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/native/sun/java2d/loops/TransformHelper.c + test/java/awt/image/BufferedImage/TinyScale.java Changeset: fe27fe44ac51 Author: ksrini Date: 2011-03-03 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe27fe44ac51 7016985: (launcher) implement safe secure dll loading Reviewed-by: mchung ! src/windows/bin/java_md.c Changeset: 0efa64f13302 Author: chegar Date: 2011-04-05 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0efa64f13302 7033865: JDK: Add private API for secure/restrictive loading of system dlls Reviewed-by: alanb ! src/share/native/common/jdk_util.h + src/solaris/native/common/jdk_util_md.h ! src/windows/native/common/jdk_util_md.c + src/windows/native/common/jdk_util_md.h Changeset: 67992a58bfba Author: ksrini Date: 2011-04-05 16:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67992a58bfba 7032593: DLL_LOADING: Upgrade solution to 7016985 to reflect JDK7 solution Reviewed-by: mchung, asaha ! src/windows/bin/java_md.c Changeset: 7181441faf72 Author: dcherepanov Date: 2011-04-08 16:44 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7181441faf72 7003962: AWT: securely load DLLs and launch executables using fully qualified path Reviewed-by: art, bae, alanb ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/java2d/opengl/OGLFuncs_md.h ! src/windows/native/sun/windows/DllUtil.cpp ! src/windows/native/sun/windows/DllUtil.h ! src/windows/native/sun/windows/ShellFolder2.cpp ! src/windows/native/sun/windows/ThemeReader.cpp ! src/windows/native/sun/windows/awt_Mlib.cpp ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/stdhdrs.h Changeset: 05a3923f516f Author: dcherepanov Date: 2011-04-08 17:58 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05a3923f516f 7035077: Minor addition to the changes for 7003962 Reviewed-by: chegar ! src/windows/native/sun/windows/DllUtil.cpp Changeset: afcc1530e68b Author: asaha Date: 2011-04-08 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afcc1530e68b Merge - make/java/dyn/Makefile - src/share/classes/java/dyn/CallSite.java - src/share/classes/java/dyn/ClassValue.java - src/share/classes/java/dyn/ConstantCallSite.java - src/share/classes/java/dyn/InvokeDynamic.java - src/share/classes/java/dyn/InvokeDynamicBootstrapError.java - src/share/classes/java/dyn/Linkage.java - src/share/classes/java/dyn/MethodHandle.java - src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/MethodType.java - src/share/classes/java/dyn/MethodTypeForm.java - src/share/classes/java/dyn/MutableCallSite.java - src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/VolatileCallSite.java - src/share/classes/java/dyn/WrongMethodTypeException.java - src/share/classes/java/dyn/package-info.java - src/share/classes/sun/dyn/Access.java - src/share/classes/sun/dyn/AdapterMethodHandle.java - src/share/classes/sun/dyn/BoundMethodHandle.java - src/share/classes/sun/dyn/CallSiteImpl.java - src/share/classes/sun/dyn/DirectMethodHandle.java - src/share/classes/sun/dyn/FilterGeneric.java - src/share/classes/sun/dyn/FilterOneArgument.java - src/share/classes/sun/dyn/FromGeneric.java - src/share/classes/sun/dyn/InvokeGeneric.java - src/share/classes/sun/dyn/Invokers.java - src/share/classes/sun/dyn/MemberName.java - src/share/classes/sun/dyn/MethodHandleImpl.java - src/share/classes/sun/dyn/MethodHandleNatives.java - src/share/classes/sun/dyn/MethodTypeImpl.java - src/share/classes/sun/dyn/SpreadGeneric.java - src/share/classes/sun/dyn/ToGeneric.java - src/share/classes/sun/dyn/WrapperInstance.java - src/share/classes/sun/dyn/anon/AnonymousClassLoader.java - src/share/classes/sun/dyn/anon/ConstantPoolParser.java - src/share/classes/sun/dyn/anon/ConstantPoolPatch.java - src/share/classes/sun/dyn/anon/ConstantPoolVisitor.java - src/share/classes/sun/dyn/anon/InvalidConstantPoolFormatException.java - src/share/classes/sun/dyn/empty/Empty.java - src/share/classes/sun/dyn/package-info.java - src/share/classes/sun/dyn/util/BytecodeDescriptor.java - src/share/classes/sun/dyn/util/BytecodeName.java - src/share/classes/sun/dyn/util/ValueConversions.java - src/share/classes/sun/dyn/util/VerifyAccess.java - src/share/classes/sun/dyn/util/VerifyType.java - src/share/classes/sun/dyn/util/Wrapper.java - src/share/classes/sun/dyn/util/package-info.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c - test/java/dyn/ClassValueTest.java - test/java/dyn/InvokeDynamicPrintArgs.java - test/java/dyn/InvokeGenericTest.java - test/java/dyn/JavaDocExamplesTest.java - test/java/dyn/MethodHandlesTest.java - test/java/dyn/MethodTypeTest.java - test/java/dyn/indify/Indify.java Changeset: 557bd9b5d92f Author: asaha Date: 2011-04-08 10:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/557bd9b5d92f Merge Changeset: e142148d8b54 Author: asaha Date: 2011-04-12 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e142148d8b54 Merge - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java Changeset: 76e0e562b617 Author: dcherepanov Date: 2011-04-15 17:06 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76e0e562b617 7036952: build warning after the changes for 7003962 Reviewed-by: art, bae ! src/windows/native/sun/java2d/opengl/OGLFuncs_md.h Changeset: f8eddc85cc02 Author: zgu Date: 2011-04-15 09:53 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8eddc85cc02 7003964: SERV: securely load DLLs and launch executables using fully qualified path Summary: Linked in Windows libraries that are available on jdk7 supported platforms, and used GetModuleHandle instead of LoadLibrary for already loaded Dlls. Reviewed-by: dcubed, alanb ! make/com/sun/tools/attach/Makefile ! src/windows/classes/sun/tools/attach/WindowsAttachProvider.java ! src/windows/native/sun/tools/attach/WindowsAttachProvider.c ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c ! src/windows/native/sun/tracing/dtrace/jvm_symbols_md.c ! src/windows/npt/npt_md.h Changeset: 0865aa0ad9b2 Author: zgu Date: 2011-04-19 10:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0865aa0ad9b2 Merge Changeset: 6f8a4d334fb2 Author: asaha Date: 2011-04-20 09:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f8a4d334fb2 Merge ! make/com/sun/tools/attach/Makefile ! src/share/classes/java/net/NetworkInterface.java ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/windows/bin/java_md.c ! src/windows/native/sun/windows/awt_TrayIcon.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp Changeset: f3645b5d6e62 Author: asaha Date: 2011-04-20 21:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3645b5d6e62 Merge Changeset: b626f78c57e1 Author: asaha Date: 2011-04-21 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b626f78c57e1 Merge Changeset: cec45f3353be Author: asaha Date: 2011-04-21 08:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cec45f3353be Merge Changeset: 6133c9ee3a01 Author: asaha Date: 2011-04-21 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6133c9ee3a01 Merge Changeset: dd06e8d3da91 Author: asaha Date: 2011-04-21 15:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd06e8d3da91 Merge Changeset: b2295905901a Author: asaha Date: 2011-04-21 16:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2295905901a Merge - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java Changeset: 3fedf261fb4f Author: valeriep Date: 2011-04-26 15:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fedf261fb4f 7003952: SEC: securely load DLLs and launch executables using fully qualified path Summary: Enforce full path when specifying library locations. Reviewed-by: wetmore, ohair ! make/sun/security/pkcs11/Makefile ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/native/sun/security/pkcs11/j2secmod.c + test/sun/security/pkcs11/Provider/Absolute.cfg + test/sun/security/pkcs11/Provider/Absolute.java Changeset: 94ea3b8288f1 Author: alexp Date: 2011-05-04 11:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94ea3b8288f1 7020198: ImageIcon creates Component with null acc Reviewed-by: rupashka, hawtin ! src/share/classes/javax/swing/ImageIcon.java Changeset: e6fdfb249e31 Author: asaha Date: 2011-05-04 16:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6fdfb249e31 Merge - src/share/native/sun/font/layout/Features.h ! src/windows/native/sun/windows/awt_FileDialog.cpp - test/javax/swing/text/GlyphView/6539700/bug6539700.java Changeset: 49244980d692 Author: asaha Date: 2011-05-05 22:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49244980d692 Merge - src/share/classes/sun/security/util/SignatureFileManifest.java Changeset: 647b031200f0 Author: asaha Date: 2011-05-06 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/647b031200f0 Merge Changeset: 92b5197e9ff5 Author: asaha Date: 2011-05-26 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92b5197e9ff5 Merge ! src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp ! src/windows/native/sun/windows/awt_TrayIcon.cpp Changeset: cca9ea306c6e Author: asaha Date: 2011-05-26 21:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cca9ea306c6e Merge Changeset: dab3e66ebda7 Author: lana Date: 2011-06-06 19:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dab3e66ebda7 Merge Changeset: 9f17be5136d1 Author: wetmore Date: 2011-06-09 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f17be5136d1 7052537: java/security/Security/NotInstalledProviders.java is causing -samevm tests to fail. Reviewed-by: valeriep, asaha, alanb ! test/java/security/Security/NoInstalledProviders.java Changeset: 4961be00d3b5 Author: lana Date: 2011-06-15 16:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4961be00d3b5 Merge Changeset: cf0632d2db2c Author: jrose Date: 2011-06-14 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf0632d2db2c 7052202: JSR 292: Crash in sun.invoke.util.ValueConversions.fillArray Summary: Fix corner cases involving MethodHandles.permuteArguments with long or double argument lists. Reviewed-by: twisti, never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/SwitchPoint.java + test/java/lang/invoke/PermuteArgsTest.java Changeset: a65fa0f6717e Author: trims Date: 2011-06-17 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a65fa0f6717e Merge Changeset: c46f97579fe6 Author: alanb Date: 2011-06-17 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c46f97579fe6 7055508: (aio) EXCEPTION_ACCESS_VIOLATION in AsynchronousSocketChannel.connect on Windows 7 Reviewed-by: chegar ! src/windows/native/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.c Changeset: c102e1221afa Author: lana Date: 2011-06-17 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c102e1221afa Merge Changeset: 539e576793a8 Author: lana Date: 2011-06-18 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/539e576793a8 Merge Changeset: 7b4f4230fecf Author: schien Date: 2011-06-20 16:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b4f4230fecf Added tag jdk7-b146 for changeset 539e576793a8 ! .hgtags Changeset: f2928d86aab0 Author: schien Date: 2011-06-20 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2928d86aab0 Merge Changeset: 5838c5bd185d Author: lana Date: 2011-06-22 23:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5838c5bd185d Merge ! src/share/classes/java/awt/Toolkit.java ! test/java/security/Security/NoInstalledProviders.java Changeset: 5dedb265ba3e Author: lana Date: 2011-06-23 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5dedb265ba3e Merge Changeset: b037a8bc1be8 Author: lana Date: 2011-06-23 17:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b037a8bc1be8 Merge From alan.bateman at oracle.com Fri Jun 24 18:32:51 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 24 Jun 2011 18:32:51 +0000 Subject: hg: jdk8/tl/jdk: 6965150: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java takes too long Message-ID: <20110624183316.F009A472D9@hg.openjdk.java.net> Changeset: 0ad50d4ed1cf Author: alanb Date: 2011-06-24 19:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ad50d4ed1cf 6965150: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java takes too long Reviewed-by: chegar ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java From joe.darcy at oracle.com Fri Jun 24 20:52:35 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 24 Jun 2011 20:52:35 +0000 Subject: hg: jdk8/tl/langtools: 6575445: Update annotation processor to only use java.util.ServiceLoader Message-ID: <20110624205237.9EB87472E2@hg.openjdk.java.net> Changeset: f74e4269a50a Author: darcy Date: 2011-06-24 13:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f74e4269a50a 6575445: Update annotation processor to only use java.util.ServiceLoader Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt From michael.x.mcmahon at oracle.com Mon Jun 27 11:16:56 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Mon, 27 Jun 2011 11:16:56 +0000 Subject: hg: jdk8/tl/jdk: 7059777: Remove lang tests from Problemlist.txt Message-ID: <20110627111719.E2DF647365@hg.openjdk.java.net> Changeset: 113c75db6c8b Author: michaelm Date: 2011-06-27 12:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/113c75db6c8b 7059777: Remove lang tests from Problemlist.txt Reviewed-by: alanb ! test/ProblemList.txt From sean.mullan at oracle.com Mon Jun 27 13:01:27 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 27 Jun 2011 09:01:27 -0400 Subject: Bug 4715154 Message-ID: <4E087F27.70202@oracle.com> Several jigsaw unit tests are failing on Windows because of bug 4715154 [1] which was closed a long time ago as "Will Not Fix". Does anyone have any suggestions as the best way to workaround this, short of replacing the call to FileChannel.map with FileChannel.read? Are there any plans to fix this in the future? Thanks, Sean [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4715154 From Alan.Bateman at oracle.com Mon Jun 27 13:19:04 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 27 Jun 2011 14:19:04 +0100 Subject: Bug 4715154 In-Reply-To: <4E087F27.70202@oracle.com> References: <4E087F27.70202@oracle.com> Message-ID: <4E088348.4050409@oracle.com> Sean Mullan wrote: > Several jigsaw unit tests are failing on Windows because of bug > 4715154 [1] which was closed a long time ago as "Will Not Fix". Does > anyone have any suggestions as the best way to workaround this, short > of replacing the call to FileChannel.map with FileChannel.read? Are > there any plans to fix this in the future? > > Thanks, > Sean > > [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4715154 This is a limitation of Windows and I'm not aware of any way to create a file-mapping that would allow the file be deleted while the mapping exists (if there is a way then it would be great to know about it). In a couple of tests we've had to do an ugly System.gc() + short sleep at the end of the test to trigger the unmap. -Alan From sean.mullan at oracle.com Mon Jun 27 13:48:44 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 27 Jun 2011 09:48:44 -0400 Subject: Bug 4715154 In-Reply-To: <4E088348.4050409@oracle.com> References: <4E087F27.70202@oracle.com> <4E088348.4050409@oracle.com> Message-ID: <4E088A3C.3010809@oracle.com> On 6/27/11 9:19 AM, Alan Bateman wrote: > Sean Mullan wrote: >> Several jigsaw unit tests are failing on Windows because of bug 4715154 [1] >> which was closed a long time ago as "Will Not Fix". Does anyone have any >> suggestions as the best way to workaround this, short of replacing the call to >> FileChannel.map with FileChannel.read? Are there any plans to fix this in the >> future? >> >> Thanks, >> Sean >> >> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4715154 > This is a limitation of Windows and I'm not aware of any way to create a > file-mapping that would allow the file be deleted while the mapping exists (if > there is a way then it would be great to know about it). In a couple of tests > we've had to do an ugly System.gc() + short sleep at the end of the test to > trigger the unmap. It isn't only deleting the file that causes problems. If you try to subsequently open the file and do other operations on it, they can fail, and we do this when signing jmod files. We may be able to avoid calling FileChannel.map. I'm looking more into it ... --Sean From sean.mullan at oracle.com Mon Jun 27 15:57:33 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 27 Jun 2011 11:57:33 -0400 Subject: Bug 4715154 In-Reply-To: <4E088348.4050409@oracle.com> References: <4E087F27.70202@oracle.com> <4E088348.4050409@oracle.com> Message-ID: <4E08A86D.4010101@oracle.com> Hey Alan, Would it be a good idea if we add this Windows limitation to the NIO javadocs somewhere, say in the FileChannel class? I spent a lot of time chasing this down until I finally figured out it was a known issue. --Sean On 6/27/11 9:19 AM, Alan Bateman wrote: > Sean Mullan wrote: >> Several jigsaw unit tests are failing on Windows because of bug 4715154 [1] >> which was closed a long time ago as "Will Not Fix". Does anyone have any >> suggestions as the best way to workaround this, short of replacing the call to >> FileChannel.map with FileChannel.read? Are there any plans to fix this in the >> future? >> >> Thanks, >> Sean >> >> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4715154 > This is a limitation of Windows and I'm not aware of any way to create a > file-mapping that would allow the file be deleted while the mapping exists (if > there is a way then it would be great to know about it). In a couple of tests > we've had to do an ugly System.gc() + short sleep at the end of the test to > trigger the unmap. > > -Alan From Ulf.Zibis at gmx.de Mon Jun 27 16:03:00 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 27 Jun 2011 18:03:00 +0200 Subject: Bug 4715154 In-Reply-To: <4E08A86D.4010101@oracle.com> References: <4E087F27.70202@oracle.com> <4E088348.4050409@oracle.com> <4E08A86D.4010101@oracle.com> Message-ID: <4E08A9B4.4000101@gmx.de> +1 -Ulf Am 27.06.2011 17:57, schrieb Sean Mullan: > Hey Alan, > > Would it be a good idea if we add this Windows limitation to the NIO javadocs somewhere, say in > the FileChannel class? I spent a lot of time chasing this down until I finally figured out it was > a known issue. > > --Sean > > On 6/27/11 9:19 AM, Alan Bateman wrote: >> Sean Mullan wrote: >>> Several jigsaw unit tests are failing on Windows because of bug 4715154 [1] >>> which was closed a long time ago as "Will Not Fix". Does anyone have any >>> suggestions as the best way to workaround this, short of replacing the call to >>> FileChannel.map with FileChannel.read? Are there any plans to fix this in the >>> future? >>> >>> Thanks, >>> Sean >>> >>> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4715154 >> This is a limitation of Windows and I'm not aware of any way to create a >> file-mapping that would allow the file be deleted while the mapping exists (if >> there is a way then it would be great to know about it). In a couple of tests >> we've had to do an ugly System.gc() + short sleep at the end of the test to >> trigger the unmap. >> >> -Alan > From forax at univ-mlv.fr Mon Jun 27 17:07:14 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Mon, 27 Jun 2011 19:07:14 +0200 Subject: Bug 4715154 In-Reply-To: <4E08A9B4.4000101@gmx.de> References: <4E087F27.70202@oracle.com> <4E088348.4050409@oracle.com> <4E08A86D.4010101@oracle.com> <4E08A9B4.4000101@gmx.de> Message-ID: <4E08B8C2.1090608@univ-mlv.fr> Yes, make sense. R?mi On 06/27/2011 06:03 PM, Ulf Zibis wrote: > +1 > > -Ulf > > > Am 27.06.2011 17:57, schrieb Sean Mullan: >> Hey Alan, >> >> Would it be a good idea if we add this Windows limitation to the NIO >> javadocs somewhere, say in the FileChannel class? I spent a lot of >> time chasing this down until I finally figured out it was a known issue. >> >> --Sean >> >> On 6/27/11 9:19 AM, Alan Bateman wrote: >>> Sean Mullan wrote: >>>> Several jigsaw unit tests are failing on Windows because of bug >>>> 4715154 [1] >>>> which was closed a long time ago as "Will Not Fix". Does anyone >>>> have any >>>> suggestions as the best way to workaround this, short of replacing >>>> the call to >>>> FileChannel.map with FileChannel.read? Are there any plans to fix >>>> this in the >>>> future? >>>> >>>> Thanks, >>>> Sean >>>> >>>> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4715154 >>> This is a limitation of Windows and I'm not aware of any way to >>> create a >>> file-mapping that would allow the file be deleted while the mapping >>> exists (if >>> there is a way then it would be great to know about it). In a couple >>> of tests >>> we've had to do an ugly System.gc() + short sleep at the end of the >>> test to >>> trigger the unmap. >>> >>> -Alan >> From kumar.x.srinivasan at oracle.COM Mon Jun 27 17:14:17 2011 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Mon, 27 Jun 2011 10:14:17 -0700 Subject: Trivial: 1 char fix : java launcher help message fix. In-Reply-To: <4E011872.7010201@oracle.COM> References: <4E00E1B0.4030709@oracle.COM> <4E00F1BE.9070000@oracle.com> <4E00FE07.3070305@oracle.com> <4E011872.7010201@oracle.COM> Message-ID: <4E08BA69.5080108@oracle.COM> An update on this, found that though the changes are trivial in the properties file, there are other changes required in the launcher, which is beyond the anticipated scope. We decided to leave this alone for now. So I will go ahead and push the already reviewed (Joe and Alan) changes. Thanks Kumar > > >> On 06/21/2011 12:32 PM, Xueming Shen wrote: >>> OK, it's a nit-pick and it has nothing to do with this fix, and it >>> probably has been there from day >>> one. But just wonder if those "%n" should be replaced by "/n" in >>> those properties file, otherwise >> >> I meant to say "the /n should be replaced by %n". > > should be "\n" replaced by "%n", Ok, since I am here, I will fix this > too, > lookout for a new webrev. > > < I guess it will no longer be a trivial 2 char fix. :-( > > > > Kumar >> >>> my guess is that the result of java -help will not have the correct >>> line-end on Windows platform. >>> For example if the result is re-directed into a file, that file >>> probably can not be displayed in >>> notepad correctly... >>> >>> -Sherman >>> >>> On 06/21/2011 11:23 AM, Kumar Srinivasan wrote: >>>> Hi, >>>> >>>> Please review ... >>>> >>>> http://cr.openjdk.java.net/~ksrini/7046007/webrev.0/ >>>> http://cr.openjdk.java.net/~ksrini/7046007/cmt.txt >>>> >>>> Thanks >>>> Kumar >>>> >>> >> > From kumar.x.srinivasan at oracle.com Mon Jun 27 19:22:43 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 27 Jun 2011 19:22:43 +0000 Subject: hg: jdk8/tl/jdk: 7046007: (launcher) Improve usage information for -verbose option Message-ID: <20110627192308.E9DB347377@hg.openjdk.java.net> Changeset: a053c28304e8 Author: ksrini Date: 2011-06-27 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a053c28304e8 7046007: (launcher) Improve usage information for -verbose option Reviewed-by: darcy, alanb ! src/share/classes/sun/launcher/resources/launcher.properties From david.holmes at oracle.com Tue Jun 28 07:48:59 2011 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 28 Jun 2011 07:48:59 +0000 Subject: hg: jdk8/tl/jdk: 7039182: PPC: NIO: java.io.IOException: Invalid argument in sun.nio.ch.FileDispatcherImpl.read0 Message-ID: <20110628074919.BA2E5473A9@hg.openjdk.java.net> Changeset: 3abc52f0a4dc Author: dholmes Date: 2011-06-27 20:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3abc52f0a4dc 7039182: PPC: NIO: java.io.IOException: Invalid argument in sun.nio.ch.FileDispatcherImpl.read0 Summary: Allow platform specific files to be located at build time instead of generating them Reviewed-by: alanb, ohair ! make/common/Defs-embedded.gmk ! make/java/nio/Makefile From michael.x.mcmahon at oracle.com Tue Jun 28 09:10:45 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Tue, 28 Jun 2011 09:10:45 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110628091105.E2810473AD@hg.openjdk.java.net> Changeset: 7b5a0a141b8b Author: michaelm Date: 2011-06-28 10:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b5a0a141b8b 7058832: com/sun/net/httpserver/bugs/B6373555.java failing intermittently Reviewed-by: alanb ! test/com/sun/net/httpserver/bugs/B6373555.java Changeset: 585cc4a4528d Author: michaelm Date: 2011-06-28 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/585cc4a4528d Merge From lvjing at linux.vnet.ibm.com Thu Jun 30 04:32:04 2011 From: lvjing at linux.vnet.ibm.com (Jing LV) Date: Thu, 30 Jun 2011 12:32:04 +0800 Subject: lang-management modification - it may break customer application? Message-ID: <4E0BFC44.2020805@linux.vnet.ibm.com> Hello, I see there is some modifiction in the java.lang.management.ManagementFactory, e.g, newPlatformMXBeanProxy. The LogManager.LOGGING_MXBEAN_NAME in Java7 has been changed and now represents PlatformLoggingMXBean rather than java.util.logging.LoggingMXBean. I understand this is the stradegy to move all MXBean into java.lang.management package. However in JDK6, customers may already use java.lang.management.ManagementFactory.newPlatformMXBeanProxy(someserver, LogManager.LOGGING_MXBEAN_NAME, LoggingMXBean) to get LoggingMXBean and in JDK7 he would meet a IllegalArgumentException. I am wondering if there is a solution to avoid this, e.g, allow it still return LoggingMXBean? Thanks. -- Best Regards, Jimmy, Jing LV From mandy.chung at oracle.com Thu Jun 30 05:06:49 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 30 Jun 2011 13:06:49 +0800 Subject: lang-management modification - it may break customer application? In-Reply-To: <4E0BFC44.2020805@linux.vnet.ibm.com> References: <4E0BFC44.2020805@linux.vnet.ibm.com> Message-ID: <4E0C0469.6000505@oracle.com> Hi Jing, I'm including the serviceability-dev mailing list as java.lang.management is a serviceability feature. On 6/30/11 12:32 PM, Jing LV wrote: > Hello, > > I see there is some modifiction in the > java.lang.management.ManagementFactory, e.g, newPlatformMXBeanProxy. The > LogManager.LOGGING_MXBEAN_NAME in Java7 has been changed and now > represents PlatformLoggingMXBean rather than > java.util.logging.LoggingMXBean. If it's accessed via an MBeanServer, this should not make any difference since both LoggingMXBean and PlatformLoggingMXBean defines the same attributes. > I understand this is the stradegy to move all MXBean into > java.lang.management package. However in JDK6, customers may already use > java.lang.management.ManagementFactory.newPlatformMXBeanProxy(someserver, LogManager.LOGGING_MXBEAN_NAME, > LoggingMXBean) to get LoggingMXBean and in JDK7 he would meet a > IllegalArgumentException. This should work in both JDK 6 and JDK 7. A regression test in the JDK explicitly checks this method retains the same behavior: LoggingMXBean proxy = ManagementFactory.newPlatformMXBeanProxy(mbs, LogManager.LOGGING_MXBEAN_NAME, LoggingMXBean.class); See http://hg.openjdk.java.net/jdk7/tl/jdk/file/cfd7602f5c52/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java Do you have a test case reproducing IAE? Mandy From lvjing at linux.vnet.ibm.com Thu Jun 30 05:45:09 2011 From: lvjing at linux.vnet.ibm.com (Jing LV) Date: Thu, 30 Jun 2011 13:45:09 +0800 Subject: lang-management modification - it may break customer application? In-Reply-To: <4E0C0469.6000505@oracle.com> References: <4E0BFC44.2020805@linux.vnet.ibm.com> <4E0C0469.6000505@oracle.com> Message-ID: <4E0C0D65.3020804@linux.vnet.ibm.com> Hi Mandy, Thank you for reply. I am using a similar testcases but I see the problem is that it use a wrong PlatformMBeanServer - fix it will help to pass the testcase. Your reply helps me to understand the full picture, thank you. ? 2011-6-30 13:06, Mandy Chung ??: > Hi Jing, > > I'm including the serviceability-dev mailing list as > java.lang.management is a serviceability feature. > > On 6/30/11 12:32 PM, Jing LV wrote: >> Hello, >> >> I see there is some modifiction in the >> java.lang.management.ManagementFactory, e.g, newPlatformMXBeanProxy. The >> LogManager.LOGGING_MXBEAN_NAME in Java7 has been changed and now >> represents PlatformLoggingMXBean rather than >> java.util.logging.LoggingMXBean. > If it's accessed via an MBeanServer, this should not make any difference > since both LoggingMXBean and PlatformLoggingMXBean defines the same > attributes. >> I understand this is the stradegy to move all MXBean into >> java.lang.management package. However in JDK6, customers may already use >> java.lang.management.ManagementFactory.newPlatformMXBeanProxy(someserver, LogManager.LOGGING_MXBEAN_NAME, >> LoggingMXBean) to get LoggingMXBean and in JDK7 he would meet a >> IllegalArgumentException. > This should work in both JDK 6 and JDK 7. A regression test in the JDK > explicitly > checks this method retains the same behavior: > > LoggingMXBean proxy = > ManagementFactory.newPlatformMXBeanProxy(mbs, > LogManager.LOGGING_MXBEAN_NAME, > LoggingMXBean.class); > > See > http://hg.openjdk.java.net/jdk7/tl/jdk/file/cfd7602f5c52/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java > > Do you have a test case reproducing IAE? > > Mandy -- Best Regards, Jimmy, Jing LV From jonathan.gibbons at oracle.com Thu Jun 30 19:01:15 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 30 Jun 2011 19:01:15 +0000 Subject: hg: jdk8/tl/langtools: 7060926: Attr.PostAttrAnalyzer misses a case Message-ID: <20110630190117.B9B09470AD@hg.openjdk.java.net> Changeset: 858ae8fec72f Author: jjg Date: 2011-06-30 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/858ae8fec72f 7060926: Attr.PostAttrAnalyzer misses a case Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/failover/FailOver15.java + test/tools/javac/failover/FailOver15.out From zhong.j.yu at gmail.com Thu Jun 30 21:16:41 2011 From: zhong.j.yu at gmail.com (Zhong Yu) Date: Thu, 30 Jun 2011 16:16:41 -0500 Subject: Return type of Object.getClass() Message-ID: Why does it return Class instead of Class? Quote: The actual result type is Class where |X| is the erasure of the static type of the expression on which getClass is called. This means the following code does not compile T obj = ...; Class clazz = obj.getClass(); What's the reason for erasure here? Thanks. Zhong Yu From kumar.x.srinivasan at oracle.com Thu Jun 30 21:34:19 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 30 Jun 2011 21:34:19 +0000 Subject: hg: jdk8/tl/langtools: 7059905: (javadoc) promote method visibility for netbeans usage Message-ID: <20110630213421.29A3E470B9@hg.openjdk.java.net> Changeset: b0909f992710 Author: ksrini Date: 2011-06-30 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0909f992710 7059905: (javadoc) promote method visibility for netbeans usage Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java