Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied "risks"

Joe Darcy joe.darcy at oracle.com
Wed Jun 22 15:47:26 UTC 2011


David Holmes wrote:
> Hi Joe,
>
> Joe Darcy said the following on 06/18/11 11:38:
>> Please review this (somewhat tedious) change to make the behavior of 
>> the Number subtypes in the JDK more explicit:
>>
>>    6253144: Long narrowing conversion should describe the algorithm 
>> used and implied "risks"
>>    http://cr.openjdk.java.net/~darcy/6253144.0/
>>
>> David, how are changes to AtomicInteger and AtomicLong managed?
>
> Normally they would go into Doug Lea's CVS for jsr166, we (Chris 
> Hegarty) would pull them over and then push to OpenJDK. It can work 
> the other way but the sync's can get messier.
>

Chris,

Off-list, Mike approved this set of changes and I'd like to get them 
pushed once the matching ccc is approved.  (The ccc request is needed 
since the long-standing behavior of the non-abstract methods on number 
is being specified.)

How would you like to handle updates to the Atomic classes?

Thanks,

-Joe



More information about the core-libs-dev mailing list