review request for 7022624, convert java.io test to use try-with-resources

Alan Bateman Alan.Bateman at oracle.com
Tue Mar 1 15:45:18 UTC 2011


Rémi Forax wrote:
> :
>>
>>
>> try (ServerSocket listener = ss;
>>      Socket s = listener.accept();
>>      BufferedReader reader = new BufferedReader(new 
>> InputStreamReader(s.getInputStream()))
>> {
>>    ...
>> }
>>
>> While you are there, I assume ss should be final. 
>
> Local variables declared in a try-with resources are implicitly final.
True, but this was just a minor comment on the RHS where it would be 
clearer if ss were final.

-Alan



More information about the core-libs-dev mailing list