Review Request -- 5045147 : When TreeMap is empty explicitly check for null keys in put() [updated]

Steve Poole spoole at linux.vnet.ibm.com
Tue Mar 15 09:36:23 UTC 2011


On 14/03/11 21:02, Mike Duigou wrote:
> I've gotten feedback regarding this issue and I've updated the webrev to use the commented out compare(key, key) test rather than the previously committed solution. I hadn't looked at the commented out code too carefully and had assumed it was pseudo-code rather than an actual solution. It's an improvement over the original solution and reads, to me and apparently others, a lot simpler.
>
Hi - can you post the feedback to the mailing list?
> http://cr.openjdk.java.net/~mduigou/5045147/1/webrev/
>
> Also now included is a jtreg unit test.
>
> Mike




More information about the core-libs-dev mailing list