Review request for 6381464: "SimpleFormatter should use one single line format"

Mandy Chung mandy.chung at oracle.com
Tue Mar 29 05:18:09 UTC 2011


  On 3/28/11 9:45 PM, Alan Bateman wrote:
> Mandy Chung wrote:
>>
>> '\n' is a character added in the string created in L156 but not in a 
>> format string in which %n is used to represents a newline.
> I'm not sure about this one as \n might not be the line separator on 
> the platform. After creating the PrintWriter then could you use 
> pw.println() ?
>

That's a good suggestion.  I will do that.

> Otherwise the updated webrev looks good to me.
>

Thanks
Mandy




More information about the core-libs-dev mailing list