Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()

Alan Bateman Alan.Bateman at oracle.com
Mon May 2 18:12:07 UTC 2011


Xueming Shen wrote:
>  :
>
> Webrev has been updated accordingly.
>
> I renamed the getBBuffer to getByteBuffer, now it "looks" better:-)
The updated webrev looks fine to me. Personally I wouldn't have cached 
the byte buffer as the wrapping is not expensive (doesn't copy the 
array) and it's only used for the malformed case, but what you have is 
fine as we're out of time now.

-Alan



More information about the core-libs-dev mailing list