Code review request: 7107522: sun/misc/Version/Version.java fails because of its huge build number

[Alan Bateman]

On 02/11/2011 11:46, Weijun Wang wrote:
> http://cr.openjdk.java.net/~weijun/7107522/webrev.00/
>
> We must stay with the fact that a build number cannot exceed 255 while 
> the system property "java.runtime.version" might show a bigger one. 
> This fix only makes sure the test always passes.
Max - I don't have time to look into the issue just now but I assume 
that if you use a debug or fastdebug build that it will fall over during 
startup (in other words, changing the test may just mask the issue with 
product builds). I'm sure Kelly or Mandy will be able to point you to 
the right place but I think that the major, minor, micro and build 
numbers are encoded into an int. Maybe this needs to be caught at build 
time or VersionInfo.initVersions needs to catch this at startup or maybe 
the jvm_version needs more space to accommodate longer build numbers - 
sorry I can't give you a specific suggestion without spending time 
digging into it.

-Alan