Garbage collection race condition before final checks

Mandy Chung mandy.chung at oracle.com
Tue Nov 15 17:57:19 UTC 2011


  On 11/15/11 04:26, Gary Adams wrote:
>  Added PlatformLoggingMXBeanTest to the 7067691 bug fix,
> e.g. instance variables for Logger variables to prevent premature
> weak reference collection.
>
> http://cr.openjdk.java.net/~gadams/7067691/

LoggingMXBeanTest.java:  As Alan suggests, it'd be better to rename 
"lmxbeantest".  I think simply "test" would do it.
    L70: resetting null is not needed.
    L232, 234:  "(" and ")" brackets don't seem to be needed

PlatformLoggingMXBeanTest.java:
    Similar comments as I gave to LoggingMXBeanTest.java: need to add 
the CR # to @bug.  L48-49: a comment will prevent someone to back out 
this change to keep a strong reference in the future.

    Are you able to reproduce the test failure without moving L140-141?

Mandy



More information about the core-libs-dev mailing list