Code Review Request for Bug #5035850

Alan Bateman Alan.Bateman at oracle.com
Sun Nov 20 19:14:03 UTC 2011


On 18/11/2011 18:27, Darryl Mocek wrote:
> Hello.  Please review this patch to fix a serialization issue with 
> String's CASE_INSENSITIVE_ORDER.  If you serialize, then deserialize 
> the class, the equals test will fail in the comparison of what was 
> serialized with what was deserialized.  Webrev, including test, can be 
> found here: http://cr.openjdk.java.net/~sherman/darryl/5035850/webrev
>
> Thanks,
> Darryl
This looks okay to me but I would suggest adding a comment to 
readResolve, maybe something like "Replaces the de-serialized object" as 
the causal reader may not know what this method is for.

-Alan.



More information about the core-libs-dev mailing list