Code review - 6731620 TEST_BUG: java/util/Timer/Args.java is too optimistic about the execution time of System.out.printf

Alan Bateman Alan.Bateman at oracle.com
Mon Nov 21 13:05:31 UTC 2011


On 21/11/2011 12:45, Alan Bateman wrote:
> On 21/11/2011 12:17, Gary Adams wrote:
>> Here's a fresh bug number to handle the volatile revision (pun intended)
>>   7114125 java/util/Timer/KillThread.java should use volatile cross 
>> thread variable declaration
>>
>> Here's a fresh webrev for the proposed adjusted fix.
>>   http://cr.openjdk.java.net/~gadams/7114125/
>>
> This looks good to me.
I see David has reviewed this too so I've pushed this change (minus the 
addition to the @bug tag). I've also pushed your fix to the 
ThreadGroup/Stop.java test so I think this means we're now caught up on 
all your contributions to these tests.

-Alan.



More information about the core-libs-dev mailing list