Request for Review: 7094995: test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java causes continuous GC in agentvm mode

Alan Bateman Alan.Bateman at oracle.com
Wed Nov 23 14:46:55 UTC 2011


On 23/11/2011 13:29, Neil Richards wrote:
> :
> Thanks for all your guidance on this.
>
> I've uploaded another webrev [1], incorporating David's suggested ARM
> correction (thanks) and Chris' suggested handling of
> InterruptedException (together a System.out.println(), for clarity).
>
Looks fine to me too. I think your original try-with-resources usage was 
fine too because the ZipOutputStream constructor doesn't throw any 
exceptions (except perhaps a resource issue in the event that we're out 
of memory for example).

-Alan.



More information about the core-libs-dev mailing list