Codereview request: 7109837 Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer

Ulf Zibis Ulf.Zibis at gmx.de
Thu Nov 24 19:17:27 UTC 2011


Hi Sherman,

I would like a different computation of the percentages:

Am 23.11.2011 00:26, schrieb Xueming Shen:
> Length    byte[](ns/len)  ByteBuffer(direct)   ByteBuffer
> 1      13,409,610       2,990,525 (  77%)  13,196,357 (   1%)     checksum=bd00bd
> 2       5,808,804       1,664,460 (  71%)   7,069,931 ( -21%)     checksum=19000d3

In contrast to 'saved computation time' ...

either measured in 'performance gain':
1      13,409,610       2,990,525 (448%)  13,196,357 (102%)     checksum=bd00bd
2       5,808,804       1,664,460 (349%)   7,069,931 ( 82%)     checksum=19000d3

or measured in 'effective computation time':
1      13,409,610       2,990,525 ( 22%)  13,196,357 ( 98%)     checksum=bd00bd
2       5,808,804       1,664,460 ( 29%)   7,069,931 (122%)     checksum=19000d3

-Ulf




More information about the core-libs-dev mailing list