JDK 8 code review request for 6838776 Defer initialization of static fields in java.math.BigInteger

Joe Darcy joe.darcy at oracle.com
Sat Sep 3 17:25:49 UTC 2011


Mike Duigou wrote:
> Looks good. Nice little performance tweak.
>
> You may want to use ExceptionInInitializerError rather than plain Error.
>   

Yes; the more precise exception is better.  I've also moved the 
initialization of unsafe into the try block; updated webrev:

    http://cr.openjdk.java.net/~darcy/6838776.1/

Thanks,

-Joe

> Mike
>
> On Sep 2 2011, at 17:44 , joe.darcy at oracle.com wrote:
>
>   
>> Hello.
>>
>> Please review this change to only instantiated an Unsafe object in BigInteger and BigDecimal if serialization is done:
>>
>>   6838776 Defer initialization of static fields in java.math.BigInteger
>>   http://cr.openjdk.java.net/~darcy/6838776.0/
>>
>> Thanks,
>>
>> -Joe
>>     
>
>   




More information about the core-libs-dev mailing list