code review request: 7051946: Runtime.exec(String command) / ProcessBuilder command parsing issues
Alan Bateman
Alan.Bateman at oracle.com
Tue Sep 13 17:26:24 UTC 2011
Michael McMahon wrote:
> Can I get the following webrev reviewed please?
>
> http://cr.openjdk.java.net/~michaelm/7051946/webrev.1/
I scanned this briefly (I haven't done a detailed code review) but one
initial comment is that Runtime.exec will now throw
IllegalArgumenetException for that a case that isn't specified. The
current javadoc says it is only thrown "If command is empty" and maybe
this needs to be re-examined. I assume such cases would cause
IOException to be thrown today.
-Alan.
More information about the core-libs-dev
mailing list