Code review for 6915797 & 7090178
Alan Bateman
Alan.Bateman at oracle.com
Wed Sep 14 09:51:47 UTC 2011
Mandy Chung wrote:
> 6915797: Remove sun.tools.jar.JarImageSource that is not used
> 7090178: Move java.util.XMLUtils to another package to avoid split
> package
>
> Webrev at:
> http://cr.openjdk.java.net/~mchung/6915797/webrev.00/
>
> The synopsis says it all.
Mostly looks okay to me too. A few minor comments:
- I assume Properties.XMLUtils can be private.
- In the static initializer then CNFE is ignored but since XMLUtils
doesn't have a fallback for when sun.util.xml.XMLUtils is not present
then it might be better to have it fail earlier.
-Alan.
More information about the core-libs-dev
mailing list