JDK 8 code review request for 7091682 "Move sun.misc.FpUtils code into java.lang.Math"
Joe Darcy
joe.darcy at oracle.com
Mon Sep 19 01:07:17 UTC 2011
Mike Duigou wrote:
> I am curious why some of the tests still refer to FpUtils. For example:
>
> Log10Tests.java:
> 156 up = Math.nextUp(1.0);
> 157 down = FpUtils.nextDown(1.0);
>
> Would it be possible to further reduce or eliminate the references to FpUtils from the tests?
>
The nextDown method is in FpUtils, but not currently in java.lang.Math.
Assuming nextDown is added to Math, those references should be
eliminated too.
-Joe
> Mike
>
> On Sep 16 2011, at 18:52 , joe.darcy at oracle.com wrote:
>
>
>> Hello.
>>
>> Please review the changes to address
>>
>> 7091682 "Move sun.misc.FpUtils code into java.lang.Math"
>> http://cr.openjdk.java.net/~darcy/7091682.0/
>>
>> As implied by the synopsis, where appropriate JDK-implementation code used to provide functionality in java.lang.Math and java.lang.StrictMath is moved out of sun.misc.* and into java.lang.Math. Uses of methods available in java.lang.Math and switched to that entry point as opposed to the sun.misc one. Additionally, the sun.misc methods whose implementation was moved were also deprecated.
>>
>> Later in JDK 8, I will probably add some of the remaining un-deprecated methods in sun.misc.FpUtils as java.lang.Math/StrictMath methods.
>>
>> Thanks,
>>
>> -Joe
>>
>
>
More information about the core-libs-dev
mailing list