RFR 7116200: (cs) test/java/nio/charset/coders/StreamTimeout.java fails with "Address already in use"
Jim Gish
jim.gish at oracle.com
Wed Apr 11 18:06:12 UTC 2012
Hi,
Please review the following
Description:
The current code uses the fixed port of 22222 and the test fails if that
port is in use. The patch creates the socket on any open port using new
ServerSocket(0) and then determines the port in use with getLocalPort()
on the socket. That port is then used when creating the client. This
ensures the test won't fail with "address already in use".
Also, all sockets are closed when done. (Would appreciate comments on
whether I have engaged in overkill here, or not.)
Patch:
http://cr.openjdk.java.net/~jgish/7116200/webrev.00/
Tests run: jdk_nio3 -- all pass.
Thanks,
Jim Gish
More information about the core-libs-dev
mailing list