<core-libs-dev> New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparatorChar

Deven You youdwei at linux.vnet.ibm.com
Thu Apr 12 10:48:39 UTC 2012


Hi Alan,

I choose the test/sun/tools/classpath/ RMICClassPathTest.java because 
the fix is made in sun.tools.java.ClassPath.  However the test case uses 
BatchEnvironment.createClassPath to create a new ClassPath. I think 
test/sun/tools/classpath/ is more closer to sun.tools.java.ClassPath.

On 04/12/2012 04:26 PM, Alan Bateman wrote:
> On 12/04/2012 08:22, Deven You wrote:
>>
>> I have verified this commit. Thanks Alan and Charles!
> The change-set that Charles pushed added test/sun/tools/classpath/ 
> RMICClassPathTest.java but I didn't see it in the original webrev. I 
> see now that your original mail had the proposed test in a separate 
> webrev but I missed that. Anyway, one comment is that test has been 
> added to an odd location that doesn't correspond to where the fix was 
> made. I think test/sun/rmi/rmic would have been a more suitable location.
>
> -Alan.


-- 
Best Regards,

Deven




More information about the core-libs-dev mailing list